Stop being so bail-y in candidate assembly #132090
Open
+328
−240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
rustbot
added
S-waiting-on-review
|
Whoops, I wanted an lcnr vibe check r? lcnr |
compiler-errors
commented
Oct 24, 2024
| // may also be useful for predicates other than `Sized` | ||
| // Error type cannot possibly implement `Sized` (fixes #123154) | ||
| if let Err(e) = obligation.predicate.skip_binder().self_ty().error_reported() { | ||
| return Err(SelectionError::Overflow(e.into())); |
There was a problem hiding this comment.
:((((((((((( what the heck were we doing here!!
This comment has been minimized.
This comment has been minimized.
lcnr
reviewed
Oct 24, 2024
| @@ -0,0 +1,16 @@ | |||
| #![feature(dyn_compatible_for_dispatch)] | |||
|
|
|||
compiler-errors
force-pushed
the
baily
branch
from
be0b97f
to
6b46613
Compare
This comment has been minimized.
This comment has been minimized.
|
:think: i guess it's failing on |
|
☔ The latest upstream changes (presumably #132326) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errors
force-pushed
the
baily
branch
from
6b46613
to
0465f71
Compare
|
@rustbot ready |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 21, 2024
Stop being so bail-y in candidate assembly A conceptual follow-up to rust-lang#132084. We gotta stop bailing so much when there are errors; it's both unnecessary, leads to weird knock-on errors, and it's messing up the vibes lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A conceptual follow-up to #132084. We gotta stop bailing so much when there are errors; it's both unnecessary, leads to weird knock-on errors, and it's messing up the vibes lol