Make PointerLike opt-in instead of built-in
#133226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Nadrieril rustbot has assigned @Nadrieril. Use |
rustbot
added
S-waiting-on-review
|
r? lcnr |
lcnr
reviewed
Nov 20, 2024
lcnr
reviewed
Nov 20, 2024
lcnr
reviewed
Nov 20, 2024
|
this seems reasonable to me and r=me on the impl after nits, idk about the lang side here 😁 I agree with the backcompat concerns, I feel like layout cycles are something we can definitely solve in the solver |
compiler-errors
force-pushed
the
opt-in-pointer-like
branch
from
ccfe08a to
94260bd
Compare
|
I added two FIXMEs. @bors r=lcnr |
bors
added
S-waiting-on-bors
compiler-errors
force-pushed
the
opt-in-pointer-like
branch
from
94260bd to
228068b
Compare
|
@bors r=lcnr |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 20, 2024
…e, r=lcnr Make `PointerLike` opt-in instead of built-in The `PointerLike` trait currently is a built-in trait that computes the layout of the type. This is a bit problematic, because types implement this trait automatically. Since this can be broken due to semver-compatible changes to a type's layout, this is undesirable. Also, calling `layout_of` in the trait system also causes cycles. This PR makes the trait implemented via regular impls, and adds additional validation on top to make sure that those impls are valid. This could eventually be `derive()`d for custom smart pointers, and we can trust *that* as a semver promise rather than risking library authors accidentally breaking it. On the other hand, we may never expose `PointerLike`, but at least now the implementation doesn't invoke `layout_of` which could cause ICEs or cause cycles. Right now for a `PointerLike` impl to be valid, it must be an ADT that is `repr(transparent)` and the non-1zst field needs to implement `PointerLike`. There are also some primitive impls for `&T`/ `&mut T`/`*const T`/`*mut T`/`Box<T>`.
This was referenced Nov 20, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 20, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#129838 (uefi: process: Add args support) - rust-lang#130800 (Mark `get_mut` and `set_position` in `std::io::Cursor` as const.) - rust-lang#132708 (Point at `const` definition when used instead of a binding in a `let` statement) - rust-lang#133226 (Make `PointerLike` opt-in instead of built-in) - rust-lang#133244 (Account for `wasm32v1-none` when exporting TLS symbols) - rust-lang#133257 (Add `UnordMap::clear` method) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 21, 2024
Rollup merge of rust-lang#133226 - compiler-errors:opt-in-pointer-like, r=lcnr Make `PointerLike` opt-in instead of built-in The `PointerLike` trait currently is a built-in trait that computes the layout of the type. This is a bit problematic, because types implement this trait automatically. Since this can be broken due to semver-compatible changes to a type's layout, this is undesirable. Also, calling `layout_of` in the trait system also causes cycles. This PR makes the trait implemented via regular impls, and adds additional validation on top to make sure that those impls are valid. This could eventually be `derive()`d for custom smart pointers, and we can trust *that* as a semver promise rather than risking library authors accidentally breaking it. On the other hand, we may never expose `PointerLike`, but at least now the implementation doesn't invoke `layout_of` which could cause ICEs or cause cycles. Right now for a `PointerLike` impl to be valid, it must be an ADT that is `repr(transparent)` and the non-1zst field needs to implement `PointerLike`. There are also some primitive impls for `&T`/ `&mut T`/`*const T`/`*mut T`/`Box<T>`.
This was referenced Nov 21, 2024
celinval
added a commit
to celinval/rust-dev
that referenced
this pull request
Nov 29, 2024
78fc550 Auto merge of rust-lang#133247 - GuillaumeGomez:reduce-integer-display-impl, r=workingjubilee db5c2c6 Rollup merge of rust-lang#132982 - suaviloquence:2-doc-changed-alloc-methods, r=Mark-Simulacrum 117ad4f Rollup merge of rust-lang#132533 - SUPERCILEX:patch-4, r=Mark-Simulacrum e2aa7c1 fix `Allocator` method names in `alloc` free function docs 6b141ee Rollup merge of rust-lang#133298 - n0toose:remove-dir-all-but-not-paths, r=Noratrieb e3691db Rollup merge of rust-lang#133260 - compiler-errors:deref, r=fee1-dead 895f290 Rollup merge of rust-lang#132730 - joboet:after_main_sync, r=Noratrieb 6ffa455 Rollup merge of rust-lang#133389 - eduardosm:stabilize-const_float_methods, r=RalfJung f413935 Rollup merge of rust-lang#133301 - GuillaumeGomez:add-example-wrapping-neg, r=workingjubilee 6112cfd Auto merge of rust-lang#132611 - compiler-errors:async-prelude, r=ibraheemdev 23a5a0e Auto merge of rust-lang#132597 - lukas-code:btree-plug-leak, r=jhpratt f0b0942 Constify Deref and DerefMut d05e8e8 Auto merge of rust-lang#133379 - jieyouxu:rollup-00jxo71, r=jieyouxu 641c1ae Stabilize `const_float_methods` 256c54d Auto merge of rust-lang#133377 - jieyouxu:rollup-n536hzq, r=jieyouxu dff533f Improve code by using `unsigned_abs` a850f7c Rollup merge of rust-lang#133237 - fee1-dead-contrib:constadd, r=compiler-errors 99741dd Rollup merge of rust-lang#133332 - bjoernager:const-array-as-mut-slice, r=jhpratt 9a152e2 Rollup merge of rust-lang#131505 - madsmtm:darwin_user_temp_dir, r=dtolnay a12c838 Auto merge of rust-lang#132994 - clubby789:cc-bisect, r=Kobzol 6548ad8 Auto merge of rust-lang#133360 - compiler-errors:rollup-a2o38tq, r=compiler-errors a4f797e Rollup merge of rust-lang#133264 - lolbinarycat:os-string-truncate, r=joboet a939801 Auto merge of rust-lang#132329 - compiler-errors:fn-and-destruct, r=lcnr 30aa6db Add code example for `wrapping_neg` method for signed integers bc77567 Deduplicate checking drop terminator 6f3ec5c Gate const drop behind const_destruct feature, and fix const_precise_live_drops post-drop-elaboration check fb6f0c2 Auto merge of rust-lang#133339 - jieyouxu:rollup-gav0nvr, r=jieyouxu c792ef3 Rollup merge of rust-lang#133337 - ColinFinck:thread-scoped-fix-typo, r=joboet cfed1c6 Rollup merge of rust-lang#133330 - RalfJung:close, r=the8472 e26edf0 Rollup merge of rust-lang#133313 - thesummer:fix-arc4random, r=cuviper 90a85ef Rollup merge of rust-lang#133288 - bjoernager:const-array-each-ref, r=jhpratt 4e6f154 Rollup merge of rust-lang#133238 - heiher:loong-stdarch-rexport, r=Amanieu 23a1b31 Auto merge of rust-lang#130867 - michirakara:steps_between, r=dtolnay 9693572 Fix typo in `std::thread::Scope::spawn` documentation. b4a5067 Mark '<[T; N]>::as_mut_slice' as 'const'; b6b40ef library: update comment around close() 6ce7e79 Don't try to use confstr in Miri 40d6e2c Auto merge of rust-lang#129238 - umgefahren:stabilize-ipv6-unique-local, r=dtolnay 276c0fc distinguish overflow and unimplemented in Step::steps_between 8be952b Use arc4random of libc for RTEMS target 4583dde Mention that std::fs::remove_dir_all fails on files 4f6ca37 Mark and implement 'each_ref' and 'each_mut' in '[T; N]' as const; ec220b6 constify `Add` 3c558bf Rollup merge of rust-lang#131736 - hoodmane:emscripten-wasm-bigint, r=workingjubilee 38d4c11 implement OsString::truncate 4fd2c8d Rollup merge of rust-lang#133226 - compiler-errors:opt-in-pointer-like, r=lcnr 3f03a0f Rollup merge of rust-lang#130800 - bjoernager:const-mut-cursor, r=joshtriplett eea7e23 Rollup merge of rust-lang#129838 - Ayush1325:uefi-process-args, r=joboet 8b4995a Make PointerLike opt-in as a trait f74b38a Reduce integer `Display` implementation size 2f179d1 Stabilize const_pin_2 b2dc297 re-export `is_loongarch_feature_detected` e26c298 Rollup merge of rust-lang#132732 - gavincrawford:as_ptr_attribute, r=Urgau d6ee9db Rollup merge of rust-lang#133183 - n0toose:improve-remove-dir-docs, r=joboet 40735d3 Rollup merge of rust-lang#125405 - m-ou-se:thread-add-spawn-hook, r=WaffleLapkin 6c20348 Rollup merge of rust-lang#123947 - zopsicle:vec_deque-Iter-as_slices, r=Amanieu 2089cb3 Update doc comments for spawn hook. c02090d Address review comments. 79bffa9 Fix tracking issue. 3eff64c Add tracking issue. 15bac4f Use Send + Sync for spawn hooks. a42af06 Add thread Builder::no_hooks(). 49ac15b Update thread spawn hooks. 2cc4b2e Use add_spawn_hook for libtest's output capturing. 24a0765 Add std::thread::add_spawn_hook. 50ac725 Correct comments concerning updated dangling pointer lint cdf5486 Auto merge of rust-lang#133205 - matthiaskrgr:rollup-xhhhp5u, r=matthiaskrgr 543667a Rollup merge of rust-lang#133200 - RalfJung:miri-rwlock-test, r=tgross35 7430eb4 ignore an occasionally-failing test in Miri 607b493 Rollup merge of rust-lang#133182 - RalfJung:const-panic-inline, r=tgross35 e6cd122 Rollup merge of rust-lang#132758 - nnethercote:improve-get_key_value-docs, r=cuviper a3c9597 Mention std::fs::remove_dir_all in std::fs::remove_dir bd5c142 Bump `stdarch` to the latest master e84f865 const_panic: inline in bootstrap builds to avoid f16/f128 crashes 05fecb9 std: allow after-main use of synchronization primitives c1beb25 Auto merge of rust-lang#133160 - jhpratt:rollup-wzj9q15, r=jhpratt ce80c9f Rollup merge of rust-lang#133145 - kornelski:static-mutex, r=traviscross f385ac2 Auto merge of rust-lang#128219 - connortsui20:rwlock-downgrade, r=tgross35 86151ab rename rustc_const_stable_intrinsic -> rustc_intrinsic_const_stable_indirect a33f889 Improve `{BTreeMap,HashMap}::get_key_value` docs. 15e6fc0 Document alternatives to `static mut` 1cd1dd7 Auto merge of rust-lang#120370 - x17jiri:likely_unlikely_fix, r=saethlin e475f40 Likely unlikely fix ddcabfe Rollup merge of rust-lang#133126 - ohno418:fix-String-doc, r=jhpratt e4eff6a Rollup merge of rust-lang#133116 - RalfJung:const-null-ptr, r=dtolnay 16e6d20 alloc: fix `String`'s doc e4fb962 clean up const stability around UB checks ee78601 stabilize const_ptr_is_null 1e4a9ee Rollup merge of rust-lang#132449 - RalfJung:is_val_statically_known, r=compiler-errors 1dfe94c Rollup merge of rust-lang#131717 - tgross35:stabilize-const_atomic_from_ptr, r=RalfJung 70326e8 reduce threads in downgrade test d58e4f2 fix `DOWNGRADED` bit unpreserved 5d68316 fix memory ordering bug + bad test 0604b8f add safety comments for queue implementation 00255e6 add `downgrade` to `queue` implementation 40256c6 modify queue implementation documentation f804164 add `downgrade` to `futex` implementation 572aded add simple `downgrade` implementations 48bcf09 add `downgrade` method onto `RwLockWriteGuard` 5416aef add `RwLock` `downgrade` tests 4010980 Rollup merge of rust-lang#133050 - tgross35:inline-f16-f128, r=saethlin 2ee4159 Rollup merge of rust-lang#133048 - cyrgani:ptr-doc-update, r=Amanieu e1448de Rollup merge of rust-lang#133019 - sorairolake:add-missing-period-and-colon, r=tgross35 b1d31d2 Rollup merge of rust-lang#132984 - sunshowers:pipe2, r=tgross35 8cef1ef Rollup merge of rust-lang#132977 - cberner:fix_solaris, r=tgross35 daa9c43 Rollup merge of rust-lang#132790 - aDotInTheVoid:ioslice-asslice-rides-again, r=cuviper cdb5ff5 Pass `f16` and `f128` by value in `const_assert!` 60ef479 use `&raw` in `{read, write}_unaligned` documentation d2983ff Auto merge of rust-lang#132709 - programmerjake:optimize-charto_digit, r=joshtriplett 918cc8d Rollup merge of rust-lang#133027 - no1wudi:master, r=jhpratt 25f5512 Auto merge of rust-lang#133026 - workingjubilee:rollup-q8ig6ah, r=workingjubilee d8de2cc Fix a copy-paste issue in the NuttX raw type definition c06bb34 Rollup merge of rust-lang#133008 - onur-ozkan:update-outdated-comment, r=jieyouxu 8eaea39 Rollup merge of rust-lang#133004 - cuviper:unrecover-btree, r=ibraheemdev 81a191a Rollup merge of rust-lang#133003 - zachs18:clonetouninit-dyn-compat-u8, r=dtolnay e3e5e35 Rollup merge of rust-lang#132907 - BLANKatGITHUB:intrinsic, r=saethlin f57853b Rollup merge of rust-lang#131304 - RalfJung:float-core, r=tgross35 7bc0436 Auto merge of rust-lang#122770 - iximeow:ixi/int-formatting-optimization, r=workingjubilee ce2e318 docs: Fix missing colon in methods for primitive types 1870e92 docs: Fix missing period in methods for integer types 6439774 Auto merge of rust-lang#133006 - matthiaskrgr:rollup-dz6oiq5, r=matthiaskrgr 98dad0b update outdated comment about test-float-parse 520d4fd Rollup merge of rust-lang#126046 - davidzeng0:mixed_integer_ops_unsigned_sub, r=Amanieu e3c425b Auto merge of rust-lang#132662 - RalfJung:const-panic-inlining, r=tgross35 c4b77cf Update core CloneToUninit tests d4e21f5 btree: simplify the backdoor between set and map 5d61cf9 Bump `cc` 44f376b Fix compilation error on Solaris due to flock usage 75609d6 Auto merge of rust-lang#132556 - clubby789:cargo-update, r=Mark-Simulacrum 5ba28a4 Run `cargo update` and update licenses 0820004 const_panic: don't wrap it in a separate function d30e2c0 [illumos] use pipe2 to create anonymous pipes 7e12686 Auto merge of rust-lang#132883 - LaihoE:vectorized_is_sorted, r=thomcc 02e32d7 Auto merge of rust-lang#132972 - matthiaskrgr:rollup-456osr7, r=matthiaskrgr 157eb1c Rollup merge of rust-lang#132970 - tyilo:nonzero-u-div-ceil-issue, r=tgross35 03e52a5 Rollup merge of rust-lang#132966 - RalfJung:const_option_ext, r=jhpratt 2f615a1 Rollup merge of rust-lang#132948 - RalfJung:const_unicode_case_lookup, r=Noratrieb f00e091 Rollup merge of rust-lang#132851 - chansuke:update-comment, r=thomcc 6560098 Auto merge of rust-lang#132870 - Noratrieb:inline-int-parsing, r=tgross35 a0c0c40 Add tracking issue number to unsigned_nonzero_div_ceil feature c229666 Make `CloneToUninit` dyn-compatible 6ab50dd stabilize const_option_ext 27fe6c7 Rollup merge of rust-lang#132541 - RalfJung:const-stable-extern-crate, r=compiler-errors 7fafe99 stabilize const_unicode_case_lookup c5ed625 Stabilize `Ipv6Addr::is_unique_local` and `Ipv6Addr::is_unicast_link_local` e0452c9 adds new declaration to codegen 33fa870 Auto merge of rust-lang#132943 - matthiaskrgr:rollup-164l3ej, r=matthiaskrgr 7f12f02 Rollup merge of rust-lang#132914 - rcorre:cell-grammar, r=tgross35 300a266 Rollup merge of rust-lang#132895 - scottmcm:generalize-nonnull-from-raw-parts, r=ibraheemdev a461cf9 remove no-longer-needed abs_private 170e993 allow rustc_private feature in force-unstable-if-unmarked crates 4a20245 Rollup merge of rust-lang#132929 - cuviper:check-alloc_zeroed, r=tgross35 992bbf7 Rollup merge of rust-lang#132869 - lolbinarycat:library-fix-too_long_first_doc_paragraph, r=tgross35 e3925fa Rollup merge of rust-lang#132847 - RalfJung:addr-dont-expose, r=Mark-Simulacrum 327a0d7 Auto merge of rust-lang#132919 - matthiaskrgr:rollup-ogghyvp, r=matthiaskrgr 67c3c9f Check for null in the `alloc_zeroed` example 068537a new intrinsic declaration b689951 new intrinsic declaration 16fa12e Rollup merge of rust-lang#132144 - adetaylor:receiver-trait-itself, r=wesleywiser 54f699d Rollup merge of rust-lang#120077 - SUPERCILEX:set-entry, r=Amanieu e541a4f Update dangling pointer tests 7707584 Tag relevant functions with #[rustc_as_ptr] attribute b541c5a Auto merge of rust-lang#132902 - matthiaskrgr:rollup-43qgg3t, r=matthiaskrgr 2d676d4 Update grammar in std::cell docs. 7325f33 Emscripten: link with -sWASM_BIGINT 1c482c9 Rollup merge of rust-lang#130999 - cberner:flock_pr, r=joboet 4dd2270 Auto merge of rust-lang#127589 - notriddle:notriddle/search-sem-3, r=GuillaumeGomez 0af64b6 Generalize `NonNull::from_raw_parts` per ACP362 2fd9ac4 vectorize slice::is_sorted 737521c `#[inline]` integer parsing functions b9be1dd split up the first paragraph of doc comments for better summaries f9063ff Update the doc comment of `ASCII_CASE_MASK` 57c7b80 elem_offset / subslice_range: use addr() instead of 'as usize' d19aa69 Rollup merge of rust-lang#132136 - RalfJung:target-feature-abi-compat, r=Mark-Simulacrum 6b0bd5a honor rustc_const_stable_indirect in non-staged_api crate with -Zforce-unstable-if-unmarked 070baf4 Add as_slice/into_slice for IoSlice/IoSliceMut. 978a553 Rollup merge of rust-lang#132778 - lolbinarycat:io-Error-into_inner-docs, r=cuviper 6d54bfe update io::Error::into_inner to acknowlage io::Error::other 7c0a90c Address review comments ac66068 Update library/std/src/sys/pal/windows/fs.rs d90f866 Auto merge of rust-lang#132717 - RalfJung:rustc_safe_intrinsic, r=compiler-errors f2bf9e6 remove support for rustc_safe_intrinsic attribute; use rustc_intrinsic functions instead 2391b4b Rollup merge of rust-lang#132738 - cuviper:channel-heap-init, r=ibraheemdev 086cfef mark is_val_statically_known intrinsic as stably const-callable dffc5e7 Rollup merge of rust-lang#132696 - fortanix:raoul/rte-235-fix_fmodl_missing_symbol_issue, r=tgross35 f14fc56 Rollup merge of rust-lang#132639 - RalfJung:intrinsics, r=workingjubilee,Amanieu 6d63012 Initialize channel `Block`s directly on the heap 7ff251b core: move intrinsics.rs into intrinsics folder 6244f48 Auto merge of rust-lang#132714 - mati865:update-memchr, r=tgross35 a2eaef7 Rollup merge of rust-lang#132715 - tabokie:fix-lazy-lock-doc, r=Noratrieb 6a77b21 Rollup merge of rust-lang#132665 - tyilo:nonzero-u-div-ceil, r=joboet 79d2063 Separate f128 `%` operation to deal with missing `fmodl` symbol 8022523 Auto merge of rust-lang#132705 - kornelski:inline-repeat, r=tgross35 df9f5db fix lazylock comment 7a82eb5 Auto merge of rust-lang#131888 - ChrisDenton:deopt, r=ibraheemdev 75b9ce3 unpin and update memchr 4d1c7d9 optimize char::to_digit and assert radix is at least 2 95bff3e Inline str::repeat 52c2a45 Rollup merge of rust-lang#132617 - uellenberg:fix-rendered-doc, r=cuviper 28f7e7b Auto merge of rust-lang#131721 - okaneco:const_eq_ignore_ascii_case, r=m-ou-se 41b7e5f Auto merge of rust-lang#132500 - RalfJung:char-is-whitespace-const, r=jhpratt 4ed08bd Add new unstable feature `const_eq_ignore_ascii_case` f4e9fe4 Auto merge of rust-lang#132664 - matthiaskrgr:rollup-i27nr7i, r=matthiaskrgr afc66fe Change some code blocks to quotes in rendered std doc 2e63cbd Rollup merge of rust-lang#131261 - clarfonthey:unsafe-cell-from-mut, r=m-ou-se ab6f663 Auto merge of rust-lang#132661 - matthiaskrgr:rollup-npytbl6, r=matthiaskrgr 8b165db Implement div_ceil for NonZero<unsigned> 6bc1b1b Rollup merge of rust-lang#132571 - RalfJung:const_eval_select_macro, r=oli-obk c12f4d1 Rollup merge of rust-lang#132473 - ZhekaS:core_fmt_radix_no_panic, r=joboet bbb9275 Rollup merge of rust-lang#132153 - bjoernager:const-char-encode-utf16, r=dtolnay 919de70 add const_eval_select macro to reduce redundancy 538f5b4 Rollup merge of rust-lang#132609 - NotWearingPants:patch-1, r=Amanieu 86c6f27 Rollup merge of rust-lang#132606 - eduardosm:char-slice-str-pattern-doc, r=tgross35 4660d7e most const intrinsics don't need an explicit rustc_const_unstable any more 8eb30fe add new rustc_const_stable_intrinsic attribute for const-stable intrinsics 792d164 convert all const-callable intrinsics into the new form (without extern block) fad7d68 docs: fix grammar in doc comment at unix/process.rs 92bb779 Improve example of `impl Pattern for &[char]` 553bb18 Add AsyncFn* to to the prelude in all editions 2ae24bf Fixed typo, rebased 47f60d7 Updated SAFETY comment to address underflow 581aa8d Replace checked slice indexing by unchecked to support panic-free code c5a0f6c Rollup merge of rust-lang#132579 - RalfJung:rustc-std-workspace-crates, r=Amanieu 9cdbf39 btree: don't leak value if destructor of key panics 4caff13 Stabilise 'const_char_encode_utf16'; 84fae7e Auto merge of rust-lang#132586 - workingjubilee:rollup-qrmn49a, r=workingjubilee 95b4127 update rustc-std-workspace crates 082b98d Rollup merge of rust-lang#132423 - RalfJung:const-eval-align-offset, r=dtolnay 3b40634 Auto merge of rust-lang#132434 - tgross35:f128-tests, r=workingjubilee 5dea8b2 Enable `f128` tests on all non-buggy platforms 🎉 2bb8ea3 Auto merge of rust-lang#132581 - workingjubilee:rollup-4wj318p, r=workingjubilee 83bd286 Update `compiler_builtins` to 0.1.138 and pin it 699702f Rollup merge of rust-lang#132563 - frectonz:master, r=Amanieu 4390c35 Auto merge of rust-lang#123723 - madsmtm:apple-std-os, r=dtolnay 1e8ed90 Auto merge of rust-lang#132479 - compiler-errors:fx-feat-yeet, r=fee1-dead 9a3b7c0 Rename the FIXMEs, remove a few that dont matter anymore ed4f110 Auto merge of rust-lang#132542 - RalfJung:const_panic, r=tgross35 d8bca01 remove const-support for align_offset 76b866c Modify `NonZero` documentation to reference the underlying integer type 9e57964 Rollup merge of rust-lang#132511 - RalfJung:const_arguments_as_str, r=dtolnay bfeeb74 Rollup merge of rust-lang#132503 - RalfJung:const-hash-map, r=Amanieu a42fc21 Rollup merge of rust-lang#132499 - RalfJung:unicode_data.rs, r=tgross35 0278cab Rollup merge of rust-lang#132393 - zedddie16:issue-131865-fix, r=tgross35 714115a Rollup merge of rust-lang#131377 - rick-de-water:nonzero-exp, r=dtolnay 9789c54 Rollup merge of rust-lang#129329 - eduardosm:rc-from-mut-slice, r=dtolnay ff9178b add const_panic macro to make it easier to fall back to non-formatting panic in const 9ef483b stabilize const_arguments_as_str 4c6593f Auto merge of rust-lang#132458 - RalfJung:rustc-const-unstable, r=Amanieu 81b20e0 Rustdoc: added brief colon explanation 73d9f4d Add Set entry API e883a60 Add BorrowedBuf::into_filled{,_mut} methods to allow returning buffer with original lifetime 261c5b9 remove const_hash feature leftovers d515da6 const_with_hasher test: actually construct a usable HashMap 11dc6c3 make char::is_whitespace unstably const 1a481fd unicode_data.rs: show command for generating file 3a5b026 get rid of a whole bunch of unnecessary rustc_const_unstable attributes 2e24b7f remove no-longer-needed attribute ffbcba0 add missing safety comments 768d0cd adjust test gating for f16/f128 6335056 float types: move copysign, abs, signum to libcore c353337 rustdoc-search: simplify rules for generics and type params 9d10ab7 Implement `From<&mut {slice}>` for `Box/Rc/Arc<{slice}>` 34329c0 Stabilize `const_atomic_from_ptr` a2e1edf Arbitrary self types v2: (unused) Receiver trait 2d26681 ABI compatibility: remove section on target features f1c9904 Support lock() and lock_shared() on async IO Files 7f6af4d Revert using `HEAP` static in Windows alloc 541bda1 Implement file_lock feature d7a7b0a uefi: process: Add args support 14aef3d Use with_capacity(0) because we're reading the capacity later on 5b16abe Prefer `target_vendor = "apple"` on confstr bc63981 use `confstr(_CS_DARWIN_USER_TEMP_DIR, ...)` as a `TMPDIR` fallback on darwin f8dc879 Add LowerExp and UpperExp implementations 50afc52 Stabilize UnsafeCell::from_mut aa74e93 Mark 'get_mut' and 'set_position' in 'std::io::Cursor' as const; c370665 Make `std::os::darwin` public 797c249 Implement `mixed_integer_ops_unsigned_sub` ff1212e Add vec_deque::Iter::as_slices and friends e938dea try adding a test that LowerHex and friends don't panic, but it doesn't work c6d2bb7 improve codegen of fmt_num to delete unreachable panic git-subtree-dir: library git-subtree-split: 78fc550
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 20, 2024
… r=compiler-errors unimplement `PointerLike` for trait objects Values of type `dyn* PointerLike` or `dyn PointerLike` are not pointer-like so these types should not implement `PointerLike`. After rust-lang#133226, `PointerLike` allows user implementations, so we can't just mark it with `#[rustc_deny_explicit_impl(implement_via_object = false)]`. Instead, this PR splits the `#[rustc_deny_explicit_impl(implement_via_object = ...)]` attribute into two separate attributes `#[rustc_deny_explicit_impl]` and `#[rustc_do_not_implement_via_object]` so that we opt out of the automatic `impl PointerLike for dyn PointerLike` and still allow user implementations. For traits that are marked with `#[do_not_implement_via_object]` but not `#[rustc_deny_explicit_impl]` I've also made it possible to add a manual `impl Trait for dyn Trait`. There is no immediate need for this, but it was one line to implement and seems nice to have. fixes rust-lang#134545 fixes rust-lang#134543 r? `@compiler-errors`
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 20, 2024
Rollup merge of rust-lang#134573 - lukas-code:unimpl-dyn-pointerlike, r=compiler-errors unimplement `PointerLike` for trait objects Values of type `dyn* PointerLike` or `dyn PointerLike` are not pointer-like so these types should not implement `PointerLike`. After rust-lang#133226, `PointerLike` allows user implementations, so we can't just mark it with `#[rustc_deny_explicit_impl(implement_via_object = false)]`. Instead, this PR splits the `#[rustc_deny_explicit_impl(implement_via_object = ...)]` attribute into two separate attributes `#[rustc_deny_explicit_impl]` and `#[rustc_do_not_implement_via_object]` so that we opt out of the automatic `impl PointerLike for dyn PointerLike` and still allow user implementations. For traits that are marked with `#[do_not_implement_via_object]` but not `#[rustc_deny_explicit_impl]` I've also made it possible to add a manual `impl Trait for dyn Trait`. There is no immediate need for this, but it was one line to implement and seems nice to have. fixes rust-lang#134545 fixes rust-lang#134543 r? `@compiler-errors`
kpreid
added a commit
to kpreid/rust
that referenced
this pull request
Dec 21, 2024
Since <rust-lang#133226>, it is no longer automatically implemented, but must be manually implemented.
kpreid
added a commit
to kpreid/rust
that referenced
this pull request
Dec 21, 2024
Since <rust-lang#133226>, it is no longer automatically implemented, but must be manually implemented, with special restrictions. The documentation now (roughly) explains those special restrictions.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 22, 2024
Document `PointerLike` implementation restrictions. Since <rust-lang#133226>, it is no longer automatically implemented, but must be manually implemented, with special restrictions. The documentation now (roughly) explains those special restrictions. cc `@compiler-errors` (author of the previous PR)
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 22, 2024
Rollup merge of rust-lang#134602 - kpreid:pointerlike-doc, r=tgross35 Document `PointerLike` implementation restrictions. Since <rust-lang#133226>, it is no longer automatically implemented, but must be manually implemented, with special restrictions. The documentation now (roughly) explains those special restrictions. cc `@compiler-errors` (author of the previous PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PointerLiketrait currently is a built-in trait that computes the layout of the type. This is a bit problematic, because types implement this trait automatically. Since this can be broken due to semver-compatible changes to a type's layout, this is undesirable. Also, callinglayout_ofin the trait system also causes cycles.This PR makes the trait implemented via regular impls, and adds additional validation on top to make sure that those impls are valid. This could eventually be
derive()d for custom smart pointers, and we can trust that as a semver promise rather than risking library authors accidentally breaking it.On the other hand, we may never expose
PointerLike, but at least now the implementation doesn't invokelayout_ofwhich could cause ICEs or cause cycles.Right now for a
PointerLikeimpl to be valid, it must be an ADT that isrepr(transparent)and the non-1zst field needs to implementPointerLike. There are also some primitive impls for&T/&mut T/*const T/*mut T/Box<T>.