Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vec_deque::Iter::as_slices and friends #123947

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

zopsicle
Copy link
Contributor

Add the following methods, that work similarly to VecDeque::as_slices:

  • alloc::collections::vec_deque::Iter::as_slices
  • alloc::collections::vec_deque::IterMut::into_slices
  • alloc::collections::vec_deque::IterMut::as_slices
  • alloc::collections::vec_deque::IterMut::as_mut_slices

Obtaining slices from a VecDeque iterator was not previously possible.

@rustbot
Copy link
Collaborator

rustbot commented Apr 14, 2024

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 14, 2024
Add the following methods, that work similarly to VecDeque::as_slices:

 - alloc::collections::vec_deque::Iter::as_slices
 - alloc::collections::vec_deque::IterMut::into_slices
 - alloc::collections::vec_deque::IterMut::as_slices
 - alloc::collections::vec_deque::IterMut::as_mut_slices

Obtaining slices from a VecDeque iterator was not previously possible.
@zopsicle zopsicle marked this pull request as ready for review April 14, 2024 22:38
@joboet
Copy link
Member

joboet commented Apr 15, 2024

r? libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Apr 15, 2024
@rustbot rustbot assigned BurntSushi and unassigned joboet Apr 15, 2024
@Amanieu Amanieu added I-libs-api-nominated Nominated for discussion during a libs-api team meeting. and removed I-libs-api-nominated Nominated for discussion during a libs-api team meeting. labels Nov 13, 2024
@Amanieu
Copy link
Member

Amanieu commented Nov 19, 2024

@bors r+

@joboet
Copy link
Member

joboet commented Nov 19, 2024

@bors r=Amanieu

@joboet
Copy link
Member

joboet commented Nov 19, 2024

Sigh... bors has some troubles recently. Last time I saw this, closing and reopening did the trick.

@joboet joboet closed this Nov 19, 2024
@joboet joboet reopened this Nov 19, 2024
@joboet
Copy link
Member

joboet commented Nov 19, 2024

@bors r=Amanieu

@bors
Copy link
Contributor

bors commented Nov 19, 2024

📌 Commit 4a5bcbb has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 19, 2024
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#123947 (Add vec_deque::Iter::as_slices and friends)
 - rust-lang#125405 (Add std::thread::add_spawn_hook.)
 - rust-lang#133175 (ci: use free runner in dist-i686-msvc)
 - rust-lang#133183 (Mention std::fs::remove_dir_all in std::fs::remove_dir)
 - rust-lang#133188 (Add `visit` methods to ast nodes that already have `walk`s on ast visitors)
 - rust-lang#133201 (Remove `TokenKind::InvalidPrefix`)
 - rust-lang#133207 (Default-enable `llvm_tools_enabled` when no `config.toml` is present)
 - rust-lang#133213 (Correct the tier listing of `wasm32-wasip2`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 001f98a into rust-lang:master Nov 20, 2024
17 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 20, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 20, 2024
Rollup merge of rust-lang#123947 - zopsicle:vec_deque-Iter-as_slices, r=Amanieu

Add vec_deque::Iter::as_slices and friends

Add the following methods, that work similarly to VecDeque::as_slices:

 - alloc::collections::vec_deque::Iter::as_slices
 - alloc::collections::vec_deque::IterMut::into_slices
 - alloc::collections::vec_deque::IterMut::as_slices
 - alloc::collections::vec_deque::IterMut::as_mut_slices

Obtaining slices from a VecDeque iterator was not previously possible.
@zopsicle zopsicle deleted the vec_deque-Iter-as_slices branch November 20, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants