Rollup of 8 pull requests #133219

matthiaskrgr · 2024-11-19T21:24:49Z

Successful merges:

Add vec_deque::Iter::as_slices and friends #123947 (Add vec_deque::Iter::as_slices and friends)
Add std::thread::add_spawn_hook. #125405 (Add std::thread::add_spawn_hook.)
ci: use free runner in dist-i686-msvc #133175 (ci: use free runner in dist-i686-msvc)
Mention std::fs::remove_dir_all in std::fs::remove_dir #133183 (Mention std::fs::remove_dir_all in std::fs::remove_dir)
Add visit methods to ast nodes that already have walks on ast visitors #133188 (Add visit methods to ast nodes that already have walks on ast visitors)
Remove TokenKind::InvalidPrefix #133201 (Remove TokenKind::InvalidPrefix)
Default-enable llvm_tools_enabled when no config.toml is present #133207 (Default-enable llvm_tools_enabled when no config.toml is present)
Correct the tier listing of wasm32-wasip2 #133213 (Correct the tier listing of wasm32-wasip2)

r? @ghost
@rustbot modify labels: rollup

Add the following methods, that work similarly to VecDeque::as_slices: - alloc::collections::vec_deque::Iter::as_slices - alloc::collections::vec_deque::IterMut::into_slices - alloc::collections::vec_deque::IterMut::as_slices - alloc::collections::vec_deque::IterMut::as_mut_slices Obtaining slices from a VecDeque iterator was not previously possible.

- Rename it as `invalid_ident_or_prefix`, which matches the possible outputs (`InvalidIdent` or `InvalidPrefix`). - Use the local wrapper for `is_xid_continue`, for consistency. - Make it clear what `\u{200d}` means.

- Improve wording. - Use backticks consistently for examples.

It was added in rust-lang#123752 to handle some cases involving emoji, but it isn't necessary because it's always treated the same as `TokenKind::InvalidIdent`. This commit removes it, which makes things a little simpler.

This target is tier 2, not tier 3, and I forgot to update this. Closes rust-lang#133206

1. Make the effect thread local. 2. Don't return a io::Result from hooks.

Co-authored-by: waffle <waffle.lapkin@gmail.com>

… r=Amanieu Add vec_deque::Iter::as_slices and friends Add the following methods, that work similarly to VecDeque::as_slices: - alloc::collections::vec_deque::Iter::as_slices - alloc::collections::vec_deque::IterMut::into_slices - alloc::collections::vec_deque::IterMut::as_slices - alloc::collections::vec_deque::IterMut::as_mut_slices Obtaining slices from a VecDeque iterator was not previously possible.

…affleLapkin Add std::thread::add_spawn_hook. Implementation of rust-lang/rfcs#3642

…obzol ci: use free runner in dist-i686-msvc try-job: dist-i686-msvc

…=joboet Mention std::fs::remove_dir_all in std::fs::remove_dir

…chenkov Add `visit` methods to ast nodes that already have `walk`s on ast visitors Some `walk` functions are called directly, because there were no correspondent visit functions. related to rust-lang#128974 & rust-lang#127615 r? `@petrochenkov`

…efix, r=compiler-errors Remove `TokenKind::InvalidPrefix` It's not needed. Best reviewed one commit at a time. r? `@estebank`

…jorn3 Default-enable `llvm_tools_enabled` when no `config.toml` is present Fixes rust-lang#133195. cc `@wesleywiser` could you double check if with this patch and no `config.toml` that you can run `./x test tests/ui --stage 1`? `llvm-objcopy` is usually required by cg_ssa on macOS to workaround bad `strip`s. cc `@bjorn3` I hope this doesn't break cg_clif... r? bootstrap

…ieyouxu Correct the tier listing of `wasm32-wasip2` This target is tier 2, not tier 3, and I forgot to update this. Closes rust-lang#133206

matthiaskrgr · 2024-11-19T21:25:00Z

@bors r+ rollup=never p=8

bors · 2024-11-19T21:25:03Z

📌 Commit 2467654 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2024-11-19T23:04:48Z

⌛ Testing commit 2467654 with merge 875df37...

bors · 2024-11-20T02:09:42Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 875df37 to master...

rust-timer · 2024-11-20T02:11:58Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#123947	Add vec_deque::Iter::as_slices and friends	`78f875c9813ca860da336d1df0a9387dcd38f5d1` (link)
#125405	Add std::thread::add_spawn_hook.	`a61396c0820e822882cda84ef2f229f1cb9ff498` (link)
#133175	ci: use free runner in dist-i686-msvc	`3be898d7a8becbab8c0c21b8ab8facf44289c42c` (link)
#133183	Mention std::fs::remove_dir_all in std::fs::remove_dir	`e6446018134f7ded45f0f6ad1c115c19ac3d4f68` (link)
#133188	Add `visit` methods to ast nodes that already have `walk`s …	`6c9b190761290010f4fba7be14ba09168132ff13` (link)
#133201	Remove `TokenKind::InvalidPrefix`	`43ee522bbca9773b8aca64bdac8a58f5de9b87b9` (link)
#133207	Default-enable `llvm_tools_enabled` when no `config.toml` i…	`166cf0aa1741588444043b6efc4a9a7b87b83755` (link)
#133213	Correct the tier listing of `wasm32-wasip2`	`1ea2fe3f70b66dabdbfde4a3280c865696064fbe` (link)

previous master: ee612c45f0

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-11-20T03:27:50Z

Finished benchmarking commit (875df37): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.2%, 1.1%]	6
Regressions ❌ (secondary)	0.5%	[0.3%, 1.2%]	13
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.7%	[0.2%, 1.1%]	6

Max RSS (memory usage)

Results (primary 2.5%, secondary -2.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.5%	[2.2%, 2.7%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-2.6%, -2.6%]	1
All ❌✅ (primary)	2.5%	[2.2%, 2.7%]	2

Cycles

Results (secondary -2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.1%, -2.1%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results (primary 0.3%, secondary 0.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.0%, 1.0%]	26
Regressions ❌ (secondary)	0.6%	[0.1%, 1.0%]	74
Improvements ✅ (primary)	-0.0%	[-0.0%, -0.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[-0.0%, 1.0%]	27

Bootstrap: 795.801s -> 793.735s (-0.26%)
Artifact size: 335.27 MiB -> 335.41 MiB (0.04%)

lqd · 2024-11-20T06:26:44Z

There's not much in this PR... This feels like noise, but we'll see on the next merge.

chloekek and others added 30 commits April 15, 2024 00:31

ci: use free runner in dist-i686-msvc

37ea202

Add Visitor::visit_fn_decl

09c2684

Add Visitor::visit_qself

e65deb5

Add MutVisitor::visit_fn_ret_ty

f6340f1

Mention std::fs::remove_dir_all in std::fs::remove_dir

7bffa31

Improve fake_ident_or_unknown_prefix.

df29f9b

- Rename it as `invalid_ident_or_prefix`, which matches the possible outputs (`InvalidIdent` or `InvalidPrefix`). - Use the local wrapper for `is_xid_continue`, for consistency. - Make it clear what `\u{200d}` means.

Improve TokenKind comments.

2c7c369

- Improve wording. - Use backticks consistently for examples.

Remove TokenKind::InvalidPrefix.

e9a0c3c

It was added in rust-lang#123752 to handle some cases involving emoji, but it isn't necessary because it's always treated the same as `TokenKind::InvalidIdent`. This commit removes it, which makes things a little simpler.

Default-enable llvm_tools_enabled when no config.toml is present

38f0c09

Register change info

fcfb782

Explicitly disable llvm tools for cranelift

4b5c883

Correct the tier listing of wasm32-wasip2

616013f

This target is tier 2, not tier 3, and I forgot to update this. Closes rust-lang#133206

Add std::thread::add_spawn_hook.

7ac4c04

Use add_spawn_hook for libtest's output capturing.

ef9055f

Update thread spawn hooks.

947354f

1. Make the effect thread local. 2. Don't return a io::Result from hooks.

Add thread Builder::no_hooks().

f2bf9e1

Use Send + Sync for spawn hooks.

5a80b48

Add tracking issue.

24fec0d

Fix tracking issue.

38b9a44

Address review comments.

b96f023

Co-authored-by: waffle <waffle.lapkin@gmail.com>

Update doc comments for spawn hook.

691796b

Rollup merge of rust-lang#125405 - m-ou-se:thread-add-spawn-hook, r=W…

6c127f3

…affleLapkin Add std::thread::add_spawn_hook. Implementation of rust-lang/rfcs#3642

Rollup merge of rust-lang#133175 - MarcoIeni:dist-i686-msvc-free, r=K…

c74e5a8

…obzol ci: use free runner in dist-i686-msvc try-job: dist-i686-msvc

Rollup merge of rust-lang#133183 - n0toose:improve-remove-dir-docs, r…

d5dca43

…=joboet Mention std::fs::remove_dir_all in std::fs::remove_dir

Rollup merge of rust-lang#133201 - nnethercote:rm-TokenKind-InvalidPr…

841243f

…efix, r=compiler-errors Remove `TokenKind::InvalidPrefix` It's not needed. Best reviewed one commit at a time. r? `@estebank`

Rollup merge of rust-lang#133213 - alexcrichton:fix-tier-listing, r=j…

2467654

…ieyouxu Correct the tier listing of `wasm32-wasip2` This target is tier 2, not tier 3, and I forgot to update this. Closes rust-lang#133206

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 20, 2024

bors merged commit 875df37 into rust-lang:master Nov 20, 2024
7 checks passed

rustbot added this to the 1.84.0 milestone Nov 20, 2024

bors mentioned this pull request Nov 20, 2024

Use download-rustc=false global default, if-unchanged for tools and library profiles, and make rust.debug-assertions=true inhibit downloading CI rustc #133068

Open

bors mentioned this pull request Nov 20, 2024

std: lazily allocate the main thread handle #132654

Open

rustbot added the perf-regression Performance regression. label Nov 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 8 pull requests #133219

Rollup of 8 pull requests #133219

matthiaskrgr commented Nov 19, 2024

matthiaskrgr commented Nov 19, 2024

bors commented Nov 19, 2024

bors commented Nov 19, 2024

bors commented Nov 20, 2024

rust-timer commented Nov 20, 2024

rust-timer commented Nov 20, 2024

lqd commented Nov 20, 2024

Rollup of 8 pull requests #133219

Rollup of 8 pull requests #133219

Conversation

matthiaskrgr commented Nov 19, 2024

matthiaskrgr commented Nov 19, 2024

bors commented Nov 19, 2024

bors commented Nov 19, 2024

bors commented Nov 20, 2024

rust-timer commented Nov 20, 2024

rust-timer commented Nov 20, 2024

Overall result: ❌ regressions - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

lqd commented Nov 20, 2024