-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #133219
Rollup of 8 pull requests #133219
Conversation
Add the following methods, that work similarly to VecDeque::as_slices: - alloc::collections::vec_deque::Iter::as_slices - alloc::collections::vec_deque::IterMut::into_slices - alloc::collections::vec_deque::IterMut::as_slices - alloc::collections::vec_deque::IterMut::as_mut_slices Obtaining slices from a VecDeque iterator was not previously possible.
- Rename it as `invalid_ident_or_prefix`, which matches the possible outputs (`InvalidIdent` or `InvalidPrefix`). - Use the local wrapper for `is_xid_continue`, for consistency. - Make it clear what `\u{200d}` means.
- Improve wording. - Use backticks consistently for examples.
It was added in rust-lang#123752 to handle some cases involving emoji, but it isn't necessary because it's always treated the same as `TokenKind::InvalidIdent`. This commit removes it, which makes things a little simpler.
This target is tier 2, not tier 3, and I forgot to update this. Closes rust-lang#133206
1. Make the effect thread local. 2. Don't return a io::Result from hooks.
Co-authored-by: waffle <waffle.lapkin@gmail.com>
… r=Amanieu Add vec_deque::Iter::as_slices and friends Add the following methods, that work similarly to VecDeque::as_slices: - alloc::collections::vec_deque::Iter::as_slices - alloc::collections::vec_deque::IterMut::into_slices - alloc::collections::vec_deque::IterMut::as_slices - alloc::collections::vec_deque::IterMut::as_mut_slices Obtaining slices from a VecDeque iterator was not previously possible.
…affleLapkin Add std::thread::add_spawn_hook. Implementation of rust-lang/rfcs#3642
…obzol ci: use free runner in dist-i686-msvc try-job: dist-i686-msvc
…=joboet Mention std::fs::remove_dir_all in std::fs::remove_dir
…chenkov Add `visit` methods to ast nodes that already have `walk`s on ast visitors Some `walk` functions are called directly, because there were no correspondent visit functions. related to rust-lang#128974 & rust-lang#127615 r? `@petrochenkov`
…efix, r=compiler-errors Remove `TokenKind::InvalidPrefix` It's not needed. Best reviewed one commit at a time. r? `@estebank`
…jorn3 Default-enable `llvm_tools_enabled` when no `config.toml` is present Fixes rust-lang#133195. cc `@wesleywiser` could you double check if with this patch and no `config.toml` that you can run `./x test tests/ui --stage 1`? `llvm-objcopy` is usually required by cg_ssa on macOS to workaround bad `strip`s. cc `@bjorn3` I hope this doesn't break cg_clif... r? bootstrap
…ieyouxu Correct the tier listing of `wasm32-wasip2` This target is tier 2, not tier 3, and I forgot to update this. Closes rust-lang#133206
@bors r+ rollup=never p=8 |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR:
previous master: ee612c45f0 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Finished benchmarking commit (875df37): comparison URL. Overall result: ❌ regressions - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary 2.5%, secondary -2.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -2.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (primary 0.3%, secondary 0.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 795.801s -> 793.735s (-0.26%) |
There's not much in this PR... This feels like noise, but we'll see on the next merge. |
Given that the regressions were only in helloworld and other similar tiny crates, and it seems like they were reverted: I'm marking this as triaged. @rustbot label: +perf-regression-triaged |
Successful merges:
visit
methods to ast nodes that already havewalk
s on ast visitors #133188 (Addvisit
methods to ast nodes that already havewalk
s on ast visitors)TokenKind::InvalidPrefix
#133201 (RemoveTokenKind::InvalidPrefix
)llvm_tools_enabled
when noconfig.toml
is present #133207 (Default-enablellvm_tools_enabled
when noconfig.toml
is present)wasm32-wasip2
#133213 (Correct the tier listing ofwasm32-wasip2
)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup