Mention std::fs::remove_dir_all in std::fs::remove_dir #133183
Merged
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joboet (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
|
P.S. I also plan to send an improvement for |
This comment has been minimized.
This comment has been minimized.
n0toose
force-pushed
the
improve-remove-dir-docs
branch
from
809c287
to
ba7c16d
Compare
This comment has been minimized.
This comment has been minimized.
n0toose
force-pushed
the
improve-remove-dir-docs
branch
from
ba7c16d
to
7bffa31
Compare
|
third time's the charm? |
|
Thank you, the new documentation is much better! |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 19, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#123947 (Add vec_deque::Iter::as_slices and friends) - rust-lang#125405 (Add std::thread::add_spawn_hook.) - rust-lang#133175 (ci: use free runner in dist-i686-msvc) - rust-lang#133183 (Mention std::fs::remove_dir_all in std::fs::remove_dir) - rust-lang#133188 (Add `visit` methods to ast nodes that already have `walk`s on ast visitors) - rust-lang#133201 (Remove `TokenKind::InvalidPrefix`) - rust-lang#133207 (Default-enable `llvm_tools_enabled` when no `config.toml` is present) - rust-lang#133213 (Correct the tier listing of `wasm32-wasip2`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 20, 2024
Rollup merge of rust-lang#133183 - n0toose:improve-remove-dir-docs, r=joboet Mention std::fs::remove_dir_all in std::fs::remove_dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.