Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fuchsia CI script for package serving #132163

Merged
merged 2 commits into from
Oct 26, 2024
Merged

Conversation

claywilkinson
Copy link
Contributor

This updates the "start" and "stop" methods
of the test runner to use the standalone package
server.

r? @tmandry

This updates the "start" and "stop" methods
of the test runner to use the standalone package
server.
@rustbot
Copy link
Collaborator

rustbot commented Oct 25, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tmandry (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Oct 25, 2024
@claywilkinson claywilkinson marked this pull request as ready for review October 25, 2024 23:32
@tmandry
Copy link
Member

tmandry commented Oct 25, 2024

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 25, 2024

📌 Commit ce4fc99 has been approved by tmandry

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 26, 2024
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#132114 (Use `Enabled{Lang,Lib}Feature`  instead of n-tuples)
 - rust-lang#132163 (Update Fuchsia CI script for package serving)
 - rust-lang#132168 (Effects cleanup)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 42a0e40 into rust-lang:master Oct 26, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Oct 26, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 26, 2024
Rollup merge of rust-lang#132163 - claywilkinson:master, r=tmandry

Update Fuchsia CI script for package serving

This updates the "start" and "stop" methods
of the test runner to use the standalone package
server.

r? `@tmandry`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants