Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effects cleanup #132168

Merged
merged 1 commit into from
Oct 26, 2024
Merged

Effects cleanup #132168

merged 1 commit into from
Oct 26, 2024

Conversation

fee1-dead
Copy link
Member

  • removed extra bits from predicates queries that are no longer needed in the new system
  • removed the need for non_erasable_generics to take in tcx and DefId, removed unused arguments in callers

r? compiler-errors

- removed extra bits from predicates queries that are no longer needed in the new system
- removed the need for `non_erasable_generics` to take in tcx and DefId, removed unused arguments in callers
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 26, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 26, 2024

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

HIR ty lowering was modified

cc @fmease

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@compiler-errors
Copy link
Member

very good

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 26, 2024

📌 Commit f6fea83 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2024
@fee1-dead fee1-dead added F-effects `#![feature(effects)]` PG-const-traits Project group: Const traits labels Oct 26, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 26, 2024
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#132114 (Use `Enabled{Lang,Lib}Feature`  instead of n-tuples)
 - rust-lang#132163 (Update Fuchsia CI script for package serving)
 - rust-lang#132168 (Effects cleanup)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 56463df into rust-lang:master Oct 26, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 26, 2024
Rollup merge of rust-lang#132168 - fee1-dead-contrib:fxclean, r=compiler-errors

Effects cleanup

- removed extra bits from predicates queries that are no longer needed in the new system
- removed the need for `non_erasable_generics` to take in tcx and DefId, removed unused arguments in callers

r? compiler-errors
@rustbot rustbot added this to the 1.84.0 milestone Oct 26, 2024
@fee1-dead fee1-dead deleted the fxclean branch October 26, 2024 12:10
bjorn3 pushed a commit to bjorn3/rust that referenced this pull request Nov 2, 2024
…ler-errors

Effects cleanup

- removed extra bits from predicates queries that are no longer needed in the new system
- removed the need for `non_erasable_generics` to take in tcx and DefId, removed unused arguments in callers

r? compiler-errors
flip1995 pushed a commit to flip1995/rust that referenced this pull request Nov 7, 2024
…ler-errors

Effects cleanup

- removed extra bits from predicates queries that are no longer needed in the new system
- removed the need for `non_erasable_generics` to take in tcx and DefId, removed unused arguments in callers

r? compiler-errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-effects `#![feature(effects)]` PG-const-traits Project group: Const traits S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants