Downgrade untranslatable_diagnostic and diagnostic_outside_of_impl to allow
#132182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
2 tasks
jieyouxu
added
WG-diagnostics
compiler-errors
requested changes
Oct 26, 2024
jieyouxu
added
S-waiting-on-author
…` to `allow` See <rust-lang#132181> for more context.
jieyouxu
force-pushed
the
downgrade-untranslatable
branch
from
ceb4a40 to
5f47391
Compare
jieyouxu
changed the title
untranslatable_diagnostic to allowuntranslatable_diagnostic and diagnostic_outside_of_impl to allow
jieyouxu
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 26, 2024
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#131875 (Add WASM | WASI | Emscripten groups to triagebot.toml) - rust-lang#132019 (Document `PartialEq` impl for `OnceLock`) - rust-lang#132182 (Downgrade `untranslatable_diagnostic` and `diagnostic_outside_of_impl` to `allow`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 26, 2024
Rollup merge of rust-lang#132182 - jieyouxu:downgrade-untranslatable, r=compiler-errors Downgrade `untranslatable_diagnostic` and `diagnostic_outside_of_impl` to `allow` Current implementation of translatable diagnostics infrastructure unfortunately causes some friction for compiler contributors. While we don't have a redesign that causes less friction in place, let's downgrade the internal `untranslatable_diagnostic` and `diagnostic_outside_of_impl` lints so we don't indicate to contributors that they *have* to use the current translation infra. I purposefully left `#[allow(untranslatable_diagnostic)]` and `#[allow(diagnostic_outside_of_impl)]` instances untouched because that seems like unnecessary additional churn. See <rust-lang#132181> for context. r? `@davidtwco` (or wg-diagnostics/compiler)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of translatable diagnostics infrastructure unfortunately causes some friction for compiler contributors. While we don't have a redesign that causes less friction in place, let's downgrade the internal
untranslatable_diagnosticanddiagnostic_outside_of_impllints so we don't indicate to contributors that they have to use the current translation infra.I purposefully left
#[allow(untranslatable_diagnostic)]and#[allow(diagnostic_outside_of_impl)]instances untouched because that seems like unnecessary additional churn.See #132181 for context.
r? @davidtwco (or wg-diagnostics/compiler)