Rollup of 3 pull requests #132190
Merged
Rollup of 3 pull requests #132190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` to `allow` See <rust-lang#132181> for more context.
…iage, r=Mark-Simulacrum Add WASM | WASI | Emscripten groups to triagebot.toml Tracking issue: rust-lang/compiler-team#799 ~~This is blocked on amending the notification group section so that the instructions links point somewhere: rust-lang/rustc-dev-guide#2100
…ck, r=Mark-Simulacrum Document `PartialEq` impl for `OnceLock` Adds documentation to `std::sync::OnceLock`'s `PartialEq` implementation: specifies publicly that `OnceLock`s are compared based on their contents, and nothing else. Created in response to, but not directly related to, rust-lang#131959. ## ne This doesn't create and document `PartialEq::ne`. There's precedent for this in [`RefCell`](https://doc.rust-lang.org/std/cell/struct.RefCell.html#impl-PartialEq-for-RefCell%3CT%3E).
… r=compiler-errors Downgrade `untranslatable_diagnostic` and `diagnostic_outside_of_impl` to `allow` Current implementation of translatable diagnostics infrastructure unfortunately causes some friction for compiler contributors. While we don't have a redesign that causes less friction in place, let's downgrade the internal `untranslatable_diagnostic` and `diagnostic_outside_of_impl` lints so we don't indicate to contributors that they *have* to use the current translation infra. I purposefully left `#[allow(untranslatable_diagnostic)]` and `#[allow(diagnostic_outside_of_impl)]` instances untouched because that seems like unnecessary additional churn. See <rust-lang#132181> for context. r? `@davidtwco` (or wg-diagnostics/compiler)
rustbot
added
A-meta
|
@bors r+ rollup=never p=3 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 4d88de2acd In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (9b18a12): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 783.187s -> 784.3s (0.14%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
PartialEqimpl forOnceLock#132019 (DocumentPartialEqimpl forOnceLock)untranslatable_diagnosticanddiagnostic_outside_of_impltoallow#132182 (Downgradeuntranslatable_diagnosticanddiagnostic_outside_of_impltoallow)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup