Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lp64e RISC-V ABI #132354

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Add lp64e RISC-V ABI #132354

merged 3 commits into from
Oct 31, 2024

Conversation

koute
Copy link
Member

@koute koute commented Oct 30, 2024

This PR adds support for the lp64e RISC-V ABI, which is the 64-bit equivalent of the ilp32e ABI that is already supported.

For reference, this ABI was originally added to LLVM in this PR.

@rustbot
Copy link
Collaborator

rustbot commented Oct 30, 2024

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 30, 2024
@jieyouxu jieyouxu added O-riscv Target: RISC-V architecture A-ABI Area: Concerning the application binary interface (ABI) labels Oct 30, 2024
@beetrees
Copy link
Contributor

Could you also add "lp64e" to the assert_matches! here? Otherwise builtin targets won't be able to use the ABI.

Adding support for lp64e was previously mentioned in #131807 (comment). Therefore:

r? @workingjubilee
cc @topperc

@workingjubilee
Copy link
Member

@koute please add a comment that the LP64E ABI is unstable to all places that reference it.

@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2024

These commits modify compiler targets.
(See the Target Tier Policy.)

@koute
Copy link
Member Author

koute commented Oct 31, 2024

Done. Is this okay now?

@workingjubilee
Copy link
Member

yep.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 31, 2024

📌 Commit c1db011 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2024
@koute
Copy link
Member Author

koute commented Oct 31, 2024

Thank you!

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 31, 2024
Add `lp64e` RISC-V ABI

This PR adds support for the `lp64e` RISC-V ABI, which is the 64-bit equivalent of the `ilp32e` ABI that is already supported.

For reference, this ABI was originally added to LLVM in [this PR](https://reviews.llvm.org/D70401).
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 31, 2024
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#130693 (Add `minicore` test auxiliary and support `//@ add-core-stubs` directive in ui/assembly/codegen tests)
 - rust-lang#132316 (CI: use free runners for 3 fast windows jobs)
 - rust-lang#132354 (Add `lp64e` RISC-V ABI)
 - rust-lang#132395 (coverage: Avoid ICE when `coverage_cx` is unexpectedly unavailable)
 - rust-lang#132396 (CI: use free runners for x86_64-gnu-tools and x86_64-rust-for-linux)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6b96a79 into rust-lang:master Oct 31, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Oct 31, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 31, 2024
Rollup merge of rust-lang#132354 - koute:master, r=workingjubilee

Add `lp64e` RISC-V ABI

This PR adds support for the `lp64e` RISC-V ABI, which is the 64-bit equivalent of the `ilp32e` ABI that is already supported.

For reference, this ABI was originally added to LLVM in [this PR](https://reviews.llvm.org/D70401).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ABI Area: Concerning the application binary interface (ABI) O-riscv Target: RISC-V architecture S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants