Always specify llvm_abiname
for RISC-V targets
#131807
Open
+71
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For RISC-V targets, when
llvm_abiname
is not specified LLVM will infer the ABI from the target features, causing #116344 to occur. This PR adds the correctllvm_abiname
to all RISC-V targets where it is missing (which are all soft-float targets), and adds a test to prevent future RISC-V targets from accidentally omittingllvm_abiname
. The only affect of this PR is that-Ctarget-feature=+f
(or similar) will no longer affect the ABI on the modified targets.r? @RalfJung