-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 4 pull requests #132595
Closed
Closed
Rollup of 4 pull requests #132595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No idea how this slipped past me
By removing interior mutability from it.
Cleanup TypeRef lowering
fix: Fix the server not honoring diagnostic refresh support
Do not render meta info when hovering usages
feat: Add assist to generate a type alias for a function
fix: auto-complete import for aliased function and module
…p-document docs: create setup documentation
I don't like the party of `bool`s that is becoming, but two isn't worth a refactoring yet IMO.
fix: Only parse `safe` as contextual kw in extern blocks
This requires some serious code juggling.
Publish test-fixture => ra_ap_test_fixture
Move `child_by_source` from `hir-def` to `hir`
…erctx Avoid interior mutability in `TyLoweringContext`
Parse patterns with leading pipe properly in all places
…r-msg-improvement Improve error message for too new proc-macro server
feat: Show `static` values on hover
Allow interpreting consts and statics with interpret function command
…casing minor: Fix feature name casing
…, r=dtolnay Stabilise `const_char_encode_utf16`. Closes: rust-lang#130660 This PR stabilises the `const_char_encode_utf16` feature gate (i.e. support for `char::encode_utf16` in constant expressions). ~~Note that the linked tracking issue is as of this writing currently awaiting FCP until 2024-11-02.~~
Fix compiler panic with a large number of threads Hi, This PR is an attempt to fix the problem described here rust-lang#117638 using the solution suggested in this comment rust-lang#117638 (comment) Best regards, Michal
No need to instantiate binder in `confirm_async_closure_candidate` Removes a FIXME that is redundant. No longer needed since rust-lang#122267.
Subtree update of `rust-analyzer` r? `@ghost`
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
rollup
A PR which is a rollup
labels
Nov 4, 2024
@bors r+ rollup=never p=4 |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 4, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 4, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#132153 (Stabilise `const_char_encode_utf16`.) - rust-lang#132355 (Fix compiler panic with a large number of threads) - rust-lang#132486 (No need to instantiate binder in `confirm_async_closure_candidate`) - rust-lang#132594 (Subtree update of `rust-analyzer`) r? `@ghost` `@rustbot` modify labels: rollup
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI-spurious-fail-msvc
CI spurious failure: target env msvc
rollup
A PR which is a rollup
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
const_char_encode_utf16
. #132153 (Stabiliseconst_char_encode_utf16
.)confirm_async_closure_candidate
#132486 (No need to instantiate binder inconfirm_async_closure_candidate
)rust-analyzer
#132594 (Subtree update ofrust-analyzer
)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup