Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libstd: Implement StrBuf, a new string buffer type like Vec, and #13269

Closed
wants to merge 1 commit into from

Conversation

pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Apr 2, 2014

port all code over to use it.

r? @alexcrichton

@alexcrichton
Copy link
Member

This looks great, nice work!

In general I would like to see lots more documentation on StrBuf, but that can come in a later PR. This should preserve the documentation that exists today, however.

@alexcrichton
Copy link
Member

I wold also be very tempted to put StrBuf in the prelude.

@sfackler
Copy link
Member

sfackler commented Apr 3, 2014

It might be a good idea to rename the Str trait to String and StrBuf to Str in line with Vector and Vec. Depending on how the ~[T]/Vec<T> discussion turns out, it may be common to use StrBufs instead of ~strs in which case the Str name would work better. I don't think that has to be done in this PR though.

@liigo
Copy link
Contributor

liigo commented Apr 4, 2014

+1 for rename
2014年4月3日 上午11:08于 "Steven Fackler" notifications@github.com写道:

It might be a good idea to rename the Str trait to String and StrBuf to
Str in line with Vector and Vec. Depending on how the ~[T]/Vecdiscussion turns out, it may be common to use
StrBufs instead of ~strs in which case the Str name would work better. I
don't think that has to be done in this PR though.


Reply to this email directly or view it on GitHubhttps://github.com//pull/13269#issuecomment-39408297
.

@pcwalton
Copy link
Contributor Author

pcwalton commented Apr 4, 2014

re=r? @alexcrichton

@alexcrichton
Copy link
Member

One small comment, otherwise r=me

@huonw
Copy link
Member

huonw commented Apr 10, 2014

Rebased in #13440.

@huonw huonw closed this Apr 10, 2014
bors added a commit that referenced this pull request Apr 11, 2014
libstd: Implement `StrBuf`, a new string buffer type like `Vec`, and port all code over to use it.

Rebased & tests-fixed version of #13269
djrenren pushed a commit to djrenren/libtest that referenced this pull request Jan 22, 2019
libstd: Implement `StrBuf`, a new string buffer type like `Vec`, and port all code over to use it.

Rebased & tests-fixed version of rust-lang/rust#13269
matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this pull request Oct 11, 2022
Properly set the enum variant body type from the repr attribute

Follow up for rust-lang/rust-analyzer#12966, fixes some type inference problems
flip1995 pushed a commit to flip1995/rust that referenced this pull request Oct 18, 2024
…Alexendoo

Rewrite lints page

This PR has multiple goals:

* Make lints page to work without needing a web server by removing the json file.
* Prepare the field to also make the page work with JS (not done in this PR but should be straightforward).
* Remove angular dependency.

r? `@Alexendoo`

changelog: make lint page work without web server
flip1995 pushed a commit to flip1995/rust that referenced this pull request Oct 18, 2024
Documentation fixes

- In [the page describing the lints](https://rust-lang.github.io/rust-clippy/master/index.html), the View Source links are incorrect. This PR removes the extra segment causing them to fail.
  - Example before: https://github.com/rust-lang/rust-clippy/blob/master/clippy_lints/clippy_lints/src/absolute_paths.rs#L13
  - Example after: https://github.com/rust-lang/rust-clippy/blob/master/clippy_lints/src/absolute_paths.rs#L13
  - I think this was introduced in rust-lang#13269.
  - I've only checked a few of the lints with the new template, but from what I can tell the metadata is generated in the same way for all of them. The `id_location` contains the full path of the lint declaration in the repository, which is why `clippy_lints` was repeated in the URL.
- Separately, fixing a typo in the explanation of `unnecessary_get_then_check`.

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants