Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the missing quotation mark in comment #133171

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

binchengqu
Copy link
Contributor

No description provided.

Signed-off-by: binchengqu <bincheng@before.tech>
@rustbot
Copy link
Collaborator

rustbot commented Nov 18, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cjgillot (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 18, 2024
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 18, 2024

📌 Commit a307c54 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2024
@jieyouxu jieyouxu assigned jieyouxu and unassigned cjgillot Nov 18, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 18, 2024
…llaumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#133156 (typo in config.example.toml)
 - rust-lang#133157 (stability: remove skip_stability_check_due_to_privacy)
 - rust-lang#133163 (remove pointless cold_path impl in interpreter)
 - rust-lang#133169 (Update autolabels for T-compiler and T-bootstrap)
 - rust-lang#133171 (Add the missing quotation mark in comment)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 62d0235 into rust-lang:master Nov 18, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 18, 2024
Rollup merge of rust-lang#133171 - binchengqu:master, r=jieyouxu

Add the missing quotation mark in comment
@rustbot rustbot added this to the 1.84.0 milestone Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants