Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #133179

Merged
merged 11 commits into from
Nov 18, 2024
Merged

Rollup of 5 pull requests #133179

merged 11 commits into from
Nov 18, 2024

Conversation

GuillaumeGomez
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

tshepang and others added 11 commits November 18, 2024 07:45
Signed-off-by: binchengqu <bincheng@before.tech>
…to_privacy, r=compiler-errors

stability: remove skip_stability_check_due_to_privacy

This was added in rust-lang#38689 to deal with rust-lang#38412. However, even after removing the check, the relevant tests still pass. Let's see if CI finds any other tests that rely on this. If not, it seems like logic elsewhere in the compiler changed so this is not required any more.
remove pointless cold_path impl in interpreter

This has a fallback impl so the interpreter impl is not needed.

r? ``@saethlin``
…r=WaffleLapkin

Update autolabels for T-compiler and T-bootstrap

- Tag more test suite changes with `T-compiler`.
- Tag `src/build_helper` with `T-bootstrap`.
Add the missing quotation mark in comment
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Nov 18, 2024
@GuillaumeGomez
Copy link
Member Author

@bors r+ p=5 rollup=never

@bors
Copy link
Contributor

bors commented Nov 18, 2024

📌 Commit 62d0235 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2024
@bors
Copy link
Contributor

bors commented Nov 18, 2024

⌛ Testing commit 62d0235 with merge 03ee484...

@bors
Copy link
Contributor

bors commented Nov 18, 2024

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 03ee484 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 18, 2024
@bors bors merged commit 03ee484 into rust-lang:master Nov 18, 2024
7 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 18, 2024
@GuillaumeGomez GuillaumeGomez deleted the rollup-ro5rtts branch November 18, 2024 21:06
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#133156 typo in config.example.toml ded33a4d42527c8d92a78cd6d29c8263b7cdfc6f (link)
#133157 stability: remove skip_stability_check_due_to_privacy 4cea046bdc71e84b24e0066dd7a993e4ce036cef (link)
#133163 remove pointless cold_path impl in interpreter 119ca5e321f98b575626bc13c17379d771945172 (link)
#133169 Update autolabels for T-compiler and T-bootstrap 17d77df3c295646eafd0c2a4963ecb5e357cd717 (link)
#133171 Add the missing quotation mark in comment 8ded3a3e156d9d031fc4c5f1631df59a1d5f72c3 (link)

previous master: c602e9aeaa

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (03ee484): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.1% [-0.2%, -0.1%] 3
Improvements ✅
(secondary)
-0.3% [-0.4%, -0.2%] 2
All ❌✅ (primary) -0.1% [-0.2%, -0.1%] 3

Max RSS (memory usage)

Results (primary 2.2%, secondary -4.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.2% [2.2%, 2.2%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.1% [-4.1%, -4.1%] 1
All ❌✅ (primary) 2.2% [2.2%, 2.2%] 1

Cycles

Results (secondary 4.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.0% [3.7%, 4.2%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 790.89s -> 789.97s (-0.12%)
Artifact size: 335.05 MiB -> 334.45 MiB (-0.18%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants