Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: split x86_64-msvc job #133632

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MarcoIeni
Copy link
Member

@MarcoIeni MarcoIeni commented Nov 29, 2024

r? @ghost

Split the x86_64-msvc job in two to move it to free runners and reduce the use of large runners in CI.

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 29, 2024
@MarcoIeni MarcoIeni changed the title CI: split x86_64-mingw job CI: split x86_64-msvc job Nov 29, 2024
@MarcoIeni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2024
@bors
Copy link
Contributor

bors commented Nov 29, 2024

⌛ Trying commit 02bf397 with merge 42d03ef...

@MarcoIeni
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Nov 29, 2024

⌛ Trying commit f0d9ae4 with merge 09fe17c...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2024
@bors
Copy link
Contributor

bors commented Nov 29, 2024

☀️ Try build successful - checks-actions
Build commit: 09fe17c (09fe17c13367761bb5cb434f5c396395a60583d3)

@MarcoIeni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 2, 2024
CI: split x86_64-msvc job

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@bors
Copy link
Contributor

bors commented Dec 2, 2024

⌛ Trying commit 70ab84d with merge e716b8a...

@bors bors mentioned this pull request Dec 2, 2024
@bors
Copy link
Contributor

bors commented Dec 2, 2024

☀️ Try build successful - checks-actions
Build commit: e716b8a (e716b8a323240c5238cdf21b197bb0629aa79eed)

@MarcoIeni MarcoIeni marked this pull request as ready for review December 2, 2024 14:49
@MarcoIeni
Copy link
Member Author

looks good
image

@MarcoIeni
Copy link
Member Author

r? @Kobzol

@Kobzol
Copy link
Contributor

Kobzol commented Dec 3, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Dec 3, 2024

📌 Commit 70ab84d has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 3, 2024
fmease added a commit to fmease/rust that referenced this pull request Dec 4, 2024
CI: split x86_64-msvc job

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-mingw-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[JIT] std_example (skipped)
##[group][AOT] std_example
[AOT] std_example

thread 'main' has overflowed its stack
error: Failed to assemble `.globl __inline_asm_std_example__f02ae9a81b51dec0_cgu__1_n0
       __inline_asm_std_example__f02ae9a81b51dec0_cgu__1_n0:
       .intel_syntax noprefix
           push rbp
           mov rbp,rsp
           push rbx
           mov rbx,rdi
           movups xmm0, [rbx+0x0]
           movups xmm1, [rbx+0x10]
           mov rax, [rbx+0x20]
           mov rdx, [rbx+0x28]
       pcmpestri xmm0, xmm1, 12
           mov [rbx+0x0], rcx
           pop rbx
           pop rbp
       .att_syntax
       
       
       
       .globl __inline_asm_std_example__f02ae9a81b51dec0_cgu__1_n1
       __inline_asm_std_example__f02ae9a81b51dec0_cgu__1_n1:
       .intel_syntax noprefix
           push rbp
           mov rbp,rsp
           push rbx
           mov rbx,rdi
           mov rax, [rbx+0x0]
           mov rdx, [rbx+0x8]
       crc32 eax, dl
           mov [rbx+0x0], rax
           pop rbx
           pop rbp
       .att_syntax
       
       
       
       .globl __inline_asm_std_example__f02ae9a81b51dec0_cgu__1_n2
       __inline_asm_std_example__f02ae9a81b51dec0_cgu__1_n2:
       .intel_syntax noprefix
           push rbp
           mov rbp,rsp
           push rbx
           mov rbx,rdi
           mov rax, [rbx+0x0]
           mov rdx, [rbx+0x8]
       crc32 eax, dx
           mov [rbx+0x0], rax
           pop rbx
           pop rbp
       .att_syntax
       
       
       
       .globl __inline_asm_std_example__f02ae9a81b51dec0_cgu__1_n3
       __inline_asm_std_example__f02ae9a81b51dec0_cgu__1_n3:
       .intel_syntax noprefix
           push rbp
           mov rbp,rsp
           push rbx
           mov rbx,rdi
           mov rax, [rbx+0x0]
           mov rdx, [rbx+0x8]
       crc32 eax, edx
           mov [rbx+0x0], rax
           pop rbx
           pop rbp
       .att_syntax
       
       
       
       .globl __inline_asm_std_example__f02ae9a81b51dec0_cgu__1_n4
       __inline_asm_std_example__f02ae9a81b51dec0_cgu__1_n4:
       .intel_syntax noprefix
           push rbp
           mov rbp,rsp
           push rbx
           mov rbx,rdi
           mov rax, [rbx+0x0]
           mov rdx, [rbx+0x8]
       crc32 rax, rdx
           mov [rbx+0x0], rax
           pop rbx
           pop rbp
       .att_syntax
       
       
       `
       `

error: aborting due to 1 previous error

"D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage1-tools\\cg_clif\\dist\\rustc-clif.exe" "-Csymbol-mangling-version=v0" "-Zunstable-options" "--check-cfg=cfg(bootstrap)" "--check-cfg=cfg(llvm_enzyme)" "-Zmacro-backtrace" "-Csplit-debuginfo=packed" "-L" "crate=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage1-tools\\cg_clif\\build\\example" "--out-dir" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage1-tools\\cg_clif\\build\\example" "-Cdebuginfo=2" "--target" "x86_64-pc-windows-gnu" "-Cpanic=abort" "--check-cfg=cfg(jit)" "example/std_example.rs" exited with status ExitStatus(ExitStatus(1))
error: process didn't exit successfully: `D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage1-codegen\x86_64-pc-windows-gnu\release\y.exe test --download-dir 'D:\a\rust\rust\build\cg_clif_download' --out-dir 'D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage1-tools\cg_clif' --no-unstable-features --use-backend cranelift --sysroot llvm --skip-test testsuite.extended_sysroot` (exit code: 1)
Command has failed. Rerun with -v to see more details.
make: *** [Makefile:122: ci-mingw-bootstrap] Error 1
  local time: Sun, Dec  8, 2024  7:46:22 AM
  network time: Sun, 08 Dec 2024 07:46:23 GMT
##[error]Process completed with exit code 2.

@bors
Copy link
Contributor

bors commented Dec 8, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 8, 2024
@MarcoIeni
Copy link
Member Author

wow, I never saw that error 😅

@Kobzol
Copy link
Contributor

Kobzol commented Dec 8, 2024

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 8, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 8, 2024
CI: split x86_64-msvc job

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@bors
Copy link
Contributor

bors commented Dec 8, 2024

⌛ Testing commit 70ab84d with merge fe66833...

@rust-log-analyzer
Copy link
Collaborator

The job i686-msvc failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] rustc_driver test:false 8.138
   Compiling rustc-main v0.0.0 (C:\a\rust\rust\compiler\rustc)
error: linking with `link.exe` failed: exit code: 1104
  |
  = note: "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\bin\\HostX64\\x86\\link.exe" "/NOLOGO" "/LARGEADDRESSAWARE" "/SAFESEH" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\symbols.o" "C:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0-rustc\\i686-pc-windows-msvc\\release\\deps\\rustc_main-550a5a7f15f0365e.rustc_main.1ad2147059054d8e-cgu.0.rcgu.o" "C:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0-rustc\\i686-pc-windows-msvc\\release\\deps\\rustc_driver-3f66a54a95a60d67.dll.lib" "C:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0-sysroot\\lib\\rustlib\\i686-pc-windows-msvc\\lib\\libcompiler_builtins-3b9620d6ad737c73.rlib" "psapi.lib" "shell32.lib" "ole32.lib" "uuid.lib" "advapi32.lib" "ws2_32.lib" "ntdll.lib" "kernel32.lib" "advapi32.lib" "ole32.lib" "oleaut32.lib" "advapi32.lib" "cfgmgr32.lib" "gdi32.lib" "kernel32.lib" "msimg32.lib" "opengl32.lib" "user32.lib" "winspool.lib" "bcrypt.lib" "advapi32.lib" "legacy_stdio_definitions.lib" "kernel32.lib" "kernel32.lib" "advapi32.lib" "ntdll.lib" "userenv.lib" "ws2_32.lib" "dbghelp.lib" "/defaultlib:libcmt" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\advapi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\api-ms-win-core-errorhandling-l1-1-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\api-ms-win-core-file-fromapp-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\api-ms-win-core-handle-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\api-ms-win-core-ioring-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\api-ms-win-core-memory-l1-1-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\api-ms-win-core-memory-l1-1-4.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\api-ms-win-core-memory-l1-1-5.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\api-ms-win-core-memory-l1-1-6.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\api-ms-win-core-memory-l1-1-7.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\api-ms-win-core-memory-l1-1-8.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\api-ms-win-core-synch-l1-2-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\api-ms-win-core-sysinfo-l1-2-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\api-ms-win-core-sysinfo-l1-2-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\api-ms-win-core-sysinfo-l1-2-4.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\api-ms-win-core-sysinfo-l1-2-6.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\api-ms-win-core-util-l1-1-1.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\api-ms-win-core-winrt-error-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\api-ms-win-core-winrt-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\api-ms-win-core-wow64-l1-1-1.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\api-ms-win-security-base-l1-2-2.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\avrt.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\bcp47mrm.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\bcryptprimitives.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\clfsw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\dbghelp.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\elscore.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\gdi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\icu.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\imagehlp.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\kernel32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\ktmw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\netapi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\normaliz.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\ntdll.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\ntdllk.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\ole32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\oleacc.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\oleaut32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\propsys.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\psapi.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\rtworkq.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\txfw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\user32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\usp10.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\version.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcdqbNhM\\wofutil.dll_imports_indirect.lib" "/NXCOMPAT" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\atlmfc\\lib\\x86" "/LIBPATH:C:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0-rustc\\i686-pc-windows-msvc\\release\\build\\stacker-5765afe0e5f91485\\out" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\atlmfc\\lib\\x86" "/LIBPATH:C:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0-rustc\\i686-pc-windows-msvc\\release\\build\\psm-899807a07c378e01\\out" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\atlmfc\\lib\\x86" "/LIBPATH:C:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0-rustc\\i686-pc-windows-msvc\\release\\build\\blake3-de3951e52649ddc3\\out" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\atlmfc\\lib\\x86" "/LIBPATH:C:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0-rustc\\i686-pc-windows-msvc\\release\\build\\rustc_llvm-f64c6beb7dc28be7\\out" "/LIBPATH:C:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\llvm\\lib" "/OUT:C:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0-rustc\\i686-pc-windows-msvc\\release\\deps\\rustc_main-550a5a7f15f0365e.exe" "/OPT:REF,ICF" "/DEBUG" "/PDBALTPATH:%_PDB%" "/MANIFEST:EMBED" "/MANIFESTINPUT:C:\\a\\rust\\rust\\compiler\\rustc\\Windows Manifest.xml" "/WX"
  = note: LINK : fatal error LNK1104: cannot open file 'C:\a\rust\rust\build\i686-pc-windows-msvc\stage0-rustc\i686-pc-windows-msvc\release\deps\rustc_main-550a5a7f15f0365e.exe'␍

[RUSTC-TIMING] rustc_main test:false 0.695
error: could not compile `rustc-main` (bin "rustc-main") due to 1 previous error
Build completed unsuccessfully in 0:02:05
Build completed unsuccessfully in 0:02:05
make: *** [Makefile:111: ci-msvc-ps1] Error 1
  network time: Sun, 08 Dec 2024 13:30:21 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

@bors
Copy link
Contributor

bors commented Dec 8, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 8, 2024
@Kobzol
Copy link
Contributor

Kobzol commented Dec 8, 2024

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 8, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 8, 2024
CI: split x86_64-msvc job

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@bors
Copy link
Contributor

bors commented Dec 8, 2024

⌛ Testing commit 70ab84d with merge 03dea35...

@matthiaskrgr
Copy link
Member

I hope this will not double the number of spurious linker failures we are getting .. 😓

@rust-log-analyzer
Copy link
Collaborator

The job i686-msvc failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] rustc_driver test:false 7.720
   Compiling rustc-main v0.0.0 (C:\a\rust\rust\compiler\rustc)
error: linking with `link.exe` failed: exit code: 1104
  |
  = note: "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\bin\\HostX64\\x86\\link.exe" "/NOLOGO" "/LARGEADDRESSAWARE" "/SAFESEH" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\symbols.o" "C:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0-rustc\\i686-pc-windows-msvc\\release\\deps\\rustc_main-550a5a7f15f0365e.rustc_main.1ad2147059054d8e-cgu.0.rcgu.o" "C:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0-rustc\\i686-pc-windows-msvc\\release\\deps\\rustc_driver-3f66a54a95a60d67.dll.lib" "C:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0-sysroot\\lib\\rustlib\\i686-pc-windows-msvc\\lib\\libcompiler_builtins-3b9620d6ad737c73.rlib" "psapi.lib" "shell32.lib" "ole32.lib" "uuid.lib" "advapi32.lib" "ws2_32.lib" "ntdll.lib" "kernel32.lib" "advapi32.lib" "ole32.lib" "oleaut32.lib" "advapi32.lib" "cfgmgr32.lib" "gdi32.lib" "kernel32.lib" "msimg32.lib" "opengl32.lib" "user32.lib" "winspool.lib" "bcrypt.lib" "advapi32.lib" "legacy_stdio_definitions.lib" "kernel32.lib" "kernel32.lib" "advapi32.lib" "ntdll.lib" "userenv.lib" "ws2_32.lib" "dbghelp.lib" "/defaultlib:libcmt" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\advapi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\api-ms-win-core-errorhandling-l1-1-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\api-ms-win-core-file-fromapp-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\api-ms-win-core-handle-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\api-ms-win-core-ioring-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\api-ms-win-core-memory-l1-1-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\api-ms-win-core-memory-l1-1-4.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\api-ms-win-core-memory-l1-1-5.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\api-ms-win-core-memory-l1-1-6.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\api-ms-win-core-memory-l1-1-7.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\api-ms-win-core-memory-l1-1-8.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\api-ms-win-core-synch-l1-2-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\api-ms-win-core-sysinfo-l1-2-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\api-ms-win-core-sysinfo-l1-2-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\api-ms-win-core-sysinfo-l1-2-4.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\api-ms-win-core-sysinfo-l1-2-6.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\api-ms-win-core-util-l1-1-1.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\api-ms-win-core-winrt-error-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\api-ms-win-core-winrt-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\api-ms-win-core-wow64-l1-1-1.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\api-ms-win-security-base-l1-2-2.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\avrt.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\bcp47mrm.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\bcryptprimitives.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\clfsw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\dbghelp.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\elscore.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\gdi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\icu.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\imagehlp.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\kernel32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\ktmw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\netapi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\normaliz.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\ntdll.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\ntdllk.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\ole32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\oleacc.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\oleaut32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\propsys.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\psapi.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\rtworkq.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\txfw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\user32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\usp10.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\version.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcxq0x7w\\wofutil.dll_imports_indirect.lib" "/NXCOMPAT" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\atlmfc\\lib\\x86" "/LIBPATH:C:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0-rustc\\i686-pc-windows-msvc\\release\\build\\stacker-5765afe0e5f91485\\out" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\atlmfc\\lib\\x86" "/LIBPATH:C:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0-rustc\\i686-pc-windows-msvc\\release\\build\\psm-899807a07c378e01\\out" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\atlmfc\\lib\\x86" "/LIBPATH:C:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0-rustc\\i686-pc-windows-msvc\\release\\build\\blake3-de3951e52649ddc3\\out" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\atlmfc\\lib\\x86" "/LIBPATH:C:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0-rustc\\i686-pc-windows-msvc\\release\\build\\rustc_llvm-f64c6beb7dc28be7\\out" "/LIBPATH:C:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\llvm\\lib" "/OUT:C:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0-rustc\\i686-pc-windows-msvc\\release\\deps\\rustc_main-550a5a7f15f0365e.exe" "/OPT:REF,ICF" "/DEBUG" "/PDBALTPATH:%_PDB%" "/MANIFEST:EMBED" "/MANIFESTINPUT:C:\\a\\rust\\rust\\compiler\\rustc\\Windows Manifest.xml" "/WX"
  = note: LINK : fatal error LNK1104: cannot open file 'C:\a\rust\rust\build\i686-pc-windows-msvc\stage0-rustc\i686-pc-windows-msvc\release\deps\rustc_main-550a5a7f15f0365e.exe'␍

[RUSTC-TIMING] rustc_main test:false 0.689
error: could not compile `rustc-main` (bin "rustc-main") due to 1 previous error
Build completed unsuccessfully in 0:02:06
Build completed unsuccessfully in 0:02:06
make: *** [Makefile:111: ci-msvc-ps1] Error 1
  network time: Sun, 08 Dec 2024 17:50:51 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

@bors
Copy link
Contributor

bors commented Dec 8, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 8, 2024
@MarcoIeni
Copy link
Member Author

I hope this will not double the number of spurious linker failures we are getting .. 😓

True. If msvc has a lot of spurious errors, maybe we shouldn't merge this 🤔

@MarcoIeni
Copy link
Member Author

MarcoIeni commented Dec 9, 2024

Actually, I saw all the workflows of the commits linked to this PR and none of them failed for the x86_64-msvc job.
Anyway, I'm fine holding this PR until we figure out https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/High.20failure.20rate.20on.20.60i686-mingw.60.20recently 👍

@jieyouxu
Copy link
Member

jieyouxu commented Dec 11, 2024

True. If msvc has a lot of spurious errors, maybe we shouldn't merge this 🤔

I'm hoping (but not believing) that maybe somehow switching to a NTFS dev-drive might magically lower the spurious failure rate in #134056. Gonna try to see if that random thing thrown at the wall somehow sticks.

@jieyouxu
Copy link
Member

@bors r- (idk maybe someone sync'd?)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants