Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EXPERIMENTAL] Try to use NTFS dev-drive for Windows CI #134056

Closed
wants to merge 1 commit into from
Closed

[EXPERIMENTAL] Try to use NTFS dev-drive for Windows CI #134056

wants to merge 1 commit into from

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Dec 9, 2024 •
edited
Loading

What if this makes spurious failures less likely? Grasping at straws here.

The dev-drive setup was adapted from #131880, courtesy of @GnomedDev's PR.

r? @ghost

// try-job: dist-x86_64-msvc (msi/wxs installer fails to build)
// try-job: x86_64-msvc-ext1 (fails due to insufficient disk space)
try-job: i686-mingw
try-job: i686-msvc
try-job: x86_64-msvc

@jieyouxu jieyouxu added T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. labels Dec 9, 2024
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 9, 2024
@jieyouxu jieyouxu added A-CI Area: Our Github Actions CI and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 9, 2024
@jieyouxu
Copy link
Member Author

jieyouxu commented Dec 9, 2024

@bors try

@jieyouxu
Copy link
Member Author

jieyouxu commented Dec 9, 2024

I'm dumb and forgot to specify try-job, oops.

@bors
Copy link
Contributor

bors commented Dec 9, 2024

⌛ Trying commit abcb699 with merge ac8ba32...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 9, 2024
@bors
Auto merge of rust-lang#134056 - jieyouxu:exp-windows-dev-drive-ci, r…
ac8ba32 
…=<try>

[EXPERIMENTAL] Try to use NTFS dev-drive for Windows CI

What if this makes spurious failures less likely? Grasping at straws here.

The dev-drive setup was adapted from rust-lang#131880, courtesy of `@GnomedDev's` PR.

r? `@ghost`

try-job: x86_64-msvc
@jieyouxu
Copy link
Member Author

jieyouxu commented Dec 9, 2024

Apparently you just have to be faster than bors picking up the try-job, we're so back

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Dec 9, 2024

💔 Test failed - checks-actions

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 9, 2024
@jieyouxu jieyouxu mentioned this pull request Dec 9, 2024
Closed
@jieyouxu
Copy link
Member Author

jieyouxu commented Dec 9, 2024

mfw

This was referenced Dec 11, 2024
Closed
Closed
@jieyouxu jieyouxu force-pushed the exp-windows-dev-drive-ci branch from abcb699 to dff2489 Compare December 11, 2024 17:27
@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Dec 11, 2024
@jieyouxu
Copy link
Member Author

Here we go again with a temporary test skip
@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 11, 2024
@bors
Auto merge of rust-lang#134056 - jieyouxu:exp-windows-dev-drive-ci, r…
63ddfb6 
…=<try>

[EXPERIMENTAL] Try to use NTFS dev-drive for Windows CI

What if this makes spurious failures less likely? Grasping at straws here.

The dev-drive setup was adapted from rust-lang#131880, courtesy of `@GnomedDev's` PR.

r? `@ghost`

try-job: x86_64-msvc
@bors
Copy link
Contributor

bors commented Dec 11, 2024

⌛ Trying commit dff2489 with merge 63ddfb6...

@mati865
Copy link
Contributor

mati865 commented Dec 11, 2024

You might also want to try a windows-gnu build. I haven't pinpointed what breaks ld.bfd but at least on ReFS dev-drive, I couldn't get it to link Rust without failing with error.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Dec 11, 2024

💔 Test failed - checks-actions

@jieyouxu
Copy link
Member Author

ok i was lazy and didnt test the --skip syntax... what on earth is the syntax

@ChrisDenton
Copy link
Member

It might be that --skip is very sensitive to path separators. Try:

--skip tests\ui\traits\fn-pointer\bare-fn-no-impl-fn-ptr-99875.rs

(I think it should really error if --skip doesn't match a path for whatever reason)

@jieyouxu
Copy link
Member Author

Yeah, I just needed to check the invocation locally, i was lazy lol

@jieyouxu
Copy link
Member Author

jieyouxu commented Dec 12, 2024 •
edited
Loading

You might also want to try a windows-gnu build. I haven't pinpointed what breaks ld.bfd but at least on ReFS dev-drive, I couldn't get it to link Rust without failing with error.

Yeah, I know one of the windows jobs fail w/ ReFS at stage2 rustc from #131880, I'm mostly trying to make anything work at all first. (Which is why I'm not using ReFS atm 😆)

@jieyouxu jieyouxu force-pushed the exp-windows-dev-drive-ci branch from dff2489 to 85895c1 Compare December 12, 2024 05:43
@bors
Copy link
Contributor

bors commented Dec 19, 2024

☀️ Try build successful - checks-actions
Build commit: 06bcae0 (06bcae0cd4652216712285362d0d8f5069e4de8e)

@ChrisDenton
Copy link
Member

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 19, 2024
@bors
Auto merge of rust-lang#134056 - jieyouxu:exp-windows-dev-drive-ci, r…
851a63a 
…=<try>

[EXPERIMENTAL] Try to use NTFS dev-drive for Windows CI

What if this makes spurious failures less likely? Grasping at straws here.

The dev-drive setup was adapted from rust-lang#131880, courtesy of `@GnomedDev's` PR.

r? `@ghost`

// try-job: dist-x86_64-msvc (msi/wxs installer fails to build)
// try-job: x86_64-msvc-ext1 (fails due to insufficient disk space)
try-job: i686-mingw
try-job: i686-msvc
try-job: x86_64-msvc
@bors
Copy link
Contributor

bors commented Dec 19, 2024

⌛ Trying commit 1eb9122 with merge 851a63a...

@bors
Copy link
Contributor

bors commented Dec 20, 2024

☀️ Try build successful - checks-actions
Build commit: 851a63a (851a63a36d4882813c05a82932a1f6d1fdd3df10)

@jieyouxu
Copy link
Member Author

@bors try

@jieyouxu

This comment was marked as resolved.

Sign in to view
@bors

This comment was marked as resolved.

Sign in to view
@jieyouxu jieyouxu force-pushed the exp-windows-dev-drive-ci branch from 1eb9122 to 6a80e77 Compare December 23, 2024 10:14
@jieyouxu
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 23, 2024
@bors
Auto merge of rust-lang#134056 - jieyouxu:exp-windows-dev-drive-ci, r…
a3318bb 
…=<try>

[EXPERIMENTAL] Try to use NTFS dev-drive for Windows CI

What if this makes spurious failures less likely? Grasping at straws here.

The dev-drive setup was adapted from rust-lang#131880, courtesy of `@GnomedDev's` PR.

r? `@ghost`

// try-job: dist-x86_64-msvc (msi/wxs installer fails to build)
// try-job: x86_64-msvc-ext1 (fails due to insufficient disk space)
try-job: i686-mingw
try-job: i686-msvc
try-job: x86_64-msvc
@bors
Copy link
Contributor

bors commented Dec 23, 2024

⌛ Trying commit 6a80e77 with merge a3318bb...

@bors bors mentioned this pull request Dec 23, 2024
Merged
@bors
Copy link
Contributor

bors commented Dec 23, 2024

☀️ Try build successful - checks-actions
Build commit: a3318bb (a3318bbaeec3000045801f2bc65af8b66ce15fce)

@jieyouxu
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 23, 2024
@bors
Auto merge of rust-lang#134056 - jieyouxu:exp-windows-dev-drive-ci, r…
16f378c 
…=<try>

[EXPERIMENTAL] Try to use NTFS dev-drive for Windows CI

What if this makes spurious failures less likely? Grasping at straws here.

The dev-drive setup was adapted from rust-lang#131880, courtesy of `@GnomedDev's` PR.

r? `@ghost`

// try-job: dist-x86_64-msvc (msi/wxs installer fails to build)
// try-job: x86_64-msvc-ext1 (fails due to insufficient disk space)
try-job: i686-mingw
try-job: i686-msvc
try-job: x86_64-msvc
@bors
Copy link
Contributor

bors commented Dec 23, 2024

⌛ Trying commit 6a80e77 with merge 16f378c...

@bors
Copy link
Contributor

bors commented Dec 23, 2024

☀️ Try build successful - checks-actions
Build commit: 16f378c (16f378c235f1f91969bc2ea6e1dac5754866b00c)

@jieyouxu @GnomedDev
[EXPERIMENTAL] Try to use NTFS dev-drive for Windows CI
c4a9699 
Co-authored-by: GnomedDev <david2005thomas@gmail.com>
@jieyouxu jieyouxu force-pushed the exp-windows-dev-drive-ci branch from 6a80e77 to c4a9699 Compare January 9, 2025 00:31
@jieyouxu
Copy link
Member Author

jieyouxu commented Jan 9, 2025

I cannot get tests\ui\traits\fn-pointer\bare-fn-no-impl-fn-ptr-99875.rs to fail locally on msvc for whatever reason, trying here

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 9, 2025
@bors
Auto merge of rust-lang#134056 - jieyouxu:exp-windows-dev-drive-ci, r…
ba37a58 
…=<try>

[EXPERIMENTAL] Try to use NTFS dev-drive for Windows CI

What if this makes spurious failures less likely? Grasping at straws here.

The dev-drive setup was adapted from rust-lang#131880, courtesy of `@GnomedDev's` PR.

r? `@ghost`

// try-job: dist-x86_64-msvc (msi/wxs installer fails to build)
// try-job: x86_64-msvc-ext1 (fails due to insufficient disk space)
try-job: i686-mingw
try-job: i686-msvc
try-job: x86_64-msvc
@bors
Copy link
Contributor

bors commented Jan 9, 2025

⌛ Trying commit c4a9699 with merge ba37a58...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 9, 2025
@bors
Auto merge of rust-lang#134056 - jieyouxu:exp-windows-dev-drive-ci, r…
0f3f317 
…=<try>

[EXPERIMENTAL] Try to use NTFS dev-drive for Windows CI

What if this makes spurious failures less likely? Grasping at straws here.

The dev-drive setup was adapted from rust-lang#131880, courtesy of `@GnomedDev's` PR.

r? `@ghost`

// try-job: dist-x86_64-msvc (msi/wxs installer fails to build)
// try-job: x86_64-msvc-ext1 (fails due to insufficient disk space)
try-job: i686-mingw
try-job: i686-msvc
try-job: x86_64-msvc
@bors
Copy link
Contributor

bors commented Jan 9, 2025

⌛ Trying commit c4a9699 with merge 0f3f317...

@bors
Copy link
Contributor

bors commented Jan 9, 2025

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 9, 2025
@jieyouxu jieyouxu closed this Jan 20, 2025
@jieyouxu jieyouxu deleted the exp-windows-dev-drive-ci branch January 20, 2025 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-CI Area: Our Github Actions CI S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jieyouxu @bors @rust-log-analyzer @mati865 @ChrisDenton @rustbot