Subtree update of rust-analyzer
#134681
Merged
Subtree update of rust-analyzer
#134681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also a bit of cleanup by storing the capture's span with the open quote included.
internal: Simplify ratoml testdir usage
feat: Report unresolved idents for implicit captures in `format_args!()`
minor: improve name suggestion for destructure_tuple_binding
…string feat: Use string literal contents as a name when extracting into variable
internal: Don't serialize empty fields in completions and resolve payloads
…e-exports Prior to this commit we used to generate import paths, then zipped them with the existing qualifier to check if they agree on the path to import. This is brittle when re-exports come into play causing items to have multiple applicable paths that refer to them. This commit instead rewrites this logic by generating the import path for the qualifier, verifying that the rest of the qualifier resolves and then doing a final lookup on that resolution result for the final segment instead.
fix: Fix path qualified auto-importing completions not working with re-exports
I found it easiest to fix in the quickfix code, and not deeper (e.g. body lowering).
The reason I did this is because I plan to add another field to this struct (indicating whether the item was cfg'ed out), but it seems worthy even separately and removes a bunch of one-letter variable names and tuple-indexing. It is also easy to separate from future changes, so it will be easier to review this way.
fix: Fix a panic with a diagnostics fix when a keyword is used as a field
It didn't print the `@`.
fix: Fix pretty-printing of `@` patterns
Remove salsa from proc-macro server dep tree
Taking a raw ref of a deref is always safe
internal: Cleanup label structure of `CompletionItem`
fix: Do not ask the client to resolve for non existing label details
fix: Consider both completion detail fields in to_proto
Fix AsmOption rule in rust.ungram
fix: Don't trigger paren wrapping typing handler after idents
fix: Fix empty check diagnostics not marking files as changed
fix: Properly check if workspace flychecking is allowed
fix: Delay initial flycheck until after build scripts
fix: Fix flycheck workspace when requested but package was found
minor: Sync from downstream
rustbot
added
the
S-waiting-on-review
|
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
|
@bors r+ =1 subtree sync |
bors
added
S-waiting-on-bors
|
@bors r+ p=1 |
|
💡 This pull request was already approved, no need to approve it again.
|
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (904d8f6): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary 0.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 4.5%, secondary -3.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 763.753s -> 763.12s (-0.08%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ghost