Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libs: add Deref, DerefMut impls for references #18714

Merged
merged 1 commit into from
Nov 7, 2014

Conversation

nikomatsakis
Copy link
Contributor

libs: add Deref, DerefMut impls for references, fixing a bug in compiler in the process that was blocking this.

r? @aturon

@nikomatsakis nikomatsakis force-pushed the issue-18621-deref-for-refs branch 2 times, most recently from 1a4c1dd to 47e1556 Compare November 6, 2014 20:50
@@ -638,7 +638,7 @@ shr_impl!(uint u8 u16 u32 u64 int i8 i16 i32 i64)
* ```
*/
#[lang="index"]
pub trait Index<Index, Sized? Result> {
pub trait Index<Index, Sized? Result> for Sized? {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to drop these changes to avoid some rebasing pain later on.

@nikomatsakis nikomatsakis force-pushed the issue-18621-deref-for-refs branch from 47e1556 to 6b0ab35 Compare November 6, 2014 22:34
@nikomatsakis nikomatsakis force-pushed the issue-18621-deref-for-refs branch from 6b0ab35 to f2aaed8 Compare November 7, 2014 02:51
bors added a commit that referenced this pull request Nov 7, 2014
…r=aturon

libs: add Deref, DerefMut impls for references, fixing a bug in compiler in the process that was blocking this.

r? @aturon
@bors bors closed this Nov 7, 2014
@bors bors merged commit f2aaed8 into rust-lang:master Nov 7, 2014
@nikomatsakis nikomatsakis deleted the issue-18621-deref-for-refs branch March 30, 2016 16:14
lnicola pushed a commit to lnicola/rust that referenced this pull request Dec 23, 2024
fix: Do not ask the client to resolve for non existing label details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants