Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libs: add Deref, DerefMut impls for references #18714

Merged
merged 1 commit into from
Nov 7, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/liballoc/arc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ impl<T: Send + Sync + Clone> Arc<T> {
// additional reference of either kind.
if self.inner().strong.load(atomic::SeqCst) != 1 ||
self.inner().weak.load(atomic::SeqCst) != 1 {
*self = Arc::new(self.deref().clone())
*self = Arc::new((**self).clone())
}
// This unsafety is ok because we're guaranteed that the pointer
// returned is the *only* pointer that will ever be returned to T. Our
Expand Down
15 changes: 15 additions & 0 deletions src/libcore/ops.rs
Original file line number Diff line number Diff line change
Expand Up @@ -805,6 +805,16 @@ pub trait Deref<Sized? Result> {
fn deref<'a>(&'a self) -> &'a Result;
}

#[cfg(not(stage0))]
impl<'a, Sized? T> Deref<T> for &'a T {
fn deref(&self) -> &T { *self }
}

#[cfg(not(stage0))]
impl<'a, Sized? T> Deref<T> for &'a mut T {
fn deref(&self) -> &T { *self }
}

/**
*
* The `DerefMut` trait is used to specify the functionality of dereferencing
Expand Down Expand Up @@ -845,6 +855,11 @@ pub trait DerefMut<Sized? Result>: Deref<Result> {
fn deref_mut<'a>(&'a mut self) -> &'a mut Result;
}

#[cfg(not(stage0))]
impl<'a, Sized? T> DerefMut<T> for &'a mut T {
fn deref_mut(&mut self) -> &mut T { *self }
}

/// A version of the call operator that takes an immutable receiver.
#[lang="fn"]
pub trait Fn<Args,Result> {
Expand Down
19 changes: 12 additions & 7 deletions src/librustc/middle/typeck/check/method.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1702,13 +1702,18 @@ impl<'a, 'tcx> LookupContext<'a, 'tcx> {
PreferMutLvalue);
}
ast::ExprUnary(ast::UnDeref, ref base_expr) => {
check::try_overloaded_deref(
self.fcx,
expr.span,
Some(MethodCall::expr(expr.id)),
Some(&**base_expr),
self.fcx.expr_ty(&**base_expr),
PreferMutLvalue);
// if this is an overloaded deref, then re-evaluate with
// a preference for mut
let method_call = MethodCall::expr(expr.id);
if self.fcx.inh.method_map.borrow().contains_key(&method_call) {
check::try_overloaded_deref(
self.fcx,
expr.span,
Some(method_call),
Some(&**base_expr),
self.fcx.expr_ty(&**base_expr),
PreferMutLvalue);
}
}
_ => {}
}
Expand Down
4 changes: 4 additions & 0 deletions src/libstd/collections/hash/table.rs
Original file line number Diff line number Diff line change
Expand Up @@ -166,18 +166,22 @@ impl<K, V> RawBucket<K, V> {
}

// For parameterizing over mutability.

#[cfg(stage0)]
impl<'t, K, V> Deref<RawTable<K, V>> for &'t RawTable<K, V> {
fn deref(&self) -> &RawTable<K, V> {
&**self
}
}

#[cfg(stage0)]
impl<'t, K, V> Deref<RawTable<K, V>> for &'t mut RawTable<K, V> {
fn deref(&self) -> &RawTable<K,V> {
&**self
}
}

#[cfg(stage0)]
impl<'t, K, V> DerefMut<RawTable<K, V>> for &'t mut RawTable<K, V> {
fn deref_mut(&mut self) -> &mut RawTable<K,V> {
&mut **self
Expand Down
21 changes: 21 additions & 0 deletions src/test/run-pass/deref-mut-on-ref.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// Test that `&mut T` implements `DerefMut<T>`

fn inc<T:DerefMut<int>>(mut t: T) {
*t += 1;
}

fn main() {
let mut x: int = 5;
inc(&mut x);
assert_eq!(x, 6);
}
25 changes: 25 additions & 0 deletions src/test/run-pass/deref-on-ref.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// Test that `&T` and `&mut T` implement `Deref<T>`

fn deref<U:Copy,T:Deref<U>>(t: T) -> U {
*t
}

fn main() {
let x: int = 3;
let y = deref(&x);
assert_eq!(y, 3);

let mut x: int = 4;
let y = deref(&mut x);
assert_eq!(y, 4);
}