Made libflate functions return Options instead of outright failing #13389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tobba: Is your |
| let cmp = deflate_bytes(input); | ||
| let out = inflate_bytes(cmp.as_slice()); | ||
| let cmp = match deflate_bytes(input) { Some(data) => data, None => fail!("deflation failed") }; | ||
| let out = match inflate_bytes(cmp.as_slice()) { Some(data) => data, None => fail!("inflation failed") }; |
There was a problem hiding this comment.
These might be better written as
foo().expect("some string");
|
Made those changes and squashed the commits |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 24, 2024
Check that #[deny(allow_attributes)] do not issue spurious messages Add a new test for rust-lang#13380. This bug was caused by a bug in rustc which has been fixed in rust-lang@6ee87ae. Close rust-lang#13380 changelog: [`allow_attributes`]: fix spurious warning messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make the library slightly more pleasant to use, and make the compiler errors related to corrupt rlibs more sensible (i.e not failing on an assert)
In addition, Github seems to think I'm a completely different person