Remove FIXME referring to a closed issue (#3654) #13380
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #3654 had already been fixed and closed, but the FIXME comment has not been removed. This commit removes the FIXME comment.
The years of copyright and the name of the copyright holder were not present in the notice. The Apache license was added to the project in 2012, so 2012 is the starting year. 2014 is the current year. The copyright holder is the Mozilla Foundation (taken from the MIT license).
|
This PR appears to be confusing bors, I'm going to temporarily close to see if it makes bors happier. |
|
I'm a little unsure why, but PR seems to upset bors (sorry!). Would you mind reopening with another PR? This also appears to have picked up a commit from #13391 by accident. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 18, 2022
Honor cfg attributes on params when lowering their patterns Closes rust-lang/rust-analyzer#13375
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 24, 2024
Check that #[deny(allow_attributes)] do not issue spurious messages Add a new test for rust-lang#13380. This bug was caused by a bug in rustc which has been fixed in rust-lang@6ee87ae. Close rust-lang#13380 changelog: [`allow_attributes`]: fix spurious warning messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #3654 had already been fixed and closed, but the FIXME comment has
not been removed. This commit removes the FIXME comment.