Skip to content

Add the name of the copyright holder and year #13391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2014
Merged

Add the name of the copyright holder and year #13391

merged 1 commit into from
May 4, 2014

Conversation

smesseim
Copy link
Contributor

@smesseim smesseim commented Apr 7, 2014

The years of copyright and the name of the copyright holder were not
present in the notice.

The Apache license was added to the project in 2012, so 2012 is the
starting year. The copyright holder is the Mozilla Foundation (taken
from the MIT license).

@thestinger
Copy link
Contributor

I don't think a starting year is either necessary or useful, and 2012 would not be right if it was. The Mozilla Foundation is also only one of many copyright holders - the MIT license file is wrong.

@emberian
Copy link
Member

emberian commented Apr 7, 2014

The copyright belongs to "The Rust Project Developers" according to COPYRIGHT and every single source file.

@smesseim
Copy link
Contributor Author

smesseim commented Apr 8, 2014

I assume the copyright in the MIT license should also be changed to:

Copyright (c) 2006-2009 Graydon Hoare
Copyright (c) 2009-2012 Mozilla Foundation
Copyright (c) 2012-2014 The Rust Project Developers

@smesseim
Copy link
Contributor Author

smesseim commented Apr 8, 2014

cc @graydon

@thestinger
Copy link
Contributor

Since it's all we use in other files, "The Rust Project Developers" is all that's needed in here. The range of dates is meaningless because it has no meaning in copyright law - the published date does, and that's 2014 for the contents of master. That's why the template licenses never ask for a range.

@brson
Copy link
Contributor

brson commented Apr 12, 2014

That LICENSE-MIT was wrong has long bugged me. I also agree "The Rust Project Developers" and 2014 is sufficient.

LICENSE-APACHE does not need to change though. That line is actually part of the appendix, which is a template explaining how to use the license - I don't think it's intended to be changed.

@brson
Copy link
Contributor

brson commented Apr 16, 2014

@inlock sorry for the runaround, but I'd like to remove the copyright lines for Graydon and the Mozilla Foundation from LICENSE-MIT as well.

@alexcrichton
Copy link
Member

Sorry this went under the radar for so long @smesseim! Feel free to comment on a PR when you update it, because sadly we don't get any notifications when it's force-pushed.

Could you squash these commits into just one commit? Thanks again, and sorry for the delay!

The copyright of this project belongs to The Rust Project Developers,
who are mentioned in AUTHORS.txt.
@smesseim
Copy link
Contributor Author

smesseim commented May 3, 2014

The commits are squashed into one commit.

bors added a commit that referenced this pull request May 4, 2014
The years of copyright and the name of the copyright holder were not
present in the notice.

The Apache license was added to the project in 2012, so 2012 is the
starting year. The copyright holder is the Mozilla Foundation (taken
from the MIT license).
@bors bors merged commit 90ba013 into rust-lang:master May 4, 2014
@smesseim smesseim deleted the apache-copyright branch May 5, 2014 00:36
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 18, 2022
Update manual now stable can be installed with rustup

this a new PR for rust-lang#13374 as `bors squash` seemed to have broken `bors`
_______
`rustup` can now install `rust-analyzer` for the stable tool-chain. This commit removes the note that `rustup` can only install for the nightly branch and adjusts the command.

I also added a note on how to find the path to the `rust-analyzer` binary when installed using `rustup`, and suggestions on how to work around it not being placed in `~/.cargo/bin`.

I thought it would be ideal to point everyone to use `rustup run stable rust-analyzer` to start `rust-analyzer`. That would make it trivial to switch to nightly however I could not get this to work in `nvim` therefore I left it as a suggestion at the end.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants