Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIX] keep profile-rt symbol alive #134139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[AIX] keep profile-rt symbol alive #134139

wants to merge 1 commit into from
+2 −0

Conversation

mustartt
Copy link
Contributor

Clang passes -u __llvm_profile_runtime on AIX. https://reviews.llvm.org/D136192
We want to preserve the symbol in the case there are no instrumented object files.

@rustbot
Copy link
Collaborator

rustbot commented Dec 10, 2024

r? @saethlin

rustbot has assigned @saethlin.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 10, 2024
@saethlin
Copy link
Member

It looks like the LLVM diffs you linked are passing a single link arg, does it matter that this is passing two? I think it's just -u __llvm_profile_runtime vs -u__llvm_profile_runtime, is that right? And those are parsed the same?

@mustartt
Copy link
Contributor Author

Thanks for checking. Yes they will be interpreted the same.

@saethlin
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 10, 2024

📌 Commit f4933ff has been approved by saethlin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 10, 2024
jhpratt added a commit to jhpratt/rust that referenced this pull request Dec 11, 2024
@jhpratt
Rollup merge of rust-lang#134139 - mustartt:pgo-linker-flag, r=saethlin
2891a92 
[AIX] keep profile-rt symbol alive

Clang passes `-u __llvm_profile_runtime` on AIX. https://reviews.llvm.org/D136192
We want to preserve the symbol in the case there are no instrumented object files.
@jhpratt jhpratt mentioned this pull request Dec 11, 2024
Open
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 11, 2024
@bors
Auto merge of rust-lang#134164 - jhpratt:rollup-s7z0vcc, r=jhpratt
0c8422c 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#134079 (Add a note saying that `{u8,i8}::from_{be,le,ne}_bytes` is meaningless)
 - rust-lang#134105 (Validate self in host predicates correctly)
 - rust-lang#134136 (Exercise const trait interaction with default fields)
 - rust-lang#134139 ([AIX] keep profile-rt symbol alive)
 - rust-lang#134141 (Remove more traces of anonymous ADTs)
 - rust-lang#134142 (Rudimentary heuristic to insert parentheses when needed for RPIT overcaptures lint)
 - rust-lang#134158 (Rename `projection_def_id` to `item_def_id`)
 - rust-lang#134160 (Add vacation entry for myself in triagebot.toml)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@saethlin saethlin

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mustartt @rustbot @saethlin @bors