Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename projection_def_id to item_def_id #134158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rename projection_def_id to item_def_id #134158

wants to merge 1 commit into from
+9 −9

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Dec 11, 2024 •
edited
Loading

Renames projection_def_id to item_def_id, since item_def_id is what we call the analogous method for AliasTerm/AliasTy PolyExistentialProjection. I keep forgetting that this one is not called item_def_id.

@rustbot
Copy link
Collaborator

rustbot commented Dec 11, 2024

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Dec 11, 2024
@rustbot
Copy link
Collaborator

rustbot commented Dec 11, 2024

HIR ty lowering was modified

cc @fmease

@jackh726
Copy link
Member

Personally, I think something like "alias_def_id" is even better, since "item" could mean the trait item.

But, given that this just aligns the name with elsewhere:
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 11, 2024

📌 Commit ec68498 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 11, 2024
@compiler-errors
Copy link
Member Author

@bors r-

I can further unify the naming

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 11, 2024
@compiler-errors
Copy link
Member Author

Actually I was mistaken, and the function is not defined on AliasTerm/AliasTy, the fn item_def_id I was modeling this off of is defined on PolyExistentialProjection.

Anyways, I cannot be bothered to change this for now so 🤔

@bors r=jackh726

@bors
Copy link
Contributor

bors commented Dec 11, 2024

📌 Commit ec68498 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 11, 2024
jhpratt added a commit to jhpratt/rust that referenced this pull request Dec 11, 2024
@jhpratt
Rollup merge of rust-lang#134158 - compiler-errors:item-def-id, r=jac…
c4e27d6 
…kh726

Rename `projection_def_id` to `item_def_id`

Renames `projection_def_id` to `item_def_id`, since `item_def_id` is what we call the analogous method for ~~`AliasTerm`/`AliasTy`~~ `PolyExistentialProjection`. I keep forgetting that this one is not called `item_def_id`.
@jhpratt jhpratt mentioned this pull request Dec 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @rustbot @jackh726 @bors @cjgillot