Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Free more disk space with free-disk-space script #134151

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

whiteio
Copy link

@whiteio whiteio commented Dec 10, 2024

Attempting to move the free-disk-space github action into the repo as it isn't currently maintained. This involves moving the script within free-disk-space into the repo.

I'm opening this as a draft to verify that the saved space is the same as the original action. Once that is verified, I'll look into integrating these two PRs to improve it:

Changes so far:

  • Took the script from the free-disk-space repo and moved it into src/ci/scripts/
  • Removed unnecessary if statements which were used to check for github action inputs which we don't need to check
  • Swapped to using this script within the rust repo, instead of using the jlumbroso/free-disk-space@54081f138730dfa15788a46383842cd2f914a1be GitHub action

See this issue for more info: rust-lang/infra-team#183

@rustbot
Copy link
Collaborator

rustbot commented Dec 10, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 10, 2024
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer
Copy link
Collaborator

The job mingw-check-tidy failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
  /var/cache/postgresql/dicts/en_us.dict
  /usr/share/postgresql//14/tsearch_data/en_us.affix
  /usr/share/postgresql//14/tsearch_data/en_us.dict
Processing triggers for libc-bin (2.31-0ubuntu9.16) ...
dpkg: no packages found matching aspnetcore-*
dpkg: no packages found matching dotnet-*
dpkg: no packages found matching google-cloud-*
dpkg: no packages found matching gcloud-*
Building dependency tree...
Reading state information...
0 upgraded, 0 newly installed, 0 to remove and 21 not upgraded.

---

COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/

# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
           --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
#    pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---
#13 2.803 Building wheels for collected packages: reuse
#13 2.804   Building wheel for reuse (pyproject.toml): started
#13 3.052   Building wheel for reuse (pyproject.toml): finished with status 'done'
#13 3.053   Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132720 sha256=026f3bb0f1aa8090b861fd0a0939cb1a782396d84c8aab7875096557d637a0f6
#13 3.053   Stored in directory: /tmp/pip-ephem-wheel-cache-13hhq8_h/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#13 3.056 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#13 3.451 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#13 3.451 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#13 3.981 Collecting virtualenv
#13 3.981 Collecting virtualenv
#13 4.017   Downloading virtualenv-20.28.0-py3-none-any.whl (4.3 MB)
#13 4.084      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 4.3/4.3 MB 67.1 MB/s eta 0:00:00
#13 4.145 Collecting filelock<4,>=3.12.2
#13 4.148   Downloading filelock-3.16.1-py3-none-any.whl (16 kB)
#13 4.182 Collecting platformdirs<5,>=3.9.1
#13 4.185   Downloading platformdirs-4.3.6-py3-none-any.whl (18 kB)
#13 4.202 Collecting distlib<1,>=0.3.7
#13 4.213      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 469.0/469.0 KB 79.5 MB/s eta 0:00:00
#13 4.213      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 469.0/469.0 KB 79.5 MB/s eta 0:00:00
#13 4.295 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#13 4.476 Successfully installed distlib-0.3.9 filelock-3.16.1 platformdirs-4.3.6 virtualenv-20.28.0
#13 DONE 4.6s

#14 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#14 DONE 0.0s
---
DirectMap4k:      307136 kB
DirectMap2M:     5984256 kB
DirectMap1G:    12582912 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test            --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
    Finished `dev` profile [unoptimized] target(s) in 0.04s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
downloading https://static.rust-lang.org/dist/2024-11-27/rustfmt-nightly-x86_64-unknown-linux-gnu.tar.xz
---
fmt check
fmt: checked 5703 files
tidy check
tidy: Skipping binary file check, read-only filesystem
##[error]tidy error: /checkout/src/ci/scripts/free-disk-space.sh:126: line longer than 100 chars
##[error]tidy error: /checkout/src/ci/scripts/free-disk-space.sh:127: line longer than 100 chars
##[error]tidy error: /checkout/src/ci/scripts/free-disk-space.sh:128: line longer than 100 chars
##[error]tidy error: /checkout/src/ci/scripts/free-disk-space.sh:129: line longer than 100 chars
##[error]tidy error: /checkout/src/ci/scripts/free-disk-space.sh:130: line longer than 100 chars
##[error]tidy error: /checkout/src/ci/scripts/free-disk-space.sh:131: line longer than 100 chars
##[error]tidy error: /checkout/src/ci/scripts/free-disk-space.sh:132: line longer than 100 chars
##[error]tidy error: /checkout/src/ci/scripts/free-disk-space.sh:133: line longer than 100 chars
##[error]tidy error: /checkout/src/ci/scripts/free-disk-space.sh:134: line longer than 100 chars
##[error]tidy error: /checkout/src/ci/scripts/free-disk-space.sh:135: line longer than 100 chars
##[error]tidy error: /checkout/src/ci/scripts/free-disk-space.sh:137: line longer than 100 chars
##[error]tidy error: /checkout/src/ci/scripts/free-disk-space.sh:149: line longer than 100 chars
##[error]tidy error: /checkout/src/ci/scripts/free-disk-space.sh:151: line longer than 100 chars
removing old virtual environment
creating virtual environment at '/checkout/obj/build/venv' using 'python3.10'
Requirement already satisfied: pip in ./build/venv/lib/python3.10/site-packages (24.3.1)
All checks passed!
checking C++ file formatting
some tidy checks failed
some tidy checks failed
Command has failed. Rerun with -v to see more details.
  local time: Wed Dec 11 01:09:23 UTC 2024
  network time: Wed, 11 Dec 2024 01:09:23 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants