Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #135959

Merged
merged 16 commits into from
Jan 24, 2025
Merged

Rollup of 7 pull requests #135959

merged 16 commits into from
Jan 24, 2025

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

folkertdev and others added 16 commits January 20, 2025 16:57
This is the first step to enable download of precompiled GCC
Co-authored-by: whiteio <chriswhiteiodev@gmail.com>
The size of this struct depends on the alignment of `u128`, for example
powerpc64le and s390x have align-8 and end up with only 280 bytes. Our
64-bit tier-1 arches are the same though, so let's just assert on those.
We want kernels to be able to use this bare metal target, so
let's enable the sanitizers that kernels want to use.
Enable `unreachable_pub` lint in `test` and `proc_macro` crates

This PR enables the [`unreachable_pub`](https://doc.rust-lang.org/rustc/lints/listing/allowed-by-default.html#unreachable-pub) lint as warn in the `test` and `proc_macro` crates.

The diff was mostly generated with `./x.py fix --stage 1 library/proc_macro/ -- --broken-code`, as well as manual edits for code in macros and in tests.

Continuation of rust-lang#134286

r? libs
Make it possible to build GCC on CI

This is the first step towards eventually enabling download of precompiled GCC from our CI.

Currently, we prebuild `libgccjit` on CI and cache it in Docker. This PR improves the bootstrap GCC step to make it work on CI, and also to make it faster by using sccache. After this change, an actual build on CI should take only 2-3 minutes.

Note that this PR does not yet remove the `build-gccjit.sh` script and replace it with the bootstrap step, I'll leave that to a follow-up PR.

The added `flex` package and the ZSTD library fix were needed to make GCC build on CI.

CC ``````@GuillaumeGomez``````

r? ``````@onur-ozkan``````
support wasm inline assembly in `naked_asm!`

fixes rust-lang#135518

Webassembly was overlooked previously, but now `naked_asm!` and `#[naked]` functions work on the webassembly targets.

Or, they almost do right now. I guess this is no surprise, but the `wasm32-unknown-unknown` target causes me some trouble. I'll add some inline comments with more details.

r? ```````@bjorn3```````

cc ```````@daxpedda,``````` ```````@tgross35```````
CI: free disk with in-tree script instead of GitHub Action
Only assert the `Parser` size on specific arches

The size of this struct depends on the alignment of `u128`, for example
powerpc64le and s390x have align-8 and end up with only 280 bytes. Our
64-bit tier-1 arches are the same though, so let's just assert on those.

r? nnethercote
…=Kobzol

ci: use 8 core arm runner for dist-aarch64-linux

try-job: dist-aarch64-linux
…ch64-floats, r=rcvalle

Enable kernel sanitizers for aarch64-unknown-none-softfloat

We want kernels to be able to use this bare metal target, so let's enable the sanitizers that kernels want to use.

cc ```@rcvalle``` ```@ojeda``` ```@maurer```
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 23, 2025
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Jan 23, 2025

📌 Commit b3fcd56 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2025
@bors
Copy link
Contributor

bors commented Jan 24, 2025

⌛ Testing commit b3fcd56 with merge 48ef38d...

@bors
Copy link
Contributor

bors commented Jan 24, 2025

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 48ef38d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 24, 2025
@bors bors merged commit 48ef38d into rust-lang:master Jan 24, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 24, 2025
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#135366 Enable unreachable_pub lint in test and proc_macro cr… 95f3a2fc7ddc21d7fc8552dad4cd3378c1579668 (link)
#135638 Make it possible to build GCC on CI 9727c8b70753c05b10abfe8127a27a4bc16da267 (link)
#135648 support wasm inline assembly in naked_asm! 5319281a4236490c241d9a52f540cd32587b6336 (link)
#135827 CI: free disk with in-tree script instead of GitHub Action 855bc2896a0893ff605794e02185d730a06d3e78 (link)
#135855 Only assert the Parser size on specific arches 6380bc9cdb06df02ee17d81adfa9ed79a18a12c5 (link)
#135878 ci: use 8 core arm runner for dist-aarch64-linux 3506333184c96c12443180c5e6c9bcc832d477bc (link)
#135905 Enable kernel sanitizers for aarch64-unknown-none-softfloat 0ef033f067de1c3a7e996c1c7519d5f4dff13ed3 (link)

previous master: 1c9837df1d

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (48ef38d): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.5% [-0.5%, -0.5%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary 2.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.6% [2.6%, 2.6%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

Results (primary -4.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-4.0% [-7.4%, -1.0%] 13
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -4.0% [-7.4%, -1.0%] 13

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 775.826s -> 775.645s (-0.02%)
Artifact size: 325.94 MiB -> 325.97 MiB (0.01%)

@matthiaskrgr matthiaskrgr deleted the rollup-0jenyfw branch January 25, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants