tests/ui/asm: Remove uses of rustc_attrs, lang_items, and decl_macro features by using minicore #134385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
taiki-e
commented
Dec 16, 2024
| @@ -3,22 +3,10 @@ | |||
| //@ needs-asm-support | |||
|
|
|||
| #![crate_type = "rlib"] | |||
| #![feature(no_core, rustc_attrs, lang_items)] | |||
| #![no_core] | |||
There was a problem hiding this comment.
(I added this test in #131332, but no_core was not needed in the first place for this test.)
| #![crate_type = "rlib"] | ||
| #![no_std] |
There was a problem hiding this comment.
no_std is redundant because no_core implies no_std.
(Although it is mentioned in example in rustc-dev-guide: https://github.com/rust-lang/rustc-dev-guide/blob/master/src/tests/minicore.md)
This comment has been minimized.
This comment has been minimized.
…features by using minicore
taiki-e
force-pushed
the
ui-asm-minicore
branch
from
af29dc8 to
86e0eab
Compare
|
r? compiler-errors @bors r+ rollup |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 16, 2024
…r-errors tests/ui/asm: Remove uses of rustc_attrs, lang_items, and decl_macro features by using minicore Follow-up to rust-lang#132516 (comment). This PR do similar things for remaining tests in tests/ui/asm. r? jieyouxu
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 16, 2024
…r-errors tests/ui/asm: Remove uses of rustc_attrs, lang_items, and decl_macro features by using minicore Follow-up to rust-lang#132516 (comment). This PR do similar things for remaining tests in tests/ui/asm. r? jieyouxu
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 16, 2024
…r-errors tests/ui/asm: Remove uses of rustc_attrs, lang_items, and decl_macro features by using minicore Follow-up to rust-lang#132516 (comment). This PR do similar things for remaining tests in tests/ui/asm. r? jieyouxu
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 16, 2024
…llaumeGomez Rollup of 9 pull requests Successful merges: - rust-lang#132056 (Stabilize `#[diagnostic::do_not_recommend]`) - rust-lang#134124 (CI: use free runners for x86_64-gnu-llvm jobs) - rust-lang#134197 (rustc_mir_build: Clarify that 'mirrored' does not mean 'flipped' or 'reversed') - rust-lang#134260 (Correctly handle comments in attributes in doctests source code) - rust-lang#134277 (rustdoc-search: handle `impl Into<X>` better) - rust-lang#134284 (Keep track of patterns that could have introduced a binding, but didn't) - rust-lang#134337 (reject unsound toggling of RISCV target features) - rust-lang#134385 (tests/ui/asm: Remove uses of rustc_attrs, lang_items, and decl_macro features by using minicore) - rust-lang#134386 (Some trait method vs impl method signature difference diagnostic cleanups) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 16, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#134124 (CI: use free runners for x86_64-gnu-llvm jobs) - rust-lang#134197 (rustc_mir_build: Clarify that 'mirrored' does not mean 'flipped' or 'reversed') - rust-lang#134260 (Correctly handle comments in attributes in doctests source code) - rust-lang#134277 (rustdoc-search: handle `impl Into<X>` better) - rust-lang#134284 (Keep track of patterns that could have introduced a binding, but didn't) - rust-lang#134337 (reject unsound toggling of RISCV target features) - rust-lang#134371 (Check for array lengths that aren't actually `usize`) - rust-lang#134385 (tests/ui/asm: Remove uses of rustc_attrs, lang_items, and decl_macro features by using minicore) - rust-lang#134386 (Some trait method vs impl method signature difference diagnostic cleanups) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 16, 2024
Rollup merge of rust-lang#134385 - taiki-e:ui-asm-minicore, r=compiler-errors tests/ui/asm: Remove uses of rustc_attrs, lang_items, and decl_macro features by using minicore Follow-up to rust-lang#132516 (comment). This PR do similar things for remaining tests in tests/ui/asm. r? jieyouxu
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Dec 18, 2024
…ieyouxu tests/assembly/asm: Remove uses of rustc_attrs and lang_items features by using minicore Similar to rust-lang#134385 (for tests/ui/asm), but for tests/assembly/asm. r? jieyouxu
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 18, 2024
Rollup merge of rust-lang#134436 - taiki-e:assembly-asm-minicore, r=jieyouxu tests/assembly/asm: Remove uses of rustc_attrs and lang_items features by using minicore Similar to rust-lang#134385 (for tests/ui/asm), but for tests/assembly/asm. r? jieyouxu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #132516 (comment).
This PR do similar things for remaining tests in tests/ui/asm.
r? jieyouxu