Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pretty-printing dyn* trait objects #134601

Merged
merged 2 commits into from
Dec 22, 2024
Merged

Support pretty-printing dyn* trait objects #134601

merged 2 commits into from
Dec 22, 2024
+15 −11

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Dec 21, 2024

@rustbot
Copy link
Collaborator

rustbot commented Dec 21, 2024

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 21, 2024
@dtolnay dtolnay mentioned this pull request Dec 21, 2024
Open
10 tasks
@dtolnay dtolnay added A-pretty Area: Pretty printing (including `-Z unpretty`) F-dyn_star `#![feature(dyn_star)]` labels Dec 21, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 21, 2024

📌 Commit 23a2507 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 21, 2024
@dtolnay dtolnay assigned compiler-errors and unassigned BoxyUwU Dec 21, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 22, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 22, 2024
@bors
Auto merge of rust-lang#134640 - matthiaskrgr:rollup-xlstm3o, r=matth…
a2bcfae 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#134364 (Use E0665 for missing `#[default]` on enum and update doc)
 - rust-lang#134601 (Support pretty-printing `dyn*` trait objects)
 - rust-lang#134603 (Explain why a type is not eligible for `impl PointerLike`.)
 - rust-lang#134618 (coroutine_clone: add comments)
 - rust-lang#134630 (Use `&raw` for `ptr` primitive docs)
 - rust-lang#134637 (Flatten effects directory now that it doesn't really test anything specific)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bcdde4e into rust-lang:master Dec 22, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 22, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 22, 2024
@rust-timer
Unrolled build for rust-lang#134601
8fa3942 
Rollup merge of rust-lang#134601 - dtolnay:dynstar, r=compiler-errors

Support pretty-printing `dyn*` trait objects

- Tracking issue: rust-lang#102425
@programmerjake programmerjake mentioned this pull request Dec 22, 2024
Open
@dtolnay dtolnay deleted the dynstar branch December 22, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
A-pretty Area: Pretty printing (including `-Z unpretty`) F-dyn_star `#![feature(dyn_star)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
6 participants
@dtolnay @rustbot @rust-log-analyzer @compiler-errors @bors @BoxyUwU