coroutine_clone: add comments #134618
Merged
coroutine_clone: add comments #134618
+15
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
This PR changes MIR cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras |
|
r=me after fixing the "corotuine" typos |
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
coroutine-clone-comments
branch
2 times, most recently
from
37c2861 to
33de757
Compare
|
r? @lqd |
RalfJung
force-pushed
the
coroutine-clone-comments
branch
from
33de757 to
8f9fede
Compare
|
@bors r=lqd |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 22, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#134364 (Use E0665 for missing `#[default]` on enum and update doc) - rust-lang#134601 (Support pretty-printing `dyn*` trait objects) - rust-lang#134603 (Explain why a type is not eligible for `impl PointerLike`.) - rust-lang#134618 (coroutine_clone: add comments) - rust-lang#134630 (Use `&raw` for `ptr` primitive docs) - rust-lang#134637 (Flatten effects directory now that it doesn't really test anything specific) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 22, 2024
Rollup merge of rust-lang#134618 - RalfJung:coroutine-clone-comments, r=lqd coroutine_clone: add comments I was very surprised to learn that coroutines can be cloned. This has non-trivial semantic consequences that I do not think have been considered. Lucky enough, it's still unstable. Let's add some comments and pointers so we hopefully become aware when a MIR opt actually is in conflict with this. Cc `@rust-lang/wg-mir-opt`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was very surprised to learn that coroutines can be cloned. This has non-trivial semantic consequences that I do not think have been considered. Lucky enough, it's still unstable. Let's add some comments and pointers so we hopefully become aware when a MIR opt actually is in conflict with this.
Cc @rust-lang/wg-mir-opt