Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Auto merge of #133902 - Kobzol:ci-dist-arm-runner, r=MarcoIeni" #134614

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Dec 21, 2024

Reverts #133902

Context: #134612 (comment)

…=MarcoIeni"

This reverts commit b597d2a, reversing
changes made to ff7906b.
@rustbot
Copy link
Collaborator

rustbot commented Dec 21, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 21, 2024
@onur-ozkan
Copy link
Member

Feel free to self r or r=me

@Kobzol
Copy link
Contributor Author

Kobzol commented Dec 21, 2024

@bors r=onur-ozkan p=10

(increasing priority to resolve the rustup blockage)

@bors
Copy link
Contributor

bors commented Dec 21, 2024

📌 Commit 69a6c9c has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 21, 2024
@bors
Copy link
Contributor

bors commented Dec 21, 2024

⌛ Testing commit 69a6c9c with merge 387b245...

@bors
Copy link
Contributor

bors commented Dec 21, 2024

☀️ Test successful - checks-actions
Approved by: onur-ozkan
Pushing 387b245 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 21, 2024
@bors bors merged commit 387b245 into rust-lang:master Dec 21, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 21, 2024
@Kobzol Kobzol deleted the revert-dist-arm branch December 21, 2024 19:02
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (387b245): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.6% [0.5%, 0.6%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -1.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.3% [-1.3%, -1.3%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.3% [-1.3%, -1.3%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 765.578s -> 766.596s (0.13%)
Artifact size: 330.14 MiB -> 330.18 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants