Display valid crate types in error message for --crate-type flag #134720

malezjaa · 2024-12-24T10:09:01Z

This PR improves the error message for the --crate-type flag. When an invalid crate type is provided, the compiler will now show a list of valid options.

Before

After

I based the implementation on OutputType::shorthands_display

Closes #70183

rustbot · 2024-12-24T10:09:09Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BoxyUwU (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

jieyouxu · 2024-12-24T14:44:23Z

I seem to recall not all the targets support all the crate types. For example, does all of the wasm targets support dylib crate type?

Example: https://github.com/rust-lang/rust/pull/130599/files#diff-ec897fdc27fe33a590c42303d7adda80b03a9af4860440e41a235d7081aa2165

Though I suppose the user will get another follow-up error anyway 😄

malezjaa · 2024-12-24T14:52:10Z

You're right 🙂 This error is just to show the valid values for --crate-type.

jieyouxu

Can you add an ui test for this diagnostics?

malezjaa · 2024-12-24T17:34:31Z

Hi, I added the tests. I'm not sure if I did it the right way, though.

src/etc/pre-push.sh

clubby789 · 2024-12-24T20:31:14Z

The UI test looks good. You'll should squash all your changes into one commit

malezjaa · 2024-12-24T20:39:58Z

Done 👍

jieyouxu

Thanks, this looks like a nice improvement, only some tiny stylistic nits, then LGTM.

compiler/rustc_session/src/config.rs

jieyouxu · 2024-12-25T10:41:49Z

Thanks, I'll r+ after PR CI is green.

jieyouxu · 2024-12-25T11:19:09Z

(You might need to rebless the test)

jieyouxu · 2024-12-25T12:40:40Z

Also, can you squash the commits into one? Thanks.

jieyouxu · 2024-12-25T19:36:17Z

Cool.
@bors r+ rollup

bors · 2024-12-25T19:36:19Z

📌 Commit b56ec2f has been approved by jieyouxu

It is now in the queue for this repository.

jieyouxu · 2025-01-06T17:23:02Z

Thanks for the reminder, I missed the cargo bump.

@bors r+ rollup

bors · 2025-01-06T17:23:05Z

📌 Commit 0d5087d has been approved by jieyouxu

It is now in the queue for this repository.

…ues, r=jieyouxu Display valid crate types in error message for --crate-type flag This PR improves the error message for the --crate-type flag. When an invalid crate type is provided, the compiler will now show a list of valid options. ### Before ![image](https://github.com/user-attachments/assets/4922e4e5-eeca-40cd-ac1c-1c6319a81aee) ### After ![image](https://github.com/user-attachments/assets/67ea1f35-aa41-4e4f-8691-47c273d0cff9) I based the implementation on `OutputType::shorthands_display` Closes rust-lang#70183

jhpratt · 2025-01-07T03:04:24Z

@bors r-

presumptive (partial) cause of #135181 (comment)

jieyouxu · 2025-01-07T08:00:16Z

Ah right, I added a new test, may have to rebless it

alex-semenyuk · 2025-02-17T08:04:15Z

@malezjaa
Thanks for your contribution
From wg-triage. Could you please handle this

Ah right, I added a new test, may have to rebless it

Co-authored-by: Jieyou Xu <jieyouxu@outlook.com>

jieyouxu · 2025-03-14T08:04:45Z

I reblessed the test, no significant changes.
@bors r+ rollup

bors · 2025-03-14T08:04:49Z

📌 Commit 90bf2b1 has been approved by jieyouxu

It is now in the queue for this repository.

…ues, r=jieyouxu Display valid crate types in error message for --crate-type flag This PR improves the error message for the --crate-type flag. When an invalid crate type is provided, the compiler will now show a list of valid options. ### Before ![image](https://github.com/user-attachments/assets/4922e4e5-eeca-40cd-ac1c-1c6319a81aee) ### After ![image](https://github.com/user-attachments/assets/67ea1f35-aa41-4e4f-8691-47c273d0cff9) I based the implementation on `OutputType::shorthands_display` Closes rust-lang#70183

Rollup of 6 pull requests Successful merges: - rust-lang#134720 (Display valid crate types in error message for --crate-type flag) - rust-lang#137424 (uefi: helpers: Add DevicePathNode abstractions) - rust-lang#137736 (Don't attempt to export compiler-builtins symbols from rust dylibs) - rust-lang#138451 (Build GCC on CI with GCC, not Clang) - rust-lang#138454 (Improve post-merge workflow) - rust-lang#138477 (Deny impls for `BikeshedGuaranteedNoDrop`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 9 pull requests Successful merges: - rust-lang#134720 (Display valid crate types in error message for --crate-type flag) - rust-lang#137619 (Provide helpful diagnostics for shebang lookalikes) - rust-lang#138353 (remove must_use from <*const T>::expose_provenance) - rust-lang#138452 (Remove `RUN_CHECK_WITH_PARALLEL_QUERIES`) - rust-lang#138469 (remove comment regarding a removed test directive) - rust-lang#138477 (Deny impls for `BikeshedGuaranteedNoDrop`) - rust-lang#138485 (Rustc dev guide subtree update) - rust-lang#138487 (Pass `CI_JOB_DOC_URL` to Docker) - rust-lang#138495 (Take a break from reviews) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#134720 - malezjaa:feat/crate-type-valid-values, r=jieyouxu Display valid crate types in error message for --crate-type flag This PR improves the error message for the --crate-type flag. When an invalid crate type is provided, the compiler will now show a list of valid options. ### Before ![image](https://github.com/user-attachments/assets/4922e4e5-eeca-40cd-ac1c-1c6319a81aee) ### After ![image](https://github.com/user-attachments/assets/67ea1f35-aa41-4e4f-8691-47c273d0cff9) I based the implementation on `OutputType::shorthands_display` Closes rust-lang#70183

Rollup of 9 pull requests Successful merges: - rust-lang#134720 (Display valid crate types in error message for --crate-type flag) - rust-lang#137619 (Provide helpful diagnostics for shebang lookalikes) - rust-lang#138353 (remove must_use from <*const T>::expose_provenance) - rust-lang#138452 (Remove `RUN_CHECK_WITH_PARALLEL_QUERIES`) - rust-lang#138469 (remove comment regarding a removed test directive) - rust-lang#138477 (Deny impls for `BikeshedGuaranteedNoDrop`) - rust-lang#138485 (Rustc dev guide subtree update) - rust-lang#138487 (Pass `CI_JOB_DOC_URL` to Docker) - rust-lang#138495 (Take a break from reviews) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned BoxyUwU Dec 24, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 24, 2024

jieyouxu reviewed Dec 24, 2024

View reviewed changes

malezjaa requested a review from jieyouxu December 24, 2024 17:34

malezjaa force-pushed the feat/crate-type-valid-values branch from 980ca14 to 62353f8 Compare December 24, 2024 19:27

clubby789 reviewed Dec 24, 2024

View reviewed changes

src/etc/pre-push.sh Outdated Show resolved Hide resolved

malezjaa force-pushed the feat/crate-type-valid-values branch from a60dbd4 to 6315245 Compare December 24, 2024 20:39

jieyouxu assigned jieyouxu and unassigned BoxyUwU Dec 25, 2024

jieyouxu approved these changes Dec 25, 2024

View reviewed changes

compiler/rustc_session/src/config.rs Outdated Show resolved Hide resolved

compiler/rustc_session/src/config.rs Outdated Show resolved Hide resolved

jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 25, 2024

jieyouxu added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 25, 2024

This comment has been minimized.

Sign in to view

malezjaa force-pushed the feat/crate-type-valid-values branch from 9a2ef0a to b56ec2f Compare December 25, 2024 12:41

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 25, 2024

jieyouxu added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 6, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2025

jhpratt mentioned this pull request Jan 7, 2025

Rollup of 11 pull requests #135181

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 7, 2025

jieyouxu closed this Jan 7, 2025

jieyouxu reopened this Jan 7, 2025

This comment has been minimized.

Sign in to view

Show valid crate types when the user passes unknown --crate-type value

90bf2b1

Co-authored-by: Jieyou Xu <jieyouxu@outlook.com>

jieyouxu force-pushed the feat/crate-type-valid-values branch from 0d5087d to 90bf2b1 Compare March 14, 2025 08:03

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 14, 2025

jhpratt mentioned this pull request Mar 14, 2025

Rollup of 6 pull requests #138486

Closed

fmease mentioned this pull request Mar 14, 2025

Rollup of 9 pull requests #138506

Merged

bors merged commit f8842bd into rust-lang:master Mar 14, 2025
6 checks passed

rustbot added this to the 1.87.0 milestone Mar 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Display valid crate types in error message for --crate-type flag #134720

Display valid crate types in error message for --crate-type flag #134720

malezjaa commented Dec 24, 2024 •

edited

Loading

rustbot commented Dec 24, 2024

jieyouxu commented Dec 24, 2024 •

edited

Loading

malezjaa commented Dec 24, 2024 •

edited

Loading

jieyouxu left a comment

malezjaa commented Dec 24, 2024

clubby789 commented Dec 24, 2024

malezjaa commented Dec 24, 2024

jieyouxu left a comment

jieyouxu commented Dec 25, 2024

This comment has been minimized.

jieyouxu commented Dec 25, 2024

jieyouxu commented Dec 25, 2024

jieyouxu commented Dec 25, 2024

bors commented Dec 25, 2024

jieyouxu commented Jan 6, 2025

bors commented Jan 6, 2025

jhpratt commented Jan 7, 2025

jieyouxu commented Jan 7, 2025

This comment has been minimized.

alex-semenyuk commented Feb 17, 2025

jieyouxu commented Mar 14, 2025

bors commented Mar 14, 2025

Display valid crate types in error message for --crate-type flag #134720

Display valid crate types in error message for --crate-type flag #134720

Conversation

malezjaa commented Dec 24, 2024 • edited Loading

Before

After

rustbot commented Dec 24, 2024

jieyouxu commented Dec 24, 2024 • edited Loading

malezjaa commented Dec 24, 2024 • edited Loading

jieyouxu left a comment

Choose a reason for hiding this comment

malezjaa commented Dec 24, 2024

clubby789 commented Dec 24, 2024

malezjaa commented Dec 24, 2024

jieyouxu left a comment

Choose a reason for hiding this comment

jieyouxu commented Dec 25, 2024

This comment has been minimized.

jieyouxu commented Dec 25, 2024

jieyouxu commented Dec 25, 2024

jieyouxu commented Dec 25, 2024

bors commented Dec 25, 2024

jieyouxu commented Jan 6, 2025

bors commented Jan 6, 2025

jhpratt commented Jan 7, 2025

jieyouxu commented Jan 7, 2025

This comment has been minimized.

alex-semenyuk commented Feb 17, 2025

jieyouxu commented Mar 14, 2025

bors commented Mar 14, 2025

malezjaa commented Dec 24, 2024 •

edited

Loading

jieyouxu commented Dec 24, 2024 •

edited

Loading

malezjaa commented Dec 24, 2024 •

edited

Loading