Rollup of 6 pull requests #138486

jhpratt · 2025-03-14T10:10:56Z

Successful merges:

Display valid crate types in error message for --crate-type flag #134720 (Display valid crate types in error message for --crate-type flag)
uefi: helpers: Add DevicePathNode abstractions #137424 (uefi: helpers: Add DevicePathNode abstractions)
Don't attempt to export compiler-builtins symbols from rust dylibs #137736 (Don't attempt to export compiler-builtins symbols from rust dylibs)
Build GCC on CI with GCC, not Clang #138451 (Build GCC on CI with GCC, not Clang)
Improve post-merge workflow #138454 (Improve post-merge workflow)
Deny impls for BikeshedGuaranteedNoDrop #138477 (Deny impls for BikeshedGuaranteedNoDrop)

r? @ghost
@rustbot modify labels: rollup

They are marked with hidden visibility to prevent them from getting exported, so we shouldn't ask the linker to export them anyway. The only thing that does it cause a warning on macOS.

- UEFI device path is a series of nodes layed out in a contiguous memory region. So it makes sense to use Iterator abstraction for modeling DevicePaths - This PR has been split off from rust-lang#135368 for easier review. The allow dead_code will be removed in rust-lang#135368 Signed-off-by: Ayush Singh <ayush@beagleboard.org>

To make it easier to experiment locally.

When they are moved around in code, their name changes, which produces too noisy diffs.

So that follow-up CI commands can proceed normally. It will also avoid overwriting `config.toml` when running opt-dist tests locally.

Co-authored-by: Jieyou Xu <jieyouxu@outlook.com>

…ues, r=jieyouxu Display valid crate types in error message for --crate-type flag This PR improves the error message for the --crate-type flag. When an invalid crate type is provided, the compiler will now show a list of valid options. ### Before ![image](https://github.com/user-attachments/assets/4922e4e5-eeca-40cd-ac1c-1c6319a81aee) ### After ![image](https://github.com/user-attachments/assets/67ea1f35-aa41-4e4f-8691-47c273d0cff9) I based the implementation on `OutputType::shorthands_display` Closes rust-lang#70183

…asbishop,cuviper uefi: helpers: Add DevicePathNode abstractions - UEFI device path is a series of nodes layed out in a contiguous memory region. So it makes sense to use Iterator abstraction for modeling DevicePaths - This PR has been split off from rust-lang#135368 for easier review. The allow dead_code will be removed in rust-lang#135368 cc `@nicholasbishop`

…x, r=petrochenkov Don't attempt to export compiler-builtins symbols from rust dylibs They are marked with hidden visibility to prevent them from getting exported, so we shouldn't ask the linker to export them anyway. The only thing that does it cause a warning on macOS. Part of rust-lang#136096 cc `@jyn514`

…meGomez Build GCC on CI with GCC, not Clang It seems that GCC built with Clang misbehaves. I have tested that cg_gcc tests [pass](https://github.com/rust-lang/rust/actions/runs/13842365913/job/38732750617?pr=138451) on CI with a downloaded GCC that was built in this way. Prerequisite for rust-lang#138395. r? `@ghost`

…r=jieyouxu Improve post-merge workflow Contains various fixes for the post-merge workflow implemented in rust-lang#138013, which were suggested on Zulip. This PR changes the grouping of test diffs and ignores doctests, as they are too noisy. I'll post an example output (before/after this PR) in comments below. r? `@jieyouxu`

…anteed-no-drop, r=lcnr Deny impls for `BikeshedGuaranteedNoDrop` r? lcnr

jhpratt · 2025-03-14T10:11:06Z

@bors r+ rollup=never p=5

bors · 2025-03-14T10:11:09Z

📌 Commit 98c85a3 has been approved by jhpratt

It is now in the queue for this repository.

bors · 2025-03-14T10:19:43Z

⌛ Testing commit 98c85a3 with merge de018e3...

Rollup of 6 pull requests Successful merges: - rust-lang#134720 (Display valid crate types in error message for --crate-type flag) - rust-lang#137424 (uefi: helpers: Add DevicePathNode abstractions) - rust-lang#137736 (Don't attempt to export compiler-builtins symbols from rust dylibs) - rust-lang#138451 (Build GCC on CI with GCC, not Clang) - rust-lang#138454 (Improve post-merge workflow) - rust-lang#138477 (Deny impls for `BikeshedGuaranteedNoDrop`) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2025-03-14T12:07:27Z

The job x86_64-mingw-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:

---- [mir-opt] tests\mir-opt\derefer_test.rs stdout ----

error: compilation failed!
status: exit code: 0xc00000fd
command: PATH="D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage2\bin;D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage0-bootstrap-tools\x86_64-pc-windows-gnu\release\deps;D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage0\bin;D:\a\rust\rust\ninja;D:\a\rust\rust\mingw64\bin;C:\msys64\usr\bin;D:\a\rust\rust\sccache;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\3.3.1\x64;C:\cabal\bin;C:\ghcup\bin;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files\R\R-4.4.2\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.21.13\x64\bin;C:\hostedtoolcache\windows\Python\3.9.13\x64\Scripts;C:\hostedtoolcache\windows\Python\3.9.13\x64;C:\hostedtoolcache\windows\Ruby\3.0.7\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.442-6\x64\bin;C:\Program Files\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\dotnet;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\TortoiseSVN\bin;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files\Microsoft SQL Server\150\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\WiX Toolset v3.14\bin;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\Microsoft SQL Server\160\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.9.9\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe" "D:\\a\\rust\\rust\\tests\\mir-opt\\derefer_test.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=C:\\Users\\runneradmin\\.cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=D:\\a\\rust\\rust\\vendor" "--sysroot" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2" "--target=x86_64-pc-windows-gnu" "--check-cfg" "cfg(test,FALSE)" "-O" "-Copt-level=1" "-Zdump-mir=Derefer" "-Zvalidate-mir" "-Zlint-mir" "-Zdump-mir-exclude-pass-number" "-Zmir-include-spans=false" "--crate-type=rlib" "-Zmir-opt-level=0" "-Zmir-enable-passes=+Derefer" "-Zdump-mir-dir=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\mir-opt\\derefer_test" "--emit" "mir" "-C" "prefer-dynamic" "--out-dir" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\mir-opt\\derefer_test" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\native\\rust-test-helpers"
stdout: none
--- stderr -------------------------------
warning: unused variable: `x`
##[warning] --> D:\a\rust\rust\tests\mir-opt\derefer_test.rs:7:9
  |
7 |     let x = &mut (*b.1).0;
  |         ^ help: if this is intentional, prefix it with an underscore: `_x`
  |
  = note: `#[warn(unused_variables)]` on by default

warning: unused variable: `y`
##[warning] --> D:\a\rust\rust\tests\mir-opt\derefer_test.rs:8:9
  |
8 |     let y = &mut (*b.1).1;
  |         ^ help: if this is intentional, prefix it with an underscore: `_y`

warning: variable does not need to be mutable
##[warning] --> D:\a\rust\rust\tests\mir-opt\derefer_test.rs:6:9
  |
6 |     let mut b = (99, &mut a);
  |         ----^
  |         |
  |         help: remove this `mut`
  |
  = note: `#[warn(unused_mut)]` on by default
---
test result: FAILED. 325 passed; 1 failed; 3 ignored; 0 measured; 0 filtered out; finished in 14.02s

Some tests failed in compiletest suite=mir-opt mode=mir-opt host=x86_64-pc-windows-gnu target=x86_64-pc-windows-gnu
Build completed unsuccessfully in 1:39:05
make: *** [Makefile:128: ci-mingw-x] Error 1
  local time: Fri Mar 14 12:07:14 CUT 2025
  network time: Fri, 14 Mar 2025 12:07:14 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

bors · 2025-03-14T12:08:06Z

💔 Test failed - checks-actions

fmease · 2025-03-14T16:31:57Z

tests\mir-opt\derefer_test.rs now leads to a (compile-time?) stack overflow IINM. This doesn't look spurious but I'm not up to date with the current set of common spurious failures

bjorn3 and others added 25 commits February 27, 2025 16:35

Don't attempt to export compiler-builtins symbols from rust dylibs

5014353

They are marked with hidden visibility to prevent them from getting exported, so we shouldn't ask the linker to export them anyway. The only thing that does it cause a warning on macOS.

Fix lint name in unused linker_messages warning

d73479e

Fix pluralization of tests

6f214c5

Add note about the experimental status

208cef4

Print the compared SHAs

2192d5c

Add cache for downloading job metrics

7ed913b

To make it easier to experiment locally.

Collapse report in <details>

5a7f227

Group diffs by tests, rather than job groups

d5d633d

Do not print doctest diffs in the report

f981a0a

When they are moved around in code, their name changes, which produces too noisy diffs.

Create libgccjit.so.0 alias also for CI-downloaded GCC

c437178

Change GCC build flags

955aef5

Use GCC for building GCC

3fc7ca0

Do not overwrite original config.toml in opt-dist

34272a5

So that follow-up CI commands can proceed normally. It will also avoid overwriting `config.toml` when running opt-dist tests locally.

Store libgccjit.so in a lib directory in the GCC CI tarball

38fc116

Deny impls for BikeshedGuaranteedNoDrop

4c32adb

Show valid crate types when the user passes unknown --crate-type value

90bf2b1

Co-authored-by: Jieyou Xu <jieyouxu@outlook.com>

Add clarification about doctests

6ef465b

Ensure that GCC is not built using Clang, as it misbehaves

bf095f6

Rollup merge of rust-lang#138477 - compiler-errors:deny-bikeshed-guar…

98c85a3

…anteed-no-drop, r=lcnr Deny impls for `BikeshedGuaranteedNoDrop` r? lcnr

rustbot added T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Mar 14, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 14, 2025

jhpratt closed this Mar 14, 2025

jhpratt deleted the rollup-765wijj branch March 14, 2025 15:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Rollup of 6 pull requests #138486

Rollup of 6 pull requests #138486

Uh oh!

jhpratt commented Mar 14, 2025

Uh oh!

jhpratt commented Mar 14, 2025

Uh oh!

bors commented Mar 14, 2025

Uh oh!

bors commented Mar 14, 2025

Uh oh!

rust-log-analyzer commented Mar 14, 2025

Uh oh!

bors commented Mar 14, 2025

Uh oh!

fmease commented Mar 14, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Rollup of 6 pull requests #138486

Rollup of 6 pull requests #138486

Uh oh!

Conversation

jhpratt commented Mar 14, 2025

Uh oh!

jhpratt commented Mar 14, 2025

Uh oh!

bors commented Mar 14, 2025

Uh oh!

bors commented Mar 14, 2025

Uh oh!

rust-log-analyzer commented Mar 14, 2025

Uh oh!

bors commented Mar 14, 2025

Uh oh!

fmease commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

fmease commented Mar 14, 2025 •

edited

Loading