Skip to content

Actually print all the relevant parts of a coroutine in verbose mode #134741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 25, 2024
Merged

Actually print all the relevant parts of a coroutine in verbose mode #134741

merged 1 commit into from
Dec 25, 2024

Conversation

compiler-errors
Copy link
Member

I need to actually see these components, idk why we weren't printing them :)

@rustbot
Copy link
Collaborator

rustbot commented Dec 25, 2024

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 25, 2024
lqd
lqd approved these changes Dec 25, 2024
View reviewed changes
Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me when green

@compiler-errors
Copy link
Member Author

@bors r=lqd rollup

@bors
Copy link
Collaborator

bors commented Dec 25, 2024

📌 Commit 9bcd1de has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 25, 2024
@dianqk dianqk mentioned this pull request Dec 25, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 25, 2024
@bors
Auto merge of rust-lang#134748 - DianQK:rollup-3y5fzcx, r=DianQK
68b9e4f 
Rollup of 3 pull requests

Successful merges:

 - rust-lang#134525 (Arbitrary self types v2: unstable doc updates.)
 - rust-lang#134735 (Consider arm to diverge if guard diverges)
 - rust-lang#134741 (Actually print all the relevant parts of a coroutine in verbose mode)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1d10117 into rust-lang:master Dec 25, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 25, 2024
@rust-timer
Unrolled build for rust-lang#134741
7c1ff99 
Rollup merge of rust-lang#134741 - compiler-errors:coroutine-verbose, r=lqd

Actually print all the relevant parts of a coroutine in verbose mode

I need to actually see these components, idk why we weren't printing them :)
@rustbot rustbot added this to the 1.85.0 milestone Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqd lqd lqd approved these changes

Assignees

@chenyukang chenyukang

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @rustbot @bors @lqd @chenyukang