Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 3 pull requests #134748

Merged
merged 6 commits into from
Dec 25, 2024
Merged

Rollup of 3 pull requests #134748

merged 6 commits into from
Dec 25, 2024

Conversation

DianQK
Copy link
Member

@DianQK DianQK commented Dec 25, 2024

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

adetaylor and others added 6 commits December 20, 2024 16:02
@adetaylor
Arbitrary self types v2: unstable doc updates.
33d6ace 
Document these two feature flags.
@compiler-errors
Consider arm to diverge if guard diverges
a6a7071
@compiler-errors
Actually print all the relevant parts of a coroutine in verbose mode
9bcd1de
@DianQK
Rollup merge of rust-lang#134525 - adetaylor:unstable-book-changes, r…
3eba722 
…=wesleywiser

Arbitrary self types v2: unstable doc updates.

Document these two feature flags.

Part of rust-lang#44874 .
@DianQK
Rollup merge of rust-lang#134735 - compiler-errors:arm-diverges, r=Wa…
a247d7b 
…ffleLapkin

Consider arm to diverge if guard diverges

This is not a fix for rust-lang#134734, but I discovered it when I was gauging how difficult it would be to fix that. It does fix a really old test though :>

r? `@WaffleLapkin` or reassign
@DianQK
Rollup merge of rust-lang#134741 - compiler-errors:coroutine-verbose,…
1d10117 
… r=lqd

Actually print all the relevant parts of a coroutine in verbose mode

I need to actually see these components, idk why we weren't printing them :)
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Dec 25, 2024
@DianQK
Copy link
Member Author

DianQK commented Dec 25, 2024

@bors r+ rollup=never p=3

@bors
Copy link
Contributor

bors commented Dec 25, 2024

📌 Commit 1d10117 has been approved by DianQK

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 25, 2024
@bors
Copy link
Contributor

bors commented Dec 25, 2024

⌛ Testing commit 1d10117 with merge 68b9e4f...

@bors
Copy link
Contributor

bors commented Dec 25, 2024

☀️ Test successful - checks-actions
Approved by: DianQK
Pushing 68b9e4f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 25, 2024
@bors bors merged commit 68b9e4f into rust-lang:master Dec 25, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 25, 2024
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#134525 Arbitrary self types v2: unstable doc updates. fd80d83a450ab390f8425df4029c609320771eb4 (link)
#134735 Consider arm to diverge if guard diverges bde755da354374f70c7b93cabe3dc1d10b1dbd47 (link)
#134741 Actually print all the relevant parts of a coroutine in ver… 7c1ff99bd7fa6d3de500c5f7f142b2980d995967 (link)

previous master: 41f2f5c0b7

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@DianQK DianQK deleted the rollup-3y5fzcx branch December 25, 2024 08:53
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (68b9e4f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -2.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.7% [-2.7%, -2.7%] 1
All ❌✅ (primary) - - 0

Cycles

Results (primary -1.2%, secondary -2.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.2% [-1.2%, -1.2%] 1
Improvements ✅
(secondary)		 -2.3% [-2.4%, -2.3%] 2
All ❌✅ (primary) -1.2% [-1.2%, -1.2%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 764.627s -> 763.93s (-0.09%)
Artifact size: 330.50 MiB -> 330.53 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
6 participants
@DianQK @bors @rust-timer @rustbot @adetaylor @compiler-errors