Basic iOS cross compiling support #13574
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added following triplets: i386-apple-ios for simulator arm-apple-ios for armv7 (for now), arm64 planned in future Marked iOS ABI to be compatible with MacOS ABI
Unfortunately LLVM code generation for ARM doesn't allow segmented stack on non-ELF ARM targets
LLVM currently doesn’t support them on DWARF
A little bit cumbersome but for now much easier to configure than Makefile based
Experimenting with build flags, linker flags and TLS storage Note: libuv was switched to be built using xcodebuild instead of make as it was much easier to start. Later it should be changed back to make just for consistency (although xcodebuild shouldn't be a problem for a developer, trying to reach out iOS device compiler) Switched to TLS emulation as it works much better for ARM architecture. Alternative would be do the same through LLVM but since it requires additional patching and maintaining it - for now it should be enough to use this one. Also, for now iOS is marked just as Macos with ARM target. That definitely is a temporary workaround to get it working quickly. It should be changed soon as anyway building for simulator will by still iOS targeting for i386 which will be confusing if it is considered as MacOS
Correct naming + stub implementation for iOS
Some unwinding functions are missing on iOS so implemented simply stubs for them. May be there is a way to simulate their behavior using existing API. Will check it later
iOS sandboxing mode doesn't allow using /dev/random and /dev/urandom and the only way to get it working is to use SecCopyBytes function provided by Security.framework
Considering other code samples, framework suffix is redundant
Deleted some TODOs, commented code and redundant whitespaces
This was referenced Apr 17, 2014
Closed
It should give more compatibility for Android
- Initializing Unsafe with a safer construct - Updated documentation where possible
- using native Unwind_DeleteException - forwarding Unwind_RaiseException to native Unwind_SjLj_RaiseException - still no luck with Unwind_Backtrace
| // get all hardware potential via VFP3 (hardware floating point) | ||
| // and NEON (SIMD) instructions supported by LLVM. | ||
| // Note that without those flags various linking errors might | ||
| // arise as some of intrinsicts are converted into function calls |
| _Unwind_SjLj_RaiseException(exc) | ||
| } | ||
|
|
||
| // On iOS there is no any backtrace function available in |
|
Just a quick explanation on what happens now: I've got working segmented stack support and unwinding. But both do not work out of box and require patches to LLVM and compiler-rt. Patches were submitted almost a week ago and I hope to get some feedback on them soon. |
|
Awesome! For reference, do you have links to the patches? |
|
LLVM: llvm-commits or web-review (I've changed slot from 150 to 149 since our last talk) compiler-rt: I have no public link as I've sent patch to code owner directly by email, his initial estimation of handling patch queue was Friday but it seems it was over-optimistic. Will ping him again. If you want to see patch itself anyway here is it |
|
Closing due to inactivity, but feel free to reopen with a rebase, it would be quite nice to have support for ios! |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 15, 2024
Closes rust-lang#13574 Make sure that `needless_match` doesn't simplify: ``` if let Some(_) = a() { // .. } else let Some(_) = b() { // .. } ``` to: ``` a() ``` changelog: [`needless_match`]: Fix false-positive on if lets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to crosscompile and run on iOS (armv7) devices.
Doesn't yet support builds for simulator and for ARM64.
Might miss some functionality but so far experience is pretty good.