Just some general cleanup in the HashMap module. #13646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // we trigger #11998 when matching on it. I've fallen back to manual | ||
| // iteration until this is fixed. | ||
| // we trigger #11998 when matching on it. I've fallen back to using | ||
| // `contains_key` until this is fixed. |
There was a problem hiding this comment.
This issue has been fixed, can this comment be removed?
|
Looks good to me, thanks! r=me with some squashings |
|
Yay! All squashed. |
|
I think the commit message may have gotten lost somewhere in the rebasing? (it's not as descriptive as it once was) |
I went through the HashMap module, fixed spelling mistakes, minor inefficiencies, added tests, and other trivial changes.
|
Oops. Rebasing is hard. That better? |
bors
added a commit
that referenced
this pull request
Apr 22, 2014
I went through the HashMap module, fixed spelling mistakes, minor inefficiencies, added tests, and other trivial changes. Hopefully this won't be a controversial PR.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 15, 2024
Closes rust-lang#13574 Make sure that `needless_match` doesn't simplify: ``` if let Some(_) = a() { // .. } else let Some(_) = b() { // .. } ``` to: ``` a() ``` changelog: [`needless_match`]: Fix false-positive on if lets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through the HashMap module, fixed spelling mistakes, minor inefficiencies, added tests, and other trivial changes. Hopefully this won't be a controversial PR.