Specialize kinds inference for Unsafe<T>
#13583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yay! |
| tc | TC::InteriorUnsafe | ||
| // FIXME(#13231): This shouldn't be needed after | ||
| // opt-in built-in bounds are implemented. | ||
| (tc | TC::InteriorUnsafe) & !TC::ReachesNoShare |
There was a problem hiding this comment.
just use (tc | TC::InteriorUnsafe) - TC::ReachesNoShare
There was a problem hiding this comment.
Oh, and can you make it TC::Nonsharable, I guess
This patch adds a special rule for `Unsafe<T>` and makes it `Share` regardless of whether T is `Share`. [breaking-change] Closes rust-lang#13125
bors
added a commit
that referenced
this pull request
Apr 22, 2014
This patch adds a special rule for `Unsafe<T>` and makes it `Share` regardless of whether T is `Share`. [breaking-change] Closes #13125 cc @nikomatsakis
|
Awesome, thanks @flaper87! |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 17, 2023
…Env-to-runnables-extraEnv, r=Veykril 13583 rename runnable env to runnables extra env closes rust-lang#13583
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 28, 2024
changelog: don't consider lifetimes in bounded types unused (fix `extra_unused_lifetimes` FP rust-lang#13578)
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 28, 2024
…ifetimes` FP) (rust-lang#13583) Fixes rust-lang#13578 r? @Alexendoo changelog: don't consider lifetimes in bounded types unused (fix `extra_unused_lifetimes` FP rust-lang#13578)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a special rule for
Unsafe<T>and makes itShareregardless of whether T is
Share.[breaking-change]
Closes #13125
cc @nikomatsakis