Downgrade `linker-warnings` to allow-by-default #136098

jyn514 · 2025-01-26T16:29:01Z

This needs more time to bake before we turn it on. Turning it on early risks people silencing the warning indefinitely, before we have the chance to make it less noisy.

cc #136096
fixes #136086 (comment)

r? @saethlin cc @Noratrieb @bjorn3

@rustbot label A-linkage L-linker_messages

Noratrieb · 2025-01-26T17:15:34Z

@bors r+ p=1

bors · 2025-01-26T17:15:37Z

📌 Commit cc0af36 has been approved by Noratrieb

It is now in the queue for this repository.

Noratrieb · 2025-01-26T17:21:48Z

@bors r-
I look really silly now

rustbot · 2025-01-26T17:55:33Z

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

jyn514 · 2025-01-26T18:03:12Z

tests/run-make/rust-lld-by-default-beta-stable/rmake.rs

@@ -12,7 +12,7 @@ use run_make_support::rustc;
 fn main() {
    // A regular compilation should not use rust-lld by default. We'll check that by asking the
    // linker to display its version number with a link-arg.
-    let output = rustc().link_arg("-Wl,-v").input("main.rs").run();
+    let output = rustc().arg("-Wlinker-messages").link_arg("-Wl,-v").input("main.rs").run();


cc @rust-lang/release it continues to make me very uncomfortable to be editing tests that i have no way of running. if this fails in 6 weeks i do not know if i will have time to fix it.

Locally, you can config [rust] channel = "beta" (or stable). For CI, you could temporarily change src/ci/channel for a @bors try attempt.

This test runs in every merge via the x86_64-gnu-stable job:

https://github.com/rust-lang-ci/rust/actions/runs/12975734650/job/36187153380

2025-01-26T16:46:32.1849227Z test [run-make] tests/run-make/rust-lld-by-default-beta-stable ... ok

compiler/rustc_lint_defs/src/builtin.rs

Nightly recently introduced the `linker-messages` lint which prints any messages from linkers. These tests were triggering that lint because they were passing missing directories to the linker. This fixes it by creating empty directories to pass to the linker. Note that this lint will be downgraded soon via rust-lang/rust#136098, but it seemed worthwhile to fix the underlying problem. This also fixes a problem where build_script_needed_for_host_and_target was not testing for the correct command-line flags. These got lost in rust-lang#14132.

saethlin · 2025-01-27T03:24:00Z

@bors r+

bors · 2025-01-27T03:24:02Z

📌 Commit e6e619e has been approved by saethlin

It is now in the queue for this repository.

bors · 2025-01-27T03:56:31Z

💔 Test failed - checks-actions

This needs more time to bake before we turn it on. Turning it on early risks people silencing the warning indefinitely, before we have the chance to make it less noisy.

saethlin · 2025-01-27T04:43:24Z

@bors r+

bors · 2025-01-27T04:43:26Z

📌 Commit 97311a8 has been approved by saethlin

It is now in the queue for this repository.

Downgrade `linker-warnings` to allow-by-default This needs more time to bake before we turn it on. Turning it on early risks people silencing the warning indefinitely, before we have the chance to make it less noisy. cc rust-lang#136096 fixes rust-lang#136086 (comment) r? `@saethlin` cc `@Noratrieb` `@bjorn3` `@rustbot` label A-linkage L-linker_messages

Rollup of 6 pull requests Successful merges: - rust-lang#135876 (fix doc for std::sync::mpmc) - rust-lang#135961 (Fix 2/4 tests skipped by opt-dist) - rust-lang#136037 (Mark all NuttX targets as tier 3 target and support the standard library) - rust-lang#136098 (Downgrade `linker-warnings` to allow-by-default) - rust-lang#136110 (Miri subtree update) - rust-lang#136117 (Subtree update of `rust-analyzer`) r? `@ghost` `@rustbot` modify labels: rollup

jieyouxu · 2025-01-27T12:11:03Z

@bors p=10

pietroalbini · 2025-01-27T12:11:13Z

@bors p=10

Now go to sleep >:(

bors · 2025-01-27T14:36:55Z

⌛ Testing commit 97311a8 with merge 0cffe5c...

bors · 2025-01-27T17:49:26Z

☀️ Test successful - checks-actions
Approved by: saethlin
Pushing 0cffe5c to master...

rust-timer · 2025-01-27T19:05:56Z

Finished benchmarking commit (0cffe5c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 3.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.7%	[3.4%, 4.0%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 773.18s -> 772.206s (-0.13%)
Artifact size: 328.23 MiB -> 328.24 MiB (0.00%)

Nightly recently introduced the `linker-messages` lint which prints any messages from linkers. These tests were triggering that lint because they were passing missing directories to the linker. This fixes it by creating empty directories to pass to the linker. Note that this lint will be downgraded soon via rust-lang/rust#136098, but it seemed worthwhile to fix the underlying problem. This also fixes a problem where build_script_needed_for_host_and_target was not testing for the correct command-line flags. These got lost in rust-lang#14132.

rustbot assigned saethlin Jan 26, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 26, 2025

jyn514 mentioned this pull request Jan 26, 2025

Tracking Issue for enabling the linker-messages lint by default #136096

Open

16 tasks

rustbot added A-linkage Area: linking into static, shared libraries and binaries L-linker_messages Lint: linker_messages labels Jan 26, 2025

This was referenced Jan 26, 2025

rustc hides linker warnings #83436

Open

rustc -v should print out linker output #38206

Open

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 26, 2025

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 26, 2025

jyn514 force-pushed the linker-output branch from cc0af36 to e2c47a0 Compare January 26, 2025 17:55

rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Jan 26, 2025

jyn514 force-pushed the linker-output branch from e2c47a0 to 03ef802 Compare January 26, 2025 18:01

jyn514 commented Jan 26, 2025

View reviewed changes

retep998 reviewed Jan 26, 2025

View reviewed changes

compiler/rustc_lint_defs/src/builtin.rs Outdated Show resolved Hide resolved

madsmtm mentioned this pull request Jan 27, 2025

Make user-specified cflags take precedence over cc-rs flags rust-lang/cmake-rs#232

Open

ChrisDenton mentioned this pull request Jan 27, 2025

Cleanup Windows trace modules rust-lang/backtrace-rs#697

Open

saethlin force-pushed the linker-output branch from 03ef802 to e6e619e Compare January 27, 2025 03:23

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 27, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 27, 2025

Downgrade linker-warnings to allow-by-default

97311a8

This needs more time to bake before we turn it on. Turning it on early risks people silencing the warning indefinitely, before we have the chance to make it less noisy.

saethlin force-pushed the linker-output branch from e6e619e to 97311a8 Compare January 27, 2025 03:57

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2025

tgross35 mentioned this pull request Jan 27, 2025

Fix the missing_abi lint rust-lang/libc#4254

Open

Zalathar mentioned this pull request Jan 27, 2025

Rollup of 6 pull requests #136119

Closed

tgross35 mentioned this pull request Jan 27, 2025

Rework the available Cargo profiles rust-lang/libm#479

Merged

This was referenced Jan 27, 2025

Update getrandom requirement from 0.2.7 to 0.3.0 smol-rs/async-io#215

Merged

Fix build error on Android rust-random/getrandom#588

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 27, 2025

bors merged commit 0cffe5c into rust-lang:master Jan 27, 2025
7 checks passed

rustbot added this to the 1.86.0 milestone Jan 27, 2025

jyn514 deleted the linker-output branch January 27, 2025 17:54

newpavlov mentioned this pull request Jan 27, 2025

Release v0.3.1 rust-random/getrandom#589

Merged

wmmc88 mentioned this pull request Jan 27, 2025

fix: suppress linker warnings exposed by nightly rustc change microsoft/windows-drivers-rs#279

Merged

Emilgardis mentioned this pull request Jan 27, 2025

Linker wrapper script for musl outputs garbage due to set -x cross-rs/cross#1618

Open

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Downgrade `linker-warnings` to allow-by-default #136098

Downgrade `linker-warnings` to allow-by-default #136098

jyn514 commented Jan 26, 2025 •

edited

Loading

Noratrieb commented Jan 26, 2025

bors commented Jan 26, 2025

This comment has been minimized.

Noratrieb commented Jan 26, 2025

rustbot commented Jan 26, 2025

jyn514 Jan 26, 2025

cuviper Jan 26, 2025

Mark-Simulacrum Jan 26, 2025 •

edited

Loading

saethlin commented Jan 27, 2025

bors commented Jan 27, 2025

bors commented Jan 27, 2025

saethlin commented Jan 27, 2025

bors commented Jan 27, 2025

jieyouxu commented Jan 27, 2025

pietroalbini commented Jan 27, 2025

bors commented Jan 27, 2025

bors commented Jan 27, 2025

rust-timer commented Jan 27, 2025

Downgrade linker-warnings to allow-by-default #136098

Downgrade linker-warnings to allow-by-default #136098

Conversation

jyn514 commented Jan 26, 2025 • edited Loading

Noratrieb commented Jan 26, 2025

bors commented Jan 26, 2025

This comment has been minimized.

Noratrieb commented Jan 26, 2025

rustbot commented Jan 26, 2025

jyn514 Jan 26, 2025

Choose a reason for hiding this comment

cuviper Jan 26, 2025

Choose a reason for hiding this comment

Mark-Simulacrum Jan 26, 2025 • edited Loading

Choose a reason for hiding this comment

saethlin commented Jan 27, 2025

bors commented Jan 27, 2025

bors commented Jan 27, 2025

saethlin commented Jan 27, 2025

bors commented Jan 27, 2025

jieyouxu commented Jan 27, 2025

pietroalbini commented Jan 27, 2025

bors commented Jan 27, 2025

bors commented Jan 27, 2025

rust-timer commented Jan 27, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Downgrade `linker-warnings` to allow-by-default #136098

Downgrade `linker-warnings` to allow-by-default #136098

jyn514 commented Jan 26, 2025 •

edited

Loading

Mark-Simulacrum Jan 26, 2025 •

edited

Loading