Skip to content

ci: install node 22 #136631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

marcoieni
Copy link
Member

We saw segmentation faults when running npm on ARM. See zulip.
GitHub runners have node version 20. With this PR we install node version 22, which is the latest LTS. Hopefully they fixed this issue in the latest version.

try-job: aarch64-gnu
try-job: aarch64-gnu-debug

@rustbot
Copy link
Collaborator

rustbot commented Feb 6, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 6, 2025
@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Feb 6, 2025

⌛ Trying commit 8741dbd with merge 616ccea...

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 6, 2025
ci: install node 22

try-job: aarch64-gnu
try-job: aarch64-gnu-debug
@bors
Copy link
Collaborator

bors commented Feb 6, 2025

☀️ Try build successful - checks-actions
Build commit: 616ccea (616ccea27f41dfd87afaa84cacee6f98bab854f7)

@marcoieni
Copy link
Member Author

@rustbot ready

@marcoieni
Copy link
Member Author

Closing because hopefully #136647 will fix the segmentation fault.

@marcoieni marcoieni closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants