Skip to content

Conversation

marcoieni
Copy link
Member

ubuntu 24 on arm has issues.
So imo we should run ubuntu 24 only on x86 runners.
Discussed in zulip.

try-job: aarch64-gnu
try-job: aarch64-gnu-debug

@rustbot
Copy link
Collaborator

rustbot commented Feb 6, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 6, 2025
@marcoieni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 6, 2025
… r=<try>

ci: use ubuntu 22 for free arm runners

try-job: aarch64-gnu
try-job: aarch64-gnu-debug
@bors
Copy link
Collaborator

bors commented Feb 6, 2025

⌛ Trying commit 6021598 with merge 883babc...

@bors
Copy link
Collaborator

bors commented Feb 6, 2025

☀️ Try build successful - checks-actions
Build commit: 883babc (883babc9f72b69a767f155feb5d1f5882a410415)

@marcoieni
Copy link
Member Author

@rustbot ready

@jieyouxu
Copy link
Member

jieyouxu commented Feb 7, 2025

@bors p=50 (runner stability hotfix)

@Kobzol
Copy link
Member

Kobzol commented Feb 7, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 7, 2025

📌 Commit 6021598 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2025
@bors
Copy link
Collaborator

bors commented Feb 7, 2025

⌛ Testing commit 6021598 with merge 5ff18d0...

@bors
Copy link
Collaborator

bors commented Feb 7, 2025

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 5ff18d0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 7, 2025
@bors bors merged commit 5ff18d0 into rust-lang:master Feb 7, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 7, 2025
@marcoieni marcoieni mentioned this pull request Feb 7, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Feb 7, 2025

Pray 🙏

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5ff18d0): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.3%, secondary -2.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.9% [1.9%, 1.9%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.2% [-1.2%, -1.2%] 1
Improvements ✅
(secondary)
-2.9% [-2.9%, -2.9%] 1
All ❌✅ (primary) 0.3% [-1.2%, 1.9%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 778.095s -> 777.403s (-0.09%)
Artifact size: 328.98 MiB -> 329.02 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants