Rollup of 7 pull requests #136713

matthiaskrgr · 2025-02-07T20:31:04Z

Successful merges:

Make sure to use Receiver trait when extracting object method candidate #135179 (Make sure to use Receiver trait when extracting object method candidate)
Add opt_alias_variances and use it in outlives code #136554 (Add opt_alias_variances and use it in outlives code)
[AIX] Update tests/ui/wait-forked-but-failed-child.rs to accomodate exiting and idle processes. #136556 ([AIX] Update tests/ui/wait-forked-but-failed-child.rs to accomodate exiting and idle processes.)
Enable "jump to def" feature on rustc docs #136589 (Enable "jump to def" feature on rustc docs)
sys: net: Add UEFI stubs #136615 (sys: net: Add UEFI stubs)
Remove outdated base_port calculation in std net test #136635 (Remove outdated base_port calculation in std net test)
Move two windows process tests to tests/ui #136682 (Move two windows process tests to tests/ui)

r? @ghost
@rustbot modify labels: rollup

…xiting and idle processes.

- Just a copy of sys/net/unsupported. - Will make the future net PRs easier to review. Signed-off-by: Ayush Singh <ayush@beagleboard.org>

This was never modified since `std::net` was originally introduced, when each CI job was running multiple jobs concurrently which caused issues with fighting over the same ports. This is not the case in the current CI infrastructure, so remove this relic.

…es-object, r=BoxyUwU Make sure to use `Receiver` trait when extracting object method candidate In method confirmation, the `extract_existential_trait_ref` function re-extracts the object type by derefing until it reaches an object. If we're assembling methods via the `Receiver` trait, make sure we re-do our work also using the receiver trait. Fixes rust-lang#135155 cc ``@adetaylor``

…s, r=lcnr Add `opt_alias_variances` and use it in outlives code ...so to fix some subtle outlives bugs with precise capturing in traits, and eventually make it easier to compute variances for "forced unconstrained" trait lifetimes. r? lcnr

…ed-but-failed-child.rs, r=joboet [AIX] Update tests/ui/wait-forked-but-failed-child.rs to accomodate exiting and idle processes. The `wait-forked-but-failed-child.rs` test expects to see an integer PPID in the output of the command: `ps -A -o pid,ppid,args`. However, on AIX, sometimes an integer PPID is not available when a process is either exiting or idle, as documented in https://www.ibm.com/docs/en/aix/7.3?topic=p-ps-command. In these situations, a `-` is instead shown in the PPID column of the `ps` output. This PR updates the test to accommodate this behaviour on AIX by first filtering out the lines of the `ps` output where a `-` is found in the `PPID` column.

…compiler, r=oli-obk Enable "jump to def" feature on rustc docs This PR enables the rustdoc "jump to def" feature which is visible on the source code pages. r? ``@oli-obk``

…joboet sys: net: Add UEFI stubs - Just a copy of sys/net/unsupported. - Will make the future net PRs easier to review. - The reason for a separate folder instead of standalone file is that UEFI has separate the protocols for v4 and v6, and thus will need some abstractions to implement the Rust interface. r? ``@jhpratt``

Remove outdated `base_port` calculation in std net test This was never modified since `std::net` was originally introduced in 395709c, when at that time, each CI runner was running multiple jobs concurrently. This seems to have originally caused issues with jobs fighting over the same ports. This is not the case in the current CI infrastructure, so remove this relic in favor of a simple constant base port number. I double-checked `19600` and nearby port numbers, and this isn't a well-known port number AFAICT[^1]. Closes rust-lang#136633. [^1]: At the time of writing.

…=joboet Move two windows process tests to tests/ui Spawning processes from std unit tests is not something it's well suited for so moving them into tests/ui is more robust and means we don't need to hack around `cmd.exe`. Follow up to rust-lang#136630

matthiaskrgr · 2025-02-07T20:44:17Z

@bors r+ rollup=never p=3

bors · 2025-02-07T20:44:20Z

📌 Commit 0a33d7c has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-02-08T02:57:18Z

⌛ Testing commit 0a33d7c with merge 0148a2b...

bors · 2025-02-08T05:42:12Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 0148a2b to master...

rust-timer · 2025-02-08T05:44:16Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#135179	Make sure to use `Receiver` trait when extracting object me…	`4aa5db56d187fe2611f5640387c3a9a3a17d9edc` (link)
#136554	Add `opt_alias_variances` and use it in outlives code	`31bfd26d2e11af8550b005d42a636def165c647c` (link)
#136556	[AIX] Update tests/ui/wait-forked-but-failed-child.rs to ac…	`183d5598916663220c8a5212ff9e69efdccb8fdb` (link)
#136589	Enable "jump to def" feature on rustc docs	`82ae905ca47c8ba9f8db2ded40e29d26c7c59d79` (link)
#136615	sys: net: Add UEFI stubs	`e7e031e4e32f26c2680b3734ee6ddd4e7df80cb0` (link)
#136635	Remove outdated `base_port` calculation in std net test	`831613b55580a113c673bb187389d759e6a21e65` (link)
#136682	Move two windows process tests to tests/ui	`acf8dea44ba0f5bfa403074f1e73acfeaf3ae056` (link)

previous master: e0607238c9

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2025-02-08T07:03:45Z

Finished benchmarking commit (0148a2b): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	3.3%	[3.3%, 3.3%]	1
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.3%	[3.3%, 3.3%]	1

Max RSS (memory usage)

Results (primary -3.2%, secondary -2.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.2%	[-3.2%, -3.2%]	1
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.4%]	1
All ❌✅ (primary)	-3.2%	[-3.2%, -3.2%]	1

Cycles

Results (primary 3.1%, secondary 3.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.1%	[3.1%, 3.1%]	1
Regressions ❌ (secondary)	3.3%	[3.3%, 3.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.1%	[3.1%, 3.1%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 778.909s -> 778.886s (-0.00%)
Artifact size: 329.06 MiB -> 329.10 MiB (0.01%)

lqd · 2025-02-08T07:09:32Z

We’ll know on future merges but this looks like the periodic noise bump back after a calm period on the less stable benchmarks.

Mark-Simulacrum · 2025-02-10T13:20:55Z

Yeah, doesn't look like a real change on either regression.

compiler-errors and others added 15 commits January 7, 2025 02:27

Make sure to use Receiver trait when extracting object method candidate

999695b

[AIX] Update tests/ui/wait-forked-but-failed-child.rs to accomodate e…

6c4cf30

…xiting and idle processes.

Re-enable "jump to def" feature on rustc docs

e58aa21

sys: net: Add UEFI stubs

4627285

- Just a copy of sys/net/unsupported. - Will make the future net PRs easier to review. Signed-off-by: Ayush Singh <ayush@beagleboard.org>

Add opt_alias_variances and use it in outlives code

d17a4a7

Use split_whitespace() when filtering lines in the ps output

bdaf7a8

Move two windows process tests to tests/ui

6307270

Rollup merge of rust-lang#136589 - GuillaumeGomez:enable-jump-to-def-…

688fc9b

…compiler, r=oli-obk Enable "jump to def" feature on rustc docs This PR enables the rustdoc "jump to def" feature which is visible on the source code pages. r? ``@oli-obk``

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 8, 2025

bors merged commit 0148a2b into rust-lang:master Feb 8, 2025
7 checks passed

rustbot added this to the 1.86.0 milestone Feb 8, 2025

This was referenced Feb 8, 2025

Treat weak alias types more like ADTs when computing implied bounds #122340

Closed

Some miscellaneous edition-related library tweaks #136705

Merged

rustbot added the perf-regression Performance regression. label Feb 8, 2025

Mark-Simulacrum removed the perf-regression Performance regression. label Feb 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 7 pull requests #136713

Rollup of 7 pull requests #136713

Uh oh!

matthiaskrgr commented Feb 7, 2025

Uh oh!

matthiaskrgr commented Feb 7, 2025

Uh oh!

bors commented Feb 7, 2025

Uh oh!

bors commented Feb 8, 2025

Uh oh!

bors commented Feb 8, 2025

Uh oh!

Uh oh!

rust-timer commented Feb 8, 2025

Uh oh!

rust-timer commented Feb 8, 2025

Uh oh!

lqd commented Feb 8, 2025

Uh oh!

Mark-Simulacrum commented Feb 10, 2025

Uh oh!

Uh oh!

Rollup of 7 pull requests #136713

Rollup of 7 pull requests #136713

Uh oh!

Conversation

matthiaskrgr commented Feb 7, 2025

Uh oh!

matthiaskrgr commented Feb 7, 2025

Uh oh!

bors commented Feb 7, 2025

Uh oh!

bors commented Feb 8, 2025

Uh oh!

bors commented Feb 8, 2025

Uh oh!

Uh oh!

rust-timer commented Feb 8, 2025

Uh oh!

rust-timer commented Feb 8, 2025

Overall result: ❌ regressions - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

lqd commented Feb 8, 2025

Uh oh!

Mark-Simulacrum commented Feb 10, 2025

Uh oh!

Uh oh!