Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check whole Unsize predicate for escaping bound vars #136838

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Check whole Unsize predicate for escaping bound vars #136838

merged 1 commit into from
Feb 12, 2025

Conversation

compiler-errors
Copy link
Member

Fixes #136799

@rustbot
Copy link
Collaborator

rustbot commented Feb 10, 2025

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 10, 2025
fmease
fmease approved these changes Feb 12, 2025
View reviewed changes
compiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs
Copy link
Member

@fmease fmease Feb 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, we could harden confirm_builtin_unsize_candidate by moving the no_bound_vars().unwrap() to the predicate obligation as well to get rid of the skip_binder() for the target type / ty arg #‍1.

Doesn't matter tho, it's the old solver after all.

@fmease
Copy link
Member

fmease commented Feb 12, 2025

Thanks! @bors r+ rollup (feat unsize)

@bors
Copy link
Contributor

bors commented Feb 12, 2025

📌 Commit 95357c7 has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2025
@GuillaumeGomez GuillaumeGomez mentioned this pull request Feb 12, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 12, 2025
@bors
Auto merge of rust-lang#136943 - GuillaumeGomez:rollup-amtd3mq, r=Gui…
ef148cd 
…llaumeGomez

Rollup of 10 pull requests

Successful merges:

 - rust-lang#136758 (tests: `-Copt-level=3` instead of `-O` in assembly tests)
 - rust-lang#136761 (tests: `-Copt-level=3` instead of `-O` in codegen tests)
 - rust-lang#136784 (Nuke `Buffer` abstraction from `librustdoc`, take 2 💣)
 - rust-lang#136838 (Check whole `Unsize` predicate for escaping bound vars)
 - rust-lang#136848 (add docs and ut for bootstrap util cache)
 - rust-lang#136871 (dev-guide: Link to `t-lang` procedures for new features)
 - rust-lang#136890 (Change swap_nonoverlapping from lang to library UB)
 - rust-lang#136901 (compiler: give `ExternAbi` truly stable `Hash` and `Ord`)
 - rust-lang#136907 (compiler: Make middle errors `pub(crate)` and bury the dead code)
 - rust-lang#136916 (use cc archiver as default in `cc2ar`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 993eb34 into rust-lang:master Feb 12, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 12, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 12, 2025
@rust-timer
Unrolled build for rust-lang#136838
8a6793f 
Rollup merge of rust-lang#136838 - compiler-errors:escaping-unsize, r=fmease

Check whole `Unsize` predicate for escaping bound vars

Fixes rust-lang#136799
@Kobzol
Copy link
Contributor

Kobzol commented Feb 18, 2025

@rust-timer build 8a6793f

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8a6793f): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.5%, secondary 3.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.5% [2.4%, 2.7%] 2
Regressions ❌
(secondary)		 3.3% [2.4%, 4.5%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.5% [2.4%, 2.7%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 788.874s -> 788.768s (-0.01%)
Artifact size: 347.76 MiB -> 347.78 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmease fmease fmease approved these changes

Assignees

@fmease fmease

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
6 participants
@compiler-errors @rustbot @fmease @bors @Kobzol @rust-timer