Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whole Unsize predicate for escaping bound vars #136838

Merged
merged 1 commit into from
Feb 12, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Copy link
Member

@fmease fmease Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, we could harden confirm_builtin_unsize_candidate by moving the no_bound_vars().unwrap() to the predicate obligation as well to get rid of the skip_binder() for the target type / ty arg #‍1.

Doesn't matter tho, it's the old solver after all.

Original file line number Diff line number Diff line change
Expand Up @@ -920,11 +920,12 @@ impl<'cx, 'tcx> SelectionContext<'cx, 'tcx> {
// T: Trait
// so it seems ok if we (conservatively) fail to accept that `Unsize`
// obligation above. Should be possible to extend this in the future.
let Some(source) = obligation.self_ty().no_bound_vars() else {
let Some(trait_pred) = obligation.predicate.no_bound_vars() else {
// Don't add any candidates if there are bound regions.
return;
};
let target = obligation.predicate.skip_binder().trait_ref.args.type_at(1);
let source = trait_pred.self_ty();
let target = trait_pred.trait_ref.args.type_at(1);

debug!(?source, ?target, "assemble_candidates_for_unsizing");

Expand Down
19 changes: 19 additions & 0 deletions tests/ui/traits/unsize-goal-escaping-bounds.current.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
error[E0277]: the trait bound `for<'a> (): Unsize<(dyn Trait + 'a)>` is not satisfied
--> $DIR/unsize-goal-escaping-bounds.rs:20:5
|
LL | foo();
| ^^^^^ the trait `for<'a> Unsize<(dyn Trait + 'a)>` is not implemented for `()`
|
= note: all implementations of `Unsize` are provided automatically by the compiler, see <https://doc.rust-lang.org/stable/std/marker/trait.Unsize.html> for more information
note: required by a bound in `foo`
--> $DIR/unsize-goal-escaping-bounds.rs:15:17
|
LL | fn foo()
| --- required by a bound in this function
LL | where
LL | for<'a> (): Unsize<dyn Trait + 'a>,
| ^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `foo`

error: aborting due to 1 previous error

For more information about this error, try `rustc --explain E0277`.
22 changes: 22 additions & 0 deletions tests/ui/traits/unsize-goal-escaping-bounds.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
//@ revisions: current next
//@[next] compile-flags: -Znext-solver
//@[next] check-pass
//@ ignore-compare-mode-next-solver (explicit revisions)

#![feature(unsize)]

use std::marker::Unsize;

trait Trait {}
impl Trait for () {}

fn foo()
where
for<'a> (): Unsize<dyn Trait + 'a>,
{
}

fn main() {
foo();
//[current]~^ ERROR the trait bound `for<'a> (): Unsize<(dyn Trait + 'a)>` is not satisfied
}
Loading