Add documentation URL to selected jobs #136911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
T-compiler
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rustbot
added
A-testsuite
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #138350) made this pull request unmergeable. Please resolve the merge conflicts. |
This comment has been minimized.
This comment has been minimized.
Kobzol
changed the title
|
r? @marcoieni |
Kobzol
commented
Mar 13, 2025
| @@ -6,6 +6,10 @@ if [ -n "$CI_JOB_NAME" ]; then | |||
| echo "[CI_JOB_NAME=$CI_JOB_NAME]" | |||
| fi | |||
|
|
|||
| if [ -n "$CI_JOB_DOC_URL" ]; then | |||
There was a problem hiding this comment.
I added this because I want to also add the URL to the comments posted by Rust Log Analyzer. This log entry should help RLA figure out what is the documentation URL.
marcoieni
approved these changes
Mar 13, 2025
|
@bors r=marcoieni |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 14, 2025
Rollup of 16 pull requests Successful merges: - rust-lang#136001 (Overhaul examples for PermissionsExt) - rust-lang#136230 (Reword incorrect documentation about SocketAddr having varying layout) - rust-lang#136892 (Sync Fuchsia target spec with clang Fuchsia driver) - rust-lang#136911 (Add documentation URL to selected jobs) - rust-lang#137870 ( Improve HashMap docs for const and static initializers) - rust-lang#138179 (Add `src/tools/x` to the main workspace) - rust-lang#138389 (use `expect` instead of `allow`) - rust-lang#138396 (Enable metrics and verbose tests in PR CI) - rust-lang#138398 (atomic intrinsics: clarify which types are supported and (if applicable) what happens with provenance) - rust-lang#138432 (fix: remove the check of lld not supporting `@response-file)` - rust-lang#138434 (Visit `PatField` when collecting lint levels) - rust-lang#138441 (update error message) - rust-lang#138442 (EUV: fix place of deref pattern's interior's scrutinee) - rust-lang#138457 (Remove usage of legacy scheme paths on RedoxOS) - rust-lang#138461 (Remove an outdated line from a test comment) - rust-lang#138466 (Remove myself from libs review) Failed merges: - rust-lang#138452 (Remove `RUN_CHECK_WITH_PARALLEL_QUERIES`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 14, 2025
Rollup merge of rust-lang#136911 - Kobzol:ci-helper-link, r=marcoieni Add documentation URL to selected jobs This PR adds the possibility to attach URLs to selected CI jobs, which are then printed at the end of the CI log when a failure happens in that job. The motivation is to allow contributors to find how to fix the specific jobs more quickly. This was proposed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Automatic.20useful.20links.20when.20a.20particular.20CI.20job.20fails.3F). An example output can be seen [here](https://github.com/rust-lang/rust/actions/runs/13836290091/job/38712112523?pr=136911). r? `@ghost`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 14, 2025
Pass `CI_JOB_DOC_URL` to Docker Fix-up for rust-lang#136911. I always forget to pass new environment variables to Docker images.. 🤦♂️ r? `@marcoieni` try-job: x86_64-fuchsia
fmease
added a commit
to fmease/rust
that referenced
this pull request
Mar 14, 2025
…ieni Pass `CI_JOB_DOC_URL` to Docker Fix-up for rust-lang#136911. I always forget to pass new environment variables to Docker images.. 🤦♂️ r? `@marcoieni` try-job: x86_64-fuchsia
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 14, 2025
Rollup merge of rust-lang#138487 - Kobzol:fix-doc-url-docker, r=marcoieni Pass `CI_JOB_DOC_URL` to Docker Fix-up for rust-lang#136911. I always forget to pass new environment variables to Docker images.. 🤦♂️ r? `@marcoieni` try-job: x86_64-fuchsia
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Mar 17, 2025
Pass `CI_JOB_DOC_URL` to Docker Fix-up for rust-lang/rust#136911. I always forget to pass new environment variables to Docker images.. 🤦♂️ r? `@marcoieni` try-job: x86_64-fuchsia
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Mar 19, 2025
Rollup of 16 pull requests Successful merges: - rust-lang#136001 (Overhaul examples for PermissionsExt) - rust-lang#136230 (Reword incorrect documentation about SocketAddr having varying layout) - rust-lang#136892 (Sync Fuchsia target spec with clang Fuchsia driver) - rust-lang#136911 (Add documentation URL to selected jobs) - rust-lang#137870 ( Improve HashMap docs for const and static initializers) - rust-lang#138179 (Add `src/tools/x` to the main workspace) - rust-lang#138389 (use `expect` instead of `allow`) - rust-lang#138396 (Enable metrics and verbose tests in PR CI) - rust-lang#138398 (atomic intrinsics: clarify which types are supported and (if applicable) what happens with provenance) - rust-lang#138432 (fix: remove the check of lld not supporting `@response-file)` - rust-lang#138434 (Visit `PatField` when collecting lint levels) - rust-lang#138441 (update error message) - rust-lang#138442 (EUV: fix place of deref pattern's interior's scrutinee) - rust-lang#138457 (Remove usage of legacy scheme paths on RedoxOS) - rust-lang#138461 (Remove an outdated line from a test comment) - rust-lang#138466 (Remove myself from libs review) Failed merges: - rust-lang#138452 (Remove `RUN_CHECK_WITH_PARALLEL_QUERIES`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to attach URLs to selected CI jobs, which are then printed at the end of the CI log when a failure happens in that job. The motivation is to allow contributors to find how to fix the specific jobs more quickly.
This was proposed on Zulip.
An example output can be seen here.
r? @ghost