Rollup of 16 pull requests #138480

jhpratt · 2025-03-14T05:37:37Z

Successful merges:

Overhaul examples for PermissionsExt #136001 (Overhaul examples for PermissionsExt)
Reword incorrect documentation about SocketAddr having varying layout #136230 (Reword incorrect documentation about SocketAddr having varying layout)
Sync Fuchsia target spec with clang Fuchsia driver #136892 (Sync Fuchsia target spec with clang Fuchsia driver)
Add documentation URL to selected jobs #136911 (Add documentation URL to selected jobs)
Improve HashMap docs for const and static initializers #137870 ( Improve HashMap docs for const and static initializers)
Add src/tools/x to the main workspace #138179 (Add src/tools/x to the main workspace)
use expect instead of allow #138389 (use expect instead of allow)
Enable metrics and verbose tests in PR CI #138396 (Enable metrics and verbose tests in PR CI)
atomic intrinsics: clarify which types are supported and (if applicable) what happens with provenance #138398 (atomic intrinsics: clarify which types are supported and (if applicable) what happens with provenance)
fix: remove the check of lld not supporting @response-file #138432 (fix: remove the check of lld not supporting @response-file)
Visit PatField when collecting lint levels #138434 (Visit PatField when collecting lint levels)
update error message #138441 (update error message)
EUV: fix place of deref pattern's interior's scrutinee #138442 (EUV: fix place of deref pattern's interior's scrutinee)
Remove usage of legacy scheme paths on RedoxOS #138457 (Remove usage of legacy scheme paths on RedoxOS)
Remove an outdated line from a test comment #138461 (Remove an outdated line from a test comment)
Remove myself from libs review #138466 (Remove myself from libs review)

Failed merges:

Remove RUN_CHECK_WITH_PARALLEL_QUERIES #138452 (Remove RUN_CHECK_WITH_PARALLEL_QUERIES)

r? @ghost
@rustbot modify labels: rollup

This fixes rust-lang#91707 by including one overarching example, instead of the small examples that can be misleading.

This updates the Fuchsia target spec with the [Clang Fuchsia driver], which picks up a few changes: * Adds `-z start-stop-visibility=hidden` and `-z rel` to the pre link arguments. * Adds `--execute-only` and `--fix-cortex-a53-843419` for `aarch64-unknown-fuchsia`. * Enables the cpu features equivalent to x86-64-v2 for `x86_64-unknown-fuchsia`, which is our minimum supported x86_64. platform according to [RFC-0073]. * Enables the cpu features `+crc,+aes,+sha2,+neon` on aarch64. * Increases the max atomic width on 86_64 to 128. * Enables stack probes and xray on aarch64 and riscv64. [Clang Fuchsia driver]: https://github.com/llvm/llvm-project/blob/8374d421861cd3d47e21ae7889ba0b4c498e8d85/clang/lib/Driver/ToolChains/Fuchsia.cpp [RFC-0073]: https://fuchsia.dev/fuchsia-src/contribute/governance/rfcs/0073_x86_64_platform_requirement

This is more useful than `allow` as compiler will force us to remove rules that are no longer valid (we already got 2 of them in this change). Signed-off-by: onur-ozkan <work@onurozkan.dev>

In LLVM v9, lld has supported @response-file LLVM v9 was released on 2019-09-19. And the check was added back to 2018-03-14 (1.26.0) via 04442af. It has been more than five years, and we ship our own lld regardlessly. This should be happily removed. See also: * <llvm/llvm-project@bb12396> * <https://reviews.llvm.org/D63024>

[`compile-pass` has since been renamed to `build-pass`](rust-lang#62277)

…le) what happens with provenance

The place previously used here was that of the temporary holding the reference returned by `Deref::deref` or `DerefMut::deref_mut`. However, since the inner pattern of `deref!(inner)` expects the deref-target type itself, this would ICE when that type was inspected (e.g. by the EUV case for slice patterns). This adds a deref projection to fix that. Since current in-tree consumers of EUV (upvar inference and clippy) don't care about Rvalues, the place could be simplified to `self.cat_rvalue(pat.hir_id, self.pat_ty_adjusted(subpat)?)` to save some cycles. I personally find EUV to be a bit fragile, so I've opted for pedantic correctness. Maybe a `HACK` comment would suffice though?

The name:/path path syntax is getting phased out in favor of /scheme/name/path. Also using null: is no longer necessary as /dev/null is available on Redox OS too.

They *used* to not work, however this was fixed in the PR that added the test. I forgot to remove this line or possibly lost its removal while rebasing.

Trying to re-balance my work by reducing reviews for now.

The original reason to exclude it was so it could run before submodules were initialized. However, those have all been converted to subtrees now, so the entire workspace is always ready to go.

Redox OS is moving away from name:/path style paths to /scheme/name/path style paths which are already handled correctly without has_redox_scheme.

Overhaul examples for PermissionsExt This fixes rust-lang#91707 by including one overarching example, instead of the small examples that can be misleading.

…mptions, r=cuviper Reword incorrect documentation about SocketAddr having varying layout This has no longer been the case since these types were moved to `core`. The note on portability remains, but it is reworded to not imply that the size varies by target.

Sync Fuchsia target spec with clang Fuchsia driver This updates the Fuchsia target spec with the [Clang Fuchsia driver], which picks up a few changes: * Adds `-z start-stop-visibility=hidden` and `-z rel` to the pre link arguments. * Adds `--execute-only` and `--fix-cortex-a53-843419` for `aarch64-unknown-fuchsia`. * Enables the equivalent cpu features for `x86-64-v2` for `x86_64-unknown-fuchsia`, which is our minimum supported x86_64 platform according to [RFC-0073]. try-job: x86_64-fuchsia [Clang Fuchsia driver]: https://github.com/llvm/llvm-project/blob/8374d421861cd3d47e21ae7889ba0b4c498e8d85/clang/lib/Driver/ToolChains/Fuchsia.cpp [RFC-0073]: https://fuchsia.dev/fuchsia-src/contribute/governance/rfcs/0073_x86_64_platform_requirement

Add documentation URL to selected jobs This PR adds the possibility to attach URLs to selected CI jobs, which are then printed at the end of the CI log when a failure happens in that job. The motivation is to allow contributors to find how to fix the specific jobs more quickly. This was proposed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Automatic.20useful.20links.20when.20a.20particular.20CI.20job.20fails.3F). An example output can be seen [here](https://github.com/rust-lang/rust/actions/runs/13836290091/job/38712112523?pr=136911). r? `@ghost`

…s-137566, r=cuviper Improve HashMap docs for const and static initializers Closes rust-lang#137566. I clarified the HashMap usage in const and static initializers. I also added examples of how to construct such HashMaps wrapped in LazyLock.

Add `src/tools/x` to the main workspace The original reason to exclude it was so it could run before submodules were initialized. However, those have all been converted to subtrees now, so the entire workspace is always ready to go. I've also alphabetized the workspace members, as it was an untidy mess. 🧹

use `expect` instead of `allow` This is more useful than `allow` as compiler will force us to remove rules that are no longer valid (we already got a few of them in this change).

Remove myself from libs review Trying to re-balance my work by reducing reviews for now.

jhpratt · 2025-03-14T05:37:46Z

@bors r+ rollup=never p=5

bors · 2025-03-14T05:37:48Z

📌 Commit dea8a15 has been approved by jhpratt

It is now in the queue for this repository.

bors · 2025-03-14T07:02:30Z

⌛ Testing commit dea8a15 with merge f7b4354...

bors · 2025-03-14T10:06:59Z

☀️ Test successful - checks-actions
Approved by: jhpratt
Pushing f7b4354 to master...

github-actions · 2025-03-14T10:08:46Z

Post-merge analysis result

Test differences

aarch64-gnu
- library/std/src/path.rs - path::Path::ends_with (line 2554): [missing] -> pass
- library/core/src/net/socket_addr.rs - net::socket_addr::SocketAddrV6::set_ip (line 452): [missing] -> pass
- library/std/src/path.rs - path::Path::as_os_str (line 2191): [missing] -> pass
- library/std/src/os/unix/fs.rs - os::unix::fs::chown (line 1026): [missing] -> pass
- library/std/src/os/unix/fs.rs - os::unix::fs::lchown (line 1066): [missing] -> pass
- library/core/src/intrinsics/mod.rs - intrinsics::ctlz_nonzero (line 2567): [missing] -> pass
- library/std/src/path.rs - path::Path::ancestors (line 2419): [missing] -> pass
- library/core/src/net/socket_addr.rs - net::socket_addr::SocketAddr::is_ipv6 (line 296): [missing] -> pass
- library/std/src/path.rs - path::Path::read_dir (line 2976): [missing] -> pass
- library/core/src/intrinsics/mod.rs - intrinsics::transmute (line 1552): [missing] -> pass
- (and 410 additional testss)
i686-gnu-nopt-1
- library/std/src/path.rs - path::Path::display (line 2874): [missing] -> pass
- library/std/src/path.rs - path::Path::file_prefix (line 2622): [missing] -> pass
- library/std/src/path.rs - path::Iter<'a>::as_path (line 822): [missing] -> pass
- library/std/src/collections/hash/map.rs - collections::hash::map::HashMap<K,V,S>::get (line 895): [missing] -> pass
- library/std/src/path.rs - path::Path::metadata (line 2898): [missing] -> pass
- library/core/src/net/socket_addr.rs - net::socket_addr::SocketAddr::is_ipv4 (line 273): [missing] -> pass
- library/core/src/net/socket_addr.rs - net::socket_addr::SocketAddrV6::port (line 470): [missing] -> pass
- library/std/src/collections/hash/map.rs - collections::hash::map::HashMap<K,V,S>::try_reserve (line 803): [missing] -> pass
- library/std/src/collections/hash/map.rs - collections::hash::map::Entry<'a,K,V>::and_modify (line 2431): [missing] -> pass
- library/std/src/os/unix/fs.rs - os::unix::fs::chown (line 1026): [missing] -> pass
- (and 410 additional testss)
x86_64-gnu-llvm-18-2
- library/core/src/net/socket_addr.rs - net::socket_addr::SocketAddr (line 22): [missing] -> pass
- library/std/src/os/unix/fs.rs - os::unix::fs::FileTypeExt::is_char_device (line 825): [missing] -> pass
- library/std/src/collections/hash/map.rs - collections::hash::map::Entry<'a,K,V>::and_modify (line 2431): [missing] -> pass
- library/std/src/collections/hash/map.rs - collections::hash::map::IntoValues (line 1759): [missing] -> pass
- library/std/src/collections/hash/map.rs - collections::hash::map::OccupiedEntry<'a,K,V>::get (line 2558): [missing] -> pass
- library/std/src/path.rs - path::Path::is_file (line 3065): [missing] -> pass
- library/std/src/path.rs - path::PathBuf (line 1142): [missing] -> pass
- library/std/src/collections/hash/map.rs - collections::hash::map::VacantEntry<'a,K,V>::insert_entry (line 2749): [missing] -> pass
- library/core/src/net/socket_addr.rs - net::socket_addr::SocketAddrV6::set_port (line 488): [missing] -> pass
- library/std/src/path.rs - path::absolute (line 3524): [missing] -> pass
- (and 410 additional testss)
x86_64-gnu-llvm-18-3
- library/std/src/collections/hash/map.rs - collections::hash::map::Entry<'a,K,V>::or_insert_with (line 2358): [missing] -> pass
- library/std/src/collections/hash/map.rs - collections::hash::map::HashMap<K,V,S>::values_mut (line 461): [missing] -> pass
- library/std/src/os/unix/fs.rs - os::unix::fs::MetadataExt::rdev (line 562): [missing] -> pass
- library/core/src/net/socket_addr.rs - net::socket_addr::SocketAddr (line 22): [missing] -> pass
- library/std/src/collections/hash/map.rs - collections::hash::map::VacantEntry<'a,K,V>::key (line 2690): [missing] -> pass
- library/std/src/path.rs - path::Path::iter (line 2848): [missing] -> pass
- library/core/src/intrinsics/mod.rs - intrinsics::write_bytes (line 3860): [missing] -> pass
- library/std/src/collections/hash/map.rs - collections::hash::map::ExtractIf (line 1672): [missing] -> pass
- library/std/src/collections/hash/map.rs - collections::hash::map::HashMap<K,V,S>::shrink_to (line 845): [missing] -> pass
- library/core/src/net/socket_addr.rs - net::socket_addr::SocketAddrV4 (line 70): [missing] -> pass
- (and 410 additional testss)
x86_64-gnu-llvm-18-1
- library/std/src/collections/hash/map.rs - collections::hash::map::HashMap<K,V,S>::remove_entry (line 1272): [missing] -> pass
- library/std/src/collections/hash/map.rs - collections::hash::map::OccupiedEntry<'a,K,V>::get (line 2558): [missing] -> pass
- library/std/src/os/unix/fs.rs - os::unix::fs::PermissionsExt (line 282): [missing] -> pass
- library/std/src/os/unix/fs.rs - os::unix::fs::MetadataExt::atime (line 596): [missing] -> pass
- library/std/src/path.rs - path::Display (line 3193): [missing] -> pass
- library/std/src/path.rs - path::Path::file_name (line 2452): [missing] -> pass
- library/core/src/intrinsics/mod.rs - intrinsics::const_eval_select (line 3136): [missing] -> pass
- library/std/src/collections/hash/map.rs - collections::hash::map::IntoIter (line 1510): [missing] -> pass
- library/std/src/path.rs - path::Components<'a>::as_path (line 674): [missing] -> pass
- library/std/src/collections/hash/map.rs - collections::hash::map::OccupiedEntry<'a,K,V>::key (line 2517): [missing] -> pass
- (and 410 additional testss)
x86_64-gnu-llvm-19-2
- library/std/src/path.rs - path::Component<'a>::as_os_str (line 530): [missing] -> pass
- library/core/src/net/socket_addr.rs - net::socket_addr::SocketAddrV6::port (line 470): [missing] -> pass
- library/std/src/collections/hash/map.rs - collections::hash::map::HashMap<K,V,S>::get_key_value (line 925): [missing] -> pass
- library/core/src/net/socket_addr.rs - net::socket_addr::SocketAddrV4::ip (line 336): [missing] -> pass
- library/std/src/os/unix/fs.rs - os::unix::fs::MetadataExt::uid (line 528): [missing] -> pass
- library/std/src/path.rs - path::PathBuf::into_os_string (line 1634): [missing] -> pass
- library/std/src/collections/hash/map.rs - collections::hash::map::OccupiedEntry<'a,K,V>::key (line 2517): [missing] -> pass
- library/core/src/intrinsics/mod.rs - intrinsics::transmute (line 1587): [missing] -> pass
- library/core/src/intrinsics/mod.rs - intrinsics::is_val_statically_known (line 3311): [missing] -> pass
- library/std/src/collections/hash/map.rs - collections::hash::map::HashMap<K,V,S>::remove_entry (line 1272): [missing] -> pass
- (and 410 additional testss)
x86_64-gnu-llvm-19-3
- library/core/src/net/socket_addr.rs - net::socket_addr::SocketAddrV6::new (line 417): [missing] -> pass
- library/std/src/os/unix/fs.rs - os::unix::fs::MetadataExt::ctime_nsec (line 687): [missing] -> pass
- library/std/src/path.rs - path::PrefixComponent (line 388): [missing] -> pass
- library/std/src/os/unix/fs.rs - os::unix::fs::FileTypeExt::is_fifo (line 843): [missing] -> pass
- library/std/src/path.rs - path::Components (line 573): [missing] -> pass
- library/std/src/path.rs - path::Path::symlink_metadata (line 2917): [missing] -> pass
- library/std/src/path.rs - path::Path::with_file_name (line 2699): [missing] -> pass
- library/std/src/os/unix/fs.rs - os::unix::fs::MetadataExt::ino (line 473): [missing] -> pass
- library/std/src/collections/hash/map.rs - collections::hash::map::HashMap<K,V,S>::try_insert (line 1214): [missing] -> pass
- library/std/src/collections/hash/map.rs - collections::hash::map::VacantEntry<'a,K,V>::insert_entry (line 2749): [missing] -> pass
- (and 410 additional testss)
x86_64-gnu-nopt
- library/std/src/path.rs - path::PathBuf::push (line 1271): [missing] -> pass
- library/core/src/net/socket_addr.rs - net::socket_addr::SocketAddrV6::ip (line 434): [missing] -> pass
- library/core/src/intrinsics/mod.rs - intrinsics::transmute (line 1565): [missing] -> pass
- library/std/src/path.rs - path::PathBuf::set_file_name (line 1413): [missing] -> pass
- library/std/src/collections/hash/map.rs - collections::hash::map::HashMap<K,V,S>::with_hasher (line 301): [missing] -> pass
- library/core/src/net/socket_addr.rs - net::socket_addr::SocketAddrV4::set_port (line 390): [missing] -> pass
- library/std/src/path.rs - path::Path::is_dir (line 3098): [missing] -> pass
- library/std/src/path.rs - path::absolute (line 3524): [missing] -> pass
- library/core/src/net/socket_addr.rs - net::socket_addr::SocketAddrV4::port (line 372): [missing] -> pass
- library/std/src/collections/hash/map.rs - collections::hash::map::HashMap<K,V,S>::extract_if (line 670): [missing] -> pass
- (and 410 additional testss)
x86_64-gnu-llvm-19-1
- library/std/src/path.rs - path::Ancestors (line 1064): [missing] -> pass
- library/std/src/collections/hash/map.rs - collections::hash::map::OccupiedEntry<'a,K,V>::get_mut (line 2584): [missing] -> pass
- library/std/src/path.rs - path::Path::is_file (line 3065): [missing] -> pass
- library/std/src/path.rs - path::Path::read_dir (line 2976): [missing] -> pass
- library/core/src/net/socket_addr.rs - net::socket_addr::SocketAddr::is_ipv6 (line 296): [missing] -> pass
- library/core/src/net/socket_addr.rs - net::socket_addr::SocketAddrV6::flowinfo (line 516): [missing] -> pass
- library/std/src/collections/hash/map.rs - collections::hash::map::HashMap (line 221): [missing] -> pass
- library/std/src/path.rs - path::PathBuf (line 1153): [missing] -> pass
- library/std/src/collections/hash/map.rs - collections::hash::map::HashMap<K,V,S>::entry (line 867): [missing] -> pass
- library/std/src/collections/hash/map.rs - collections::hash::map::HashMap<K,V,S>::reserve (line 778): [missing] -> pass
- (and 410 additional testss)
aarch64-apple
- library/core/src/net/socket_addr.rs - net::socket_addr::SocketAddrV6::set_scope_id (line 579): [missing] -> pass
- library/std/src/collections/hash/map.rs - collections::hash::map::HashMap<K,V,S>::extract_if (line 670): [missing] -> pass
- library/std/src/os/unix/fs.rs - os::unix::fs::OpenOptionsExt::custom_flags (line 418): [missing] -> pass
- library/std/src/path.rs - path::PathBuf::push (line 1281): [missing] -> pass
- library/core/src/intrinsics/mod.rs - intrinsics::ctlz (line 2532): [missing] -> pass
- library/std/src/path.rs - path::Path::new (line 2160): [missing] -> pass
- library/std/src/collections/hash/map.rs - collections::hash::map::HashMap<K,V,S>::remove (line 1244): [missing] -> pass
- library/core/src/intrinsics/mod.rs - intrinsics::transmute (line 1552): [missing] -> pass
- library/std/src/collections/hash/map.rs - collections::hash::map::IntoKeys (line 1729): [missing] -> pass
- library/std/src/path.rs - path::Path::parent (line 2377): [missing] -> pass
- (and 410 additional testss)

(and 12 additional diffs)

rust-timer · 2025-03-14T10:11:30Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#136001	Overhaul examples for PermissionsExt	`c456848b8146b54ea0e3fcea432ed2e14e1dc996` (link)
#136230	Reword incorrect documentation about SocketAddr having vary…	`2d96ab562382dfb04c71e85346b3319dff44eabd` (link)
#136892	Sync Fuchsia target spec with clang Fuchsia driver	`49fa43fdfcefab99a08e939184ea21e91ae0bd33` (link)
#136911	Add documentation URL to selected jobs	`f0d7edb9ce6579e68d90dd693e487dbafdaef8fe` (link)
#137870	Improve HashMap docs for const and static initializers	`bd0d95a8fe1b5a1b512992f8a8d63acd42230575` (link)
#138179	Add `src/tools/x` to the main workspace	`924a93170554b43d2665a395ebaaad59f58ac658` (link)
#138389	use `expect` instead of `allow`	`294d90db02880441077f47b8fbfb8d0fcac7bd82` (link)
#138396	Enable metrics and verbose tests in PR CI	`3c9d6efbd94d8ab1c2857fca13d8cd141e60417a` (link)
#138398	atomic intrinsics: clarify which types are supported and (i…	`e7ce8337663eed9e92480dd73e3ddb1fea9b13d7` (link)
#138432	fix: remove the check of lld not supporting @response-file	`d21bff8525dcfc2f38ba4c98bde2866a7c51cce8` (link)
#138434	Visit `PatField` when collecting lint levels	`47ff4af03739b63c10a7540ccb201d8d95b3ddbf` (link)
#138441	update error message	`8c1e393898f9fb7e4b3c522c20d80a89434242d9` (link)
#138442	EUV: fix place of deref pattern's interior's scrutinee	`cc08dfe8325c9d3f446af7f74191ae4af84e88f2` (link)
#138457	Remove usage of legacy scheme paths on RedoxOS	`de01d482d73b36da9bc216b4e0c3a9fe11f0251a` (link)
#138461	Remove an outdated line from a test comment	`335c068977df9af82b4bee85a935e9722b8b44dc` (link)
#138466	Remove myself from libs review	`37c5c793e5ed0076b7674631a702b95d2a6cded9` (link)

previous master: 523c507d26

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2025-03-14T11:23:10Z

Finished benchmarking commit (f7b4354): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.9%	[-1.9%, -1.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.9%	[-1.9%, -1.9%]	1

Max RSS (memory usage)

Results (primary -0.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.8%	[-0.8%, -0.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.8%	[-0.8%, -0.8%]	1

Cycles

Results (secondary -2.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-3.4%, -2.4%]	11
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 772.321s -> 775.364s (0.39%)
Artifact size: 364.98 MiB -> 365.01 MiB (0.01%)

Rollup of 16 pull requests Successful merges: - rust-lang#136001 (Overhaul examples for PermissionsExt) - rust-lang#136230 (Reword incorrect documentation about SocketAddr having varying layout) - rust-lang#136892 (Sync Fuchsia target spec with clang Fuchsia driver) - rust-lang#136911 (Add documentation URL to selected jobs) - rust-lang#137870 ( Improve HashMap docs for const and static initializers) - rust-lang#138179 (Add `src/tools/x` to the main workspace) - rust-lang#138389 (use `expect` instead of `allow`) - rust-lang#138396 (Enable metrics and verbose tests in PR CI) - rust-lang#138398 (atomic intrinsics: clarify which types are supported and (if applicable) what happens with provenance) - rust-lang#138432 (fix: remove the check of lld not supporting `@response-file)` - rust-lang#138434 (Visit `PatField` when collecting lint levels) - rust-lang#138441 (update error message) - rust-lang#138442 (EUV: fix place of deref pattern's interior's scrutinee) - rust-lang#138457 (Remove usage of legacy scheme paths on RedoxOS) - rust-lang#138461 (Remove an outdated line from a test comment) - rust-lang#138466 (Remove myself from libs review) Failed merges: - rust-lang#138452 (Remove `RUN_CHECK_WITH_PARALLEL_QUERIES`) r? `@ghost` `@rustbot` modify labels: rollup

hkBst and others added 30 commits January 27, 2025 12:51

Overhaul examples for PermissionsExt

0c10339

This fixes rust-lang#91707 by including one overarching example, instead of the small examples that can be misleading.

docs(std): mention LazyLock in const/static HashMap construction

4e703f5

Reword documentation about SocketAddr having varying layout

ffa86bf

Enable metrics and verbose tests in PR CI

d39a258

use expect instead of allow

675ae1a

This is more useful than `allow` as compiler will force us to remove rules that are no longer valid (we already got 2 of them in this change). Signed-off-by: onur-ozkan <work@onurozkan.dev>

Visit PatField when collecting lint levels

8bf33c2

update error message

231627b

[`compile-pass` has since been renamed to `build-pass`](rust-lang#62277)

atomic intrinsics: clarify which types are supported and (if applicab…

88b206d

…le) what happens with provenance

Add doc_url attribute to CI jobs

3cf1a68

Fill doc_url for Rust for Linux and Fuchsia jobs

aab643f

Output job doc URL to allow Rust Log Analyzer to access it

6117644

Print job doc URL on job failure

0c6d24e

Remove usage of legacy scheme paths on RedoxOS

83ee034

The name:/path path syntax is getting phased out in favor of /scheme/name/path. Also using null: is no longer necessary as /dev/null is available on Redox OS too.

Remove an outdated line from a test comment

2c76bf7

They *used* to not work, however this was fixed in the PR that added the test. I forgot to remove this line or possibly lost its removal while rebasing.

Remove myself from libs review

c88dfb2

Trying to re-balance my work by reducing reviews for now.

Add src/tools/x to the main workspace

abed12a

The original reason to exclude it was so it could run before submodules were initialized. However, those have all been converted to subtrees now, so the entire workspace is always ready to go.

Alphabetize the root workspace members

66deb69

Remove separate src/tools/x from rust-analyzer settings

8c91fae

Record the new settings checksums

496788a

Remove has_redox_scheme

43499bf

Redox OS is moving away from name:/path style paths to /scheme/name/path style paths which are already handled correctly without has_redox_scheme.

Rollup merge of rust-lang#136001 - hkBst:patch-21, r=cuviper

c62707e

Overhaul examples for PermissionsExt This fixes rust-lang#91707 by including one overarching example, instead of the small examples that can be misleading.

Rollup merge of rust-lang#138389 - onur-ozkan:use-expect, r=jieyouxu

82d4ab6

use `expect` instead of `allow` This is more useful than `allow` as compiler will force us to remove rules that are no longer valid (we already got a few of them in this change).

Rollup merge of rust-lang#138466 - cuviper:libs-review, r=jieyouxu

dea8a15

Remove myself from libs review Trying to re-balance my work by reducing reviews for now.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 14, 2025

bors merged commit f7b4354 into rust-lang:master Mar 14, 2025
7 checks passed

rustbot added this to the 1.87.0 milestone Mar 14, 2025

jhpratt deleted the rollup-y3b8wu5 branch March 14, 2025 10:08

This was referenced Mar 14, 2025

redesign stage 0 std #119899

Open

remove invalid workspaceFolder prefix from the zed rust-analyzer config #138085

Open

feat: check ARG_MAX on Unix platforms #138439

Merged

scottmcm mentioned this pull request Mar 14, 2025

Allow more top-down inlining for single-BB callees #138157

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 16 pull requests #138480

Rollup of 16 pull requests #138480

jhpratt commented Mar 14, 2025

jhpratt commented Mar 14, 2025

bors commented Mar 14, 2025

bors commented Mar 14, 2025

bors commented Mar 14, 2025

github-actions bot commented Mar 14, 2025

rust-timer commented Mar 14, 2025

rust-timer commented Mar 14, 2025

Rollup of 16 pull requests #138480

Rollup of 16 pull requests #138480

Conversation

jhpratt commented Mar 14, 2025

jhpratt commented Mar 14, 2025

bors commented Mar 14, 2025

bors commented Mar 14, 2025

bors commented Mar 14, 2025

github-actions bot commented Mar 14, 2025

Test differences

rust-timer commented Mar 14, 2025

rust-timer commented Mar 14, 2025

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size