Windows: Update generated bindings #136978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
O-windows
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 15, 2025
Rollup of 9 pull requests Successful merges: - rust-lang#135687 (re-export `FromCoroutine` from `core::iter`) - rust-lang#135813 (CI: split i686-mingw job to three free runners) - rust-lang#136749 (Implement Extend<AsciiChar> for String) - rust-lang#136879 (Add safe new() to NotAllOnes) - rust-lang#136978 (Windows: Update generated bindings) - rust-lang#137028 (mir_build: Clarify some code for lowering `hir::PatExpr` to THIR) - rust-lang#137029 (Remove unnecessary check code in unused_delims) - rust-lang#137056 (made check_argument_compat public for use in miri) - rust-lang#137062 (Forward all default methods for I/O impls) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 15, 2025
Rollup merge of rust-lang#136978 - ChrisDenton:windows-bindgen, r=Amanieu Windows: Update generated bindings Update to windows-bindgen 0.59. This update is aimed at reducing churn in the future, but means a bit more churn now: - `bindings.txt` no longer needs us to write the namespace for each item. This is good because it means in the future we won't need to change them if the namespace changes. However, there are a few where we still need to disambiguate due to duplicate items (this is a bug in the upstream metadata). - The output in `windows-sys.rs` is now sorted. It was mostly sorted before but not intentionally. This should mean future changes are less noisy. The actual code changes are minimal here. A few types are now `bool` instead of `BOOLEAN`, which is more convenient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to windows-bindgen 0.59.
This update is aimed at reducing churn in the future, but means a bit more churn now:
bindings.txtno longer needs us to write the namespace for each item. This is good because it means in the future we won't need to change them if the namespace changes. However, there are a few where we still need to disambiguate due to duplicate items (this is a bug in the upstream metadata).windows-sys.rsis now sorted. It was mostly sorted before but not intentionally. This should mean future changes are less noisy.The actual code changes are minimal here. A few types are now
boolinstead ofBOOLEAN, which is more convenient.