mir_build: Clarify some code for lowering hir::PatExpr to THIR
#137028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the HIR changes in rust-lang#134228, which introduced `PatExpr` to hold the subset of "expressions" that can appear in a pattern.
|
Some changes occurred in match checking cc @Nadrieril |
rustbot
added
S-waiting-on-review
|
r? compiler-errors @bors r+ rollup |
bors
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Feb 14, 2025
…-errors mir_build: Clarify some code for lowering `hir::PatExpr` to THIR A few loosely-related improvements to the code that lowers certain parts of HIR patterns to THIR. I was originally deferring this until after rust-lang#136529, but that PR probably won't happen, whereas these changes should hopefully be uncontroversial. r? Nadrieril or reroll
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 14, 2025
Rollup of 11 pull requests Successful merges: - rust-lang#133312 (triagebot: automatically add more rustdoc related labels) - rust-lang#134016 (Stabilize `const_is_char_boundary` and `const_str_split_at`.) - rust-lang#135813 (CI: split i686-mingw job to three free runners) - rust-lang#136879 (Add safe new() to NotAllOnes) - rust-lang#136971 (Add a new check-pass UI test for returning `impl Fn(T) -> impl Trait`) - rust-lang#136983 (Prepare standard library for Rust 2024 migration) - rust-lang#137002 (Fix early lint check desc in query) - rust-lang#137006 (borrowck diagnostics cleanup: remove an unused and a barely-used field) - rust-lang#137026 (Stabilize (and const-stabilize) `integer_sign_cast`) - rust-lang#137028 (mir_build: Clarify some code for lowering `hir::PatExpr` to THIR) - rust-lang#137032 (Decode metadata buffer in one go) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 15, 2025
Rollup of 9 pull requests Successful merges: - rust-lang#135687 (re-export `FromCoroutine` from `core::iter`) - rust-lang#135813 (CI: split i686-mingw job to three free runners) - rust-lang#136749 (Implement Extend<AsciiChar> for String) - rust-lang#136879 (Add safe new() to NotAllOnes) - rust-lang#136978 (Windows: Update generated bindings) - rust-lang#137028 (mir_build: Clarify some code for lowering `hir::PatExpr` to THIR) - rust-lang#137029 (Remove unnecessary check code in unused_delims) - rust-lang#137056 (made check_argument_compat public for use in miri) - rust-lang#137062 (Forward all default methods for I/O impls) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 15, 2025
Rollup merge of rust-lang#137028 - Zalathar:thir-pat-expr, r=compiler-errors mir_build: Clarify some code for lowering `hir::PatExpr` to THIR A few loosely-related improvements to the code that lowers certain parts of HIR patterns to THIR. I was originally deferring this until after rust-lang#136529, but that PR probably won't happen, whereas these changes should hopefully be uncontroversial. r? Nadrieril or reroll
github-actions bot
pushed a commit
to tautschnig/verify-rust-std
that referenced
this pull request
Mar 11, 2025
Rollup of 9 pull requests Successful merges: - rust-lang#135687 (re-export `FromCoroutine` from `core::iter`) - rust-lang#135813 (CI: split i686-mingw job to three free runners) - rust-lang#136749 (Implement Extend<AsciiChar> for String) - rust-lang#136879 (Add safe new() to NotAllOnes) - rust-lang#136978 (Windows: Update generated bindings) - rust-lang#137028 (mir_build: Clarify some code for lowering `hir::PatExpr` to THIR) - rust-lang#137029 (Remove unnecessary check code in unused_delims) - rust-lang#137056 (made check_argument_compat public for use in miri) - rust-lang#137062 (Forward all default methods for I/O impls) r? `@ghost` `@rustbot` modify labels: rollup
github-actions bot
pushed a commit
to tautschnig/verify-rust-std
that referenced
this pull request
Mar 11, 2025
Rollup of 9 pull requests Successful merges: - rust-lang#135687 (re-export `FromCoroutine` from `core::iter`) - rust-lang#135813 (CI: split i686-mingw job to three free runners) - rust-lang#136749 (Implement Extend<AsciiChar> for String) - rust-lang#136879 (Add safe new() to NotAllOnes) - rust-lang#136978 (Windows: Update generated bindings) - rust-lang#137028 (mir_build: Clarify some code for lowering `hir::PatExpr` to THIR) - rust-lang#137029 (Remove unnecessary check code in unused_delims) - rust-lang#137056 (made check_argument_compat public for use in miri) - rust-lang#137062 (Forward all default methods for I/O impls) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few loosely-related improvements to the code that lowers certain parts of HIR patterns to THIR.
I was originally deferring this until after #136529, but that PR probably won't happen, whereas these changes should hopefully be uncontroversial.
r? Nadrieril or reroll