Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libstd: rustdoc: correct note on fds 0/1/2 pre-main #137492

Merged
merged 1 commit into from
Mar 16, 2025
Merged

libstd: rustdoc: correct note on fds 0/1/2 pre-main #137492

merged 1 commit into from
Mar 16, 2025
+3 −1

Conversation

nabijaczleweli
Copy link
Contributor

Closes: #137490

@rustbot
Copy link
Collaborator

rustbot commented Feb 23, 2025

r? @thomcc

rustbot has assigned @thomcc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 23, 2025
bjorn3
bjorn3 reviewed Feb 24, 2025
View reviewed changes
@thomcc
Copy link
Member

thomcc commented Mar 16, 2025

I suppose this is fine. @bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 16, 2025

📌 Commit 74ec862 has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 16, 2025
@jieyouxu jieyouxu mentioned this pull request Mar 16, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 16, 2025
@bors
Auto merge of rust-lang#138551 - jieyouxu:rollup-ttktelm, r=jieyouxu
d497e43 
Rollup of 4 pull requests

Successful merges:

 - rust-lang#135080 (core: Make `Debug` impl of raw pointers print metadata if present)
 - rust-lang#137492 (libstd: rustdoc: correct note on fds 0/1/2 pre-main)
 - rust-lang#137538 (fix doc path in std::fmt macro)
 - rust-lang#138549 (Fix the OperandRef type for NullOp::{UbChecks,ContractChecks})

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 26dea1d into rust-lang:master Mar 16, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 16, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 16, 2025
@rust-timer
Unrolled build for rust-lang#137492
a48a67e 
Rollup merge of rust-lang#137492 - nabijaczleweli:master, r=thomcc

libstd: rustdoc: correct note on fds 0/1/2 pre-main

Closes: rust-lang#137490
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Mar 19, 2025
@jieyouxu
Rollup merge of rust-lang#137492 - nabijaczleweli:master, r=thomcc
3a03249 
libstd: rustdoc: correct note on fds 0/1/2 pre-main

Closes: rust-lang#137490
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.

What does "before-main stdio file descriptors are not guaranteed to be open on unix platforms" mean?
5 participants
@nabijaczleweli @rustbot @thomcc @bors @bjorn3