fix doc path in std::fmt macro #137538
fix doc path in std::fmt macro #137538
Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
library/std/src/macros.rs
Outdated
| @@ -106,7 +106,7 @@ macro_rules! print { | |||
| /// Use `println!` only for the primary output of your program. Use | |||
| /// [`eprintln!`] instead to print error and progress messages. | |||
| /// | |||
| /// See [the formatting documentation in `std::fmt`](../std/fmt/index.html) | |||
| /// See [the formatting documentation in `std::fmt`](../fmt/index.html) | |||
There was a problem hiding this comment.
That would make it point to https://doc.rust-lang.org/nightly/fmt/index.html, which is not valid. The current code works fine in the rustdoc generated html. I think rust-analyzer will need to be changed to correctly handle this link instead.
|
why is this using an html link in the first place? is there a reason you can't just link directly (ie. |
|
It was likely written before rustdoc supported linking to items. |
tapanprakasht
force-pushed
the
fix-doc-path
branch
from
aed10e4 to
f63981e
Compare
|
@bjorn3 I have updated the links without using the direct html. I see using |
|
This looks good to me. To confirm, you've tested and it works (I don't see a reason that it wouldn't, but wish to make sure). |
Yes. It works. |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
Rollup of 4 pull requests Successful merges: - rust-lang#135080 (core: Make `Debug` impl of raw pointers print metadata if present) - rust-lang#137492 (libstd: rustdoc: correct note on fds 0/1/2 pre-main) - rust-lang#137538 (fix doc path in std::fmt macro) - rust-lang#138549 (Fix the OperandRef type for NullOp::{UbChecks,ContractChecks}) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#137538 - tapanprakasht:fix-doc-path, r=thomcc fix doc path in std::fmt macro fixes rust-lang#137519
fix doc path in std::fmt macro fixes rust-lang#137519
fixes #137519